syntax error for another program.

I have never seen this error before, what is it and how can I fix it?

Code:

---


 #include <iostream.h>
 #include    <conio.h>

 const max_length=10;

 class Stack
    {
      private:
          int stack[max_length];
          int top;

      public:
          Stack( );

          void pop( );
          void push( );
          void print_stack( );
          void show_working( );
    };

 void Stack::Stack( )
    {
      top=-1;

      for(int count=0;count<max_length;count++)
          stack[count]=0;
    }

 void Stack::push( )
    {
      int item;

      cout<<"\n\n\n\n\n\t Enter value to push onto Stack : ";
      cin>>item;

      if(top==(max_length-1))
          cout<<"\n\n\t ***  Error : Stack is full. \n"<<endl;

      else
          {
            top++;
            stack[top]=item;

            cout<<"\n\n\t *** "<<item<<" is pushed onto the Stack."<<endl;
          }

      cout<<"\n\n\n\t\t Pres any key to return to Menu. ";

      getch( );
    }

 void Stack::pop( )
    {
      if(top==-1)
          cout<<"\n\n\n\t ***  Error : Stack is empty. \n"<<endl;

      else
          {
            cout<<"\n\n\n\t *** "<<stack[top]<<" is poped from the Stack."<<endl;

            stack[top]=0;
            top--;
          }

      cout<<"\n\n\n\t\t Pres any key to return to Menu. ";

      getch( );
    }

 void Stack::print_stack( )
    {
      if(top!=-1)
          {
            cout<<"\n\n\n\n\n\t Values pushed onto Stack are : \n"<<endl;

            for(int count=0;count<=top;count++)
                cout<<"\t Stack ["<<count<<"]  =  "<<stack[count]<<endl;
          }

      else
          cout<<"\n\n\n\n\n\t *** Nothing to show. "<<endl;

      cout<<"\n\n\n\t\t Pres any key to return to Menu. ";

      getch( );
    }

 void Stack::show_working( )
    {
      char Key=NULL;
      do
          {
            clrscr( );

            gotoxy(5,5);
            cout<<"Sequential Stack"<<endl;

            gotoxy(10,8);
            cout<<"Select one:"<<endl;

            gotoxy(15,10);
            cout<<"- Press \P\ to Push a value"<<endl;

            gotoxy(15,12);
            cout<<"- Press \O\ to Pop a value"<<endl;

            gotoxy(15,14);
            cout<<"- Press \S\ to Print the values"<<endl;

            gotoxy(15,16);
            cout<<"- Press \E\ to Exit"<<endl;

            Input:

            gotoxy(10,20);
            cout<<"                      ";

            gotoxy(10,20);
            cout<<"Enter your Choice : ";

            Key=getche( );

            if(int(Key)==27 || Key=='e' || Key=='E')
                break;

            else if(Key=='p' || Key=='P')
                push( );

            else if(Key=='o' || Key=='O')
                pop( );

            else if(Key=='s' || Key=='S')
                print_stack( );

            else
                goto Input;
          }
      while(1);
    }

 int main( )
    {
      Stack obj;

      obj.show_working( );

      return 0;
    }

---

Just having a brief look at your code, it appears you're missing a type specifier for the max_length variable.

What error is that?

1. What is error?
2. #include <iostream>
3. conio.h is not standard

Code:

---

Info :stack hoskins v3.cpp: out of date with destination stack hoskins v3.obj
Info :  stack hoskins v3.cpp: source date 11:23:25 AM 12/13/2006  destination date <unknown>
Info :Compiling C:\Documents and Settings\labpc\Desktop\stack hoskins v3.cpp
Error:  stack hoskins v3.cpp(23,6):Constructor cannot have a return type specification
Warn :  stack hoskins v3.cpp(122,11):Conversion may lose significant digits

---

this is where I found out about conio.h

http://www.digitalmars.com/rtl/conio.html

/*void*/ Stack::Stack( )
getche returns int - you store it in char

Do you have an example of the fix on that one?

declare your Key variable as int

thanks, the conversion error is gone. The other one is still there though.

remove the return type of the constructor

where is that?

Code:

---


 #include <iostream.h>
 #include    <conio.h>

 const max_length=10;

 class Stack
    {
      private:
          int stack[max_length];
          int top;

      public:
          Stack( );

          void pop( );
          void push( );
          void print_stack( );
          void show_working( );
    };

 void Stack::Stack( )
    {
      top=-1;

      for(int count=0;count<max_length;count++)
          stack[count]=0;
    }

 void Stack::push( )
    {
      int item;

      cout<<"\n\n\n\n\n\t Enter value to push onto Stack : ";
      cin>>item;

      if(top==(max_length-1))
          cout<<"\n\n\t ***  Error : Stack is full. \n"<<endl;

      else
          {
            top++;
            stack[top]=item;

            cout<<"\n\n\t *** "<<item<<" is pushed onto the Stack."<<endl;
          }

      cout<<"\n\n\n\t\t Pres any key to return to Menu. ";

      getch( );
    }

 void Stack::pop( )
    {
      if(top==-1)
          cout<<"\n\n\n\t ***  Error : Stack is empty. \n"<<endl;

      else
          {
            cout<<"\n\n\n\t *** "<<stack[top]<<" is poped from the Stack."<<endl;

            stack[top]=0;
            top--;
          }

      cout<<"\n\n\n\t\t Pres any key to return to Menu. ";

      getch( );
    }

 void Stack::print_stack( )
    {
      if(top!=-1)
          {
            cout<<"\n\n\n\n\n\t Values pushed onto Stack are : \n"<<endl;

            for(int count=0;count<=top;count++)
                cout<<"\t Stack ["<<count<<"]  =  "<<stack[count]<<endl;
          }

      else
          cout<<"\n\n\n\n\n\t *** Nothing to show. "<<endl;

      cout<<"\n\n\n\t\t Pres any key to return to Menu. ";

      getch( );
    }

 void Stack::show_working( )
    {
      int Key=NULL;
      do
          {
            clrscr( );

            gotoxy(5,5);
            cout<<"Sequential Stack"<<endl;

            gotoxy(10,8);
            cout<<"Select one:"<<endl;

            gotoxy(15,10);
            cout<<"- Press \P\ to Push a value"<<endl;

            gotoxy(15,12);
            cout<<"- Press \O\ to Pop a value"<<endl;

            gotoxy(15,14);
            cout<<"- Press \S\ to Print the values"<<endl;

            gotoxy(15,16);
            cout<<"- Press \E\ to Exit"<<endl;

            Input:

            gotoxy(10,20);
            cout<<"                      ";

            gotoxy(10,20);
            cout<<"Enter your Choice : ";

            Key=getche( );

            if(int(Key)==27 || Key=='e' || Key=='E')
                break;

            else if(Key=='p' || Key=='P')
                push( );

            else if(Key=='o' || Key=='O')
                pop( );

            else if(Key=='s' || Key=='S')
                print_stack( );

            else
                goto Input;
          }
      while(1);
    }

 int main( )
    {
      Stack obj;

      obj.show_working( );

      return 0;
    }

---

void Stack::Stack( )

My teacher has informed me that this program is not acceptable becasue it is object oriented and we were not taught that. Now I have to figure out how to do this simpler and I am running out of time and ideas.

Also, now I have to do both a sequential stack AND a linked queue.

Well, here is my new stack program code. It needs a lot of work.

oops.

Code:

---

#include <iostream.h>
 #include    <conio.h>

const max=10;

int Max=10
push(char item, char stack, char top%)
if top < max
stack[top]=item;
top++;
else overflow;
return;

int Max=10
pop(char item, char stack, char top%)

if top <0
        underflow;
else
top--;
item=stack[top];
stack[top]=0
return;

int main ()
char item
char choice

cout << "input function (A to add, B to delete.)
cin >>choice

if choice=A
        push(item)
else pop(item)

---

thats better.

That code doesn't even come close to compiling. Example, main needs curly braces.

Yeah I know. I had to essentialy throw out the old program because my teacher said it was to advanced for my class. Now I have this.

So fix it so it at least matches what C++ is supposed to look like.