program problems.

I am getting nowhere on this one. any help would be appreciated.

Code:

---

#include <iostream.h>
#include <string.h>
#include <fstream.h>

// this program is supposed to read a list of names from a file and then bubble sort them alphabeticaly
// and allow for binary search.

int max=100

int initialize_input(char inname[], ifstream& input_stream)
{
cout<<"Please type name of input file to sort: ";
cin>>inname;
input_stream.open(inname);
if (input_stream.fail()!=0)
        {
  cout<<"Failure to open input file--sorry";
  return -1;
  }
else
        return 0;
};

int initialize_output(char outname[], ofstream& output_stream)
{
cout<<"Please type name of sorted output file: ";
cin>>outname;
output_stream.open(outname);
if (output_stream.fail()!=0)
        {
  cout<<"Failure to open output file--sorry";
  return -1;
  }
else
        return 0;
};

void bubblesort(long array[],int array_size)
    {
      for(int count_1=0;count_1<array_size;count_1++)
          {
            for(int count_2=0;count_2<array_size-1;count_2++)
                {
                  if(array[count_2]>array[count_2+1])
                      {
                        long temp=array[count_2];
                        array[count_2]=array[count_2+1];
                        array[count_2+1]=temp;
                      }
                }
          }
    return
    }



int binary_search(int array[],int array_size,int element)
    {
      int start=0;
      int end=array_size-1;
      int middle;
      int position=-1;

      middle=(start+end)/2;

      do
          {
            if(element<array[middle])
                end=middle-1;

            else if(element>array[middle])
                start=middle+1;

            middle=(start+end)/2;
          }
      while(start<=end && array[middle]!=element);

      if(array[middle]==element)
          position=middle;

      return position;
    }


void main ()



{
ifstream income;
ofstream outgo;
char answer;  char inname[15]; char outname[15];
char line[max];
char names[max][max];
int test;
int count;

do
{
test=initialize_input(inname,income);
if (test==-1)
        return;

count=0;

test=initialize_output(outname,outgo);
if (test==-1)
        return;

while (income.getline(names[count],100) )
        {
  cout<<names[count]<<endl;
        count++;
  };

cout<<"There are "<<count<<" lines in this file.\n";

sorting(names, count);
cout<<endl<<"Sorted Names: "<<endl;
for (int which=0;which<count;which++)
        {
  cout<<names[which]<<endl;
  outgo<<names[which]<<endl;
  strcpy(line,names[which]);
  };
cout<<"The sorted version of the file has been written to: "<<outname<<endl;

income.close();

outgo.close();

cout<<"Would you like run again('Y' to continue)?\n";
cin>>answer;

}while (answer=='Y');
};

---

You already know better than that nesagsar.

State your problem, where it happens, and what you intend to do.

int max=100;

Code:

---

Info :sort and search hoskins beta v1.cpp: out of date with destination sort and search hoskins beta v1.obj
Info :  sort and search hoskins beta v1.cpp: source date 11:37:01 AM 12/13/2006  destination date <unknown>
Info :Compiling C:\Documents and Settings\labpc\Desktop\sort and search hoskins beta v1.cpp
Error:  sort and search hoskins beta v1.cpp(53,6):Expression syntax
Error:  sort and search hoskins beta v1.cpp(53,6):'bubblesort(long *,int)' cannot return a value
Error:  sort and search hoskins beta v1.cpp(53,6):Return statement missing ;
Error:  sort and search hoskins beta v1.cpp(58,6):Declaration syntax error
Error:  sort and search hoskins beta v1.cpp(136,1):Compound statement missing }

---

So put a ; on the end of the return statement at line 53 - those are what those numbers are, line numbers.

Also, learn how to indent code more consistently, then a whole bunch of problems similar to "Compound statement missing" just vanish, because it becomes very obvious something is missing before you ever press "compile"

Also, main returns an int.

in function bubble_sort
return ;
fixing indentetion and pointing to the error line with comment will help

the program isnt giving me any errors now but still dosent work right.

Code:

---

#include <iostream.h>
#include <string.h>
#include <fstream.h>

// this program is supposed to read a list of names from a file and then bubble sort them alphabeticaly
// and allow for binary search.

const int max=100;

int initialize_input(char inname[], ifstream& input_stream)
{
        cout<<"Please type name of input file to sort: ";
        cin>>inname;
                input_stream.open(inname);
                        if (input_stream.fail()!=0)
                        {
                                  cout<<"Failure to open input file--sorry";
                  return -1;
                  }
        else
        return 0;
};

int initialize_output(char outname[], ofstream& output_stream)
{
        cout<<"Please type name of sorted output file: ";
        cin>>outname;
                output_stream.open(outname);
                        if (output_stream.fail()!=0)
                        {
                          cout<<"Failure to open output file--sorry";
                          return -1;
                    }
        else
        return 0;
};

void bubblesort(char table[max][max],int array_size)
{
    char temp[max];
      for(int count_1=0;count_1<array_size;count_1++)
          {
            for(int count_2=0;count_2<array_size-1;count_2++)
                {
                  if(table[count_2]>table[count_2+1])
                      {
                        strcpy(temp,table[count_2]);
                        strcpy(table[count_2],table[count_2+1]);
                        strcpy(table[count_2+1],temp);
                      }
                }
        }
    return;
}



int binary_search(int array[],int array_size,int element)
{
      int start=0;
      int end=array_size-1;
      int middle;
      int position=-1;

      middle=(start+end)/2;

      do
          {
            if(element<array[middle])
                end=middle-1;

            else if(element>array[middle])
                start=middle+1;

            middle=(start+end)/2;
          }
      while(start<=end && array[middle]!=element);

      if(array[middle]==element)
          position=middle;

      return position;
}


void main ()
{
        ifstream income;
        ofstream outgo;
  char answer;  char inname[15]; char outname[15];
        char line[max];
        char names[max][max];
        int test;
        int count;

                do
                {
                        test=initialize_input(inname,income);
                if (test==-1)
        return;

count=0;

        test=initialize_output(outname,outgo);
        if (test==-1)
        return;

while (income.getline(names[count],100) )
        {
          cout<<names[count]<<endl;
                count++;
  };

cout<<"There are "<<count<<" lines in this file.\n";

        bubblesort(names, count);
                cout<<endl<<"Sorted Names: "<<endl;
                        for (int which=0;which<count;which++)
                        {
                            cout<<names[which]<<endl;
            outgo<<names[which]<<endl;
            strcpy(line,names[which]);
                          };

cout<<"The sorted version of the file has been written to: "<<outname<<endl;

income.close();

outgo.close();

cout<<"Would you like run again('Y' to continue)?\n";
cin>>answer;

}while (answer=='Y');
};

---

table[count_2]>table[count_2+1]

to compare strings use strcmp()

or better - use C++ strings instead of C-style strings... You are learning C++ not C...

My C++ teacher typed in the string code. He just emailed it to me. Is it wrong?

Quote:

---

Originally Posted by nesagsar

My C++ teacher typed in the string code. He just emailed it to me. Is it wrong?

---

Couldn't say without looking on the code he sent.

comparing C-style strings with > IS wrong

teaching to use C-style strings before C++ strings - discussable. IMHO better start with C++ ideology of using classes and only then fallback to C-style extentions... I learned the opposite way and I'm still a C-guy

So is that why my sort routine dosent actually sort the names in the file?

Quote:

---

Originally Posted by nesagsar

So is that why my sort routine dosent actually sort the names in the file?

---

It will definitely prevent the algorithm from working.
Cannot gurantee that there is no other errors

Do you have an example of how to fix it?

use strcmp function to compare C-strings

I changed the ctrcpy lines to strcmp and I complied. Now I have these errors.

Code:

---

Info :sort and search hoskins beta v1.cpp: build due to .OBJ dependency sort and search hoskins beta v1.cpp
Info :  sort and search hoskins beta v1.cpp: cached age 12:27:04 PM 12/13/2006  file age 1:03:28 PM 12/13/2006
Info :Compiling C:\Documents and Settings\labpc\Desktop\sort and search hoskins beta v1.cpp
Error:  sort and search hoskins beta v1.cpp(135,6):Misplaced else
Error:  sort and search hoskins beta v1.cpp(135,13):Misplaced break

---

Code:

---

#include <iostream.h>
#include <string.h>
#include <fstream.h>

// this program is supposed to read a list of names from a file and then bubble sort them alphabeticaly
// and allow for binary search.

const int max=100;

int initialize_input(char inname[], ifstream& input_stream)
{
        cout<<"Please type name of input file to sort: ";
        cin>>inname;
                input_stream.open(inname);
                        if (input_stream.fail()!=0)
                        {
                                  cout<<"Failure to open input file--sorry";
                  return -1;
                  }
        else
        return 0;
};

int initialize_output(char outname[], ofstream& output_stream)
{
        cout<<"Please type name of sorted output file: ";
        cin>>outname;
                output_stream.open(outname);
                        if (output_stream.fail()!=0)
                        {
                          cout<<"Failure to open output file--sorry";
                          return -1;
                    }
        else
        return 0;
};

void bubblesort(char table[max][max],int array_size)
{
    char temp[max];
      for(int count_1=0;count_1<array_size;count_1++)
          {
            for(int count_2=0;count_2<array_size-1;count_2++)
                {
                  if(table[count_2]>table[count_2+1])
                      {
                        strcmp(temp,table[count_2]);
                        strcmp(table[count_2],table[count_2+1]);
                        strcmp(table[count_2+1],temp);
                      }
                }
        }
    return;
}



int binary_search(int array[],int array_size,int element)
{
      int start=0;
      int end=array_size-1;
      int middle;
      int position=-1;

      middle=(start+end)/2;

      do
          {
            if(element<array[middle])
                end=middle-1;

            else if(element>array[middle])
                start=middle+1;

            middle=(start+end)/2;
          }
      while(start<=end && array[middle]!=element);

      if(array[middle]==element)
          position=middle;

      return position;
}


void main ()
{
        ifstream income;
        ofstream outgo;
  char answer;  char inname[15]; char outname[15];
        char line[max];
        char names[max][max];
        int test;
        int count;

                do
                {
                        test=initialize_input(inname,income);
                if (test==-1)
        return;

count=0;

        test=initialize_output(outname,outgo);
        if (test==-1)
        return;

while (income.getline(names[count],100) )
        {
          cout<<names[count]<<endl;
                count++;
  };

cout<<"There are "<<count<<" lines in this file.\n";

        bubblesort(names, count);
                cout<<endl<<"Sorted Names: "<<endl;
                        for (int which=0;which<count;which++)
                        {
                            cout<<names[which]<<endl;
            outgo<<names[which]<<endl;
            strcpy(line,names[which]);
                          };

cout<<"The sorted version of the file has been written to: "<<outname<<endl;

income.close();

outgo.close();

cout<<"Would you like run again('Y' to continue)?\n";
cin>>answer;

}while (answer=='Y');
 else break;
};

---

Did I say to change strcpy to strcmp?
No, definitly not.
I said change comparison with > symbol to strcmp...

is that here

Code:

---

                {
                  if(table[count_2]>table[count_2+1])
                      {

---

meaning you meant this?

Code:

---

                {
                  if(table[count_2]>strcmp table[count_2+1])
                      {

---

the place is correct, the usage is incorrect
you should read a manual on the strcmp() function

I got the sort function to work! yay us!

Now, where do I make the call to the search function?

Code:

---

#include <iostream.h>
#include <string.h>
#include <fstream.h>

// this program is supposed to read a list of names from a file and then bubble sort them alphabeticaly
// and allow for binary search.

const int max=100;

int initialize_input(char inname[], ifstream& input_stream)
{
        cout<<"Please type name of input file to sort: ";
        cin>>inname;
                input_stream.open(inname);
                        if (input_stream.fail()!=0)
                        {
                                  cout<<"Failure to open input file--sorry";
                  return -1;
                  }
        else
        return 0;
};

int initialize_output(char outname[], ofstream& output_stream)
{
        cout<<"Please type name of sorted output file: ";
        cin>>outname;
                output_stream.open(outname);
                        if (output_stream.fail()!=0)
                        {
                          cout<<"Failure to open output file--sorry";
                          return -1;
                    }
        else
        return 0;
};

void bubblesort(char table[max][max],int array_size)
{
    char temp[max];
      for(int count_1=0;count_1<array_size;count_1++)
          {
    cout<<"outer loop\n";
            for(int count_2=0;count_2<array_size-1;count_2++)
                {
      cout<<"inner loop\n";
                  if(strcmp(table[count_2], table[count_2+1])>0)
          {
          cout<<"SWAPPING"<<count_2<<endl;
                        strcpy(temp,table[count_2]);
                        strcpy(table[count_2],table[count_2+1]);
                        strcpy(table[count_2+1],temp);
          }
                }
        }
    return;
}



int binary_search(int array[],int array_size,int element)
{
      int start=0;
      int end=array_size-1;
      int middle;
      int position=-1;

      middle=(start+end)/2;

      do
          {
            if(element<array[middle])
                end=middle-1;

            else if(element>array[middle])
                start=middle+1;

            middle=(start+end)/2;
          }
      while(start<=end && array[middle]!=element);

      if(array[middle]==element)
          position=middle;

      return position;
}


void main ()
{
        ifstream income;
        ofstream outgo;
  char answer;  char inname[15]; char outname[15];
        char line[max];
        char names[max][max];
  int array;
        int test;
        int count;
  int array_size;
  int element;


do{
cout<<"Beginning DO\n";
                        test=initialize_input(inname,income);
                if (test==-1)
        return;

count=0;

        test=initialize_output(outname,outgo);
        if (test==-1)
        return;

while (income.getline(names[count],100) )
        {
          cout<<names[count]<<endl;
                count++;
  };

cout<<"There are "<<count<<" lines in this file.\n";

        bubblesort(names, count);
                cout<<endl<<"Sorted Names: "<<endl;
                        for (int which=0;which<count;which++)
                        {
                            cout<<names[which]<<endl;
            outgo<<names[which]<<endl;
            strcpy(line,names[which]);
                          };

cout<<"The sorted version of the file has been written to: "<<outname<<endl;

income.close();

outgo.close();

 //        binary_search(array,array_size,element);

cout<<"Would you like to run again('Y' to continue)?\n";
cin>>answer;
cout<<"your answer was:"<<answer<<'!';
}while (answer=='Y');
};

---

1) These:

Code:

---

#include <iostream.h>
#include <string.h>
#include <fstream.h>

---

Should be:

Code:

---

#include <iostream>
#include <cstring>
#include <fstream>

---

2)

Code:

---

void main()

---

Should be:

Code:

---

int main()

---

3)

Code:

---

else break;

---

This is your problem. The else has no matching if test and the break is in no loop. Also, try to fix you indentation so that it is easier to read.