Thread: Error on Function with Array

can you say at which line is this occuring ?
When you are declaring first and second string you shouldn't say [5], just *.

Originally Posted by ElastoManiac

can you say at which line is this occuring ?

Thank You for reply.
This is the complete code:

Code:

#include <iostream>
using namespace std; 
#define DIM 2
#define ADIM 5
char firstString[5];
char secondString[5];
void fillMatrix (char [][DIM], int);
void createString (char [] [DIM]);
char *otherString(char *Strings);
int main()
{
char Matrix2x2[ DIM][DIM];
fillMatrix(Matrix2x2, DIM);
cout << "Create a String of 4 char plus terminator from Matrix 2x 2;
createString(Matrix2x2);
return 0; 
}
 
void fillMatrix(char mat[][DIM], int dim)
{
cout << "Fill Matrix 2x2" << endl;
for (int i=0; i<DIM; i++)
for (int j=0; j<DIM; j++)
{
cin >> mat[i][j];
}
return;
}
 
void createString (char mat[] [DIM])
{
int k;
k=0;
for (int i=0; i<DIM; i++)
for (int j=0; j<DIM; j++)
{
firstString[k] = mat [i] [j];
k++;
}
cout << endl;
for (int k=0; k<4; k++)
    cout << firstString[k];
firstString[4] = '\0';
cout << endl;
cout << firstString;
 
// Create secondString  Here is the error
secondString=otherString(firstString);
}
 
 
char *otherString(char *Strings)
{
char *tmpArray;
/* Allocazione dinamica dell' Array */
tmpArray = new char*[]; 
for(int i=0; i<ADIM; i++) 
tmpArray[i] = new char[ADIM];
tmpArray[0] = Strings[2];
tmpArray[1] = Strings[0];
tmpArray[2] = Strings[3];
tmpArray[3] = Strings[1];
tmpArray[4] = '\0';
return tmpArray;
}

This is the complete code with the line of error marked.
Please can You help ?

Best Regards

First of all, if you want to use strings i reccomend the string class.
first and second strings are declared as arrays of 5 chars. while your function return char*.
change the first and seconds string into char* xxx;

You should create your own string class, or use the one from Standard C++. It isn't good to use char*

Code:

const size_t ADIM = 5;

char *otherString(const char *Strings)
{
	char *tmpArray;
	tmpArray = new char[ADIM]; 
	tmpArray[0] = Strings[2];
	tmpArray[1] = Strings[0];
	tmpArray[2] = Strings[3];
	tmpArray[3] = Strings[1];
	tmpArray[4] = '\0';
	return tmpArray;
}

You also need to forget about using that crappy code colouring tool you're using.

> usingnamespace std;
It seems to modify your code into something which won't even compile. How many other mistakes does it introduce?

Regular [code][/code] tags are all that is needed.

Post your latest code.
Can you be more specific than "doesn't work?"