Thread: Runtime error using list<int>.erase()

My problem is that when I use erase() on a set<int>, I get a runtime error (windows must close the program, etc.). Chances are it is something obvious. Here is the relevant code:

Code:

typedef pair<int,set<int> > Square;
typedef vector<Square*> LinePtr;
//...
for(lt2=0;lt2<3;++lt2) {
   LinePtr l = getMyl();
     for(LinePtr::iterator it=l.begin();it!=l.end();++it) {
         Square *sp = *it;
         int lownum = *(ls.begin());
         int highnum = *(++ls.begin());
         if(sp->second.count(lownum)>0) sp->second.erase(lownum);
         if(sp->second.count(highnum)>0) sp->second.erase(highnum);
      }
   }
}

By extensive testing I have concluded that it is the actual erase function that is causing the error, so it is not an invalidated iterator or some other such error. The answer might possibly have to do with my layered use of iterators and pointers.

If the answer is not apparent, what possible causes could there be for a runtime error with erase()?

If sp is null or invalid, then the crash could easily happen in the call to erase.

>> I do not think so, as by printing the contents of it before the crash turns out fine.
When you mess up your memory and try to use an invalid pointer, or other code overwrites memory that doesn't belong to it, anything can happen. It is quite possible (and common) when this happens for some operations to appear to work and others not to. For example, perhaps read-only operations like outputting or calling count will not crash, but an attempt to change the data with erase will.

It is very unlikely that the crash is because of your call to erase specifically. You are doing something wrong with your memory somewhere else in the program.

Thank you, it appears you were right. I stopped using pointers and it worked fine - the only problem now is the logic, but that's my problem.

>> LinePtr l = getMyl();
If you do stop using pointers, be aware of this line and others like it as that is probably copying the entire vector of int/set<int> pairs. A reference would probably be better (assuming getMyl() returns a reference as well).