What's wrong with this code?

Code:

#include <iostream> 
#include <string> 
using namespace std; 

int main() 
{ 
string songs[4]; 
int song2; 
string song; 
int index; 

for (index = 0; index < 5; index ++) 
{ 
cout << "please enter the name of song number " << index + 1; 
cin >> song; 
songs[index] = song; 
} 

cout << "Please enter the number of the song that you want"; 
cin >> song2; 
cout << endl << "you have chosen " << songs[0]; 

}

Can someone please help me find what's wrong with this code. I know it's not a syntax error because the program runs, but it comes up with an error as soon as i've eneterd the fifth song.

It says "Debug assertaion failed!"

Anyone else had this problem? Please help.

Thanks.

Here, you are exceeding the upper bound of your array:

Code:

for (index = 0; index < 5; index ++)

should be:

Code:

for (index = 0; index < 4; index ++)

Here is one recommendation, try this:

Code:

cout << "Please enter the number of the song that you want"; 
cin >> song2; 
cout << endl << "you have chosen " << songs[0];

change to:

Code:

cout << "Please enter the number of the song that you want"; 
cin >> song2; 
cout << endl << "you have chosen " << songs[song2-1];   //will adjust the user's choice to return the desired element from the array

it runs fine on my compiler. maybe supply your compiler name and version as well as OS info.

only thing i could think of to change is:
cin >> song;
songs[index] = song;
to
cin >> songs[index];

again, it works without any changes on my computer..

Originally Posted by nadroj

it runs fine on my compiler.

Dangerous words. The original code writes data beyond the end of an array.

The original code has an array that is 4 elements long (0, 1, 2, 3).
Then it accesses 5 elements (0, 1, 2, 3, 4).

That last element is beyond the end of the array. It's actually better if the program DOES crash; it's a serious error and it's better for the programmer to find and catch it.

initially when i looked at the code i figured it must be an out of bounds type of error.. i some how missed it! even after reading it over afew times. im aware of the problems this program can run and i see the logic error now, dont know how i missed it.