problem with constructors

[robasc]

I cannot seem to initialize my constructor with default parameters. Could anyone give me a good explanation as to why this is happening?

#include <cstdlib>
#include <iostream>
#include <string>
using namespace std;

class secretType
{  
public:
   void print() const;
   void setName();
   void setAge();
   void setWeight();
   void setHeight();
   string getName() const;
   int getAge() const;
   int getWeight() const;
   double getHeight() const;
   secretType secretType(string = " ", int = 0, int = 0, double = 0);
   
private:
   string name;
   int age;
   int weight;
   double height;
};
int main(int argc, char *argv[])
{

    secretType yourName;
    yourName.setName();
    yourName.setAge();
    yourName.setWeight();
    yourName.setHeight();
    yourName.getName();
    yourName.print();
    
    system("PAUSE");
    return EXIT_SUCCESS;
}
// FUNCTION DEFINITIONS

// function to set name.
void secretType:: setName()
{
     cout << "enter your name: "; cin >> name;
}
// function to set age.
void secretType::setAge()
{
     cout << "enter your age: "; cin >> age;
}
// function to set weight.
void secretType:: setWeight()
{
     cout << "enter your weight: "; cin >> weight;
}
// function to set height.
void secretType::setHeight()
{
     cout << "enter your height in decimal format(0ft.0in): "; cin >> height;
}
// function to return name.
string secretType:: getName()const
{
       return name;
}
// function to return age.
int secretType:: getAge() const
{
    return age;
}
// function to return weight.
int secretType:: getWeight() const
{
       return weight;
}
// function to return height.
double secretType:: getHeight() const
{
       return height;
}
// function to print name.
void secretType:: print() const
{
     cout << "name: " << name << " age: " << age << " weight: " << weight << " height: " << height << endl;
}

[laserlight]

Constructors have no return type.

[CornedBee]

Why what is happening? You have no implementation of the constructor. You seem to be misunderstanding something about either constructors or default arguments.

[robasc]

I believe this is it:

#include <cstdlib>
#include <iostream>
#include <string>
using namespace std;

class secretType
{  
public:
   void print() const;
   void setName();
   void setAge();
   void setWeight();
   void setHeight();
   string getName() const;
   int getAge() const;
   int getWeight() const;
   double getHeight() const;
   secretType(string = " ", int = 0, int = 0, double = 0);
   
private:
   string name;
   int age;
   int weight;
   double height;
};
int main(int argc, char *argv[])
{

    secretType yourName;
    yourName.setName();
    yourName.setAge();
    yourName.setWeight();
    yourName.setHeight();
    yourName.getName();
    yourName.print();
    
    system("PAUSE");
    return EXIT_SUCCESS;
}
// FUNCTION DEFINITIONS
secretType::secretType(string name, int age, int weight, double height)
{
  name = " ";
  age = 0;
  weight = 0;
  height = 0;
}
// function to set name.
void secretType:: setName()
{
     cout << "enter your name: "; cin >> name;
}
// function to set age.
void secretType::setAge()
{
     cout << "enter your age: "; cin >> age;
}
// function to set weight.
void secretType:: setWeight()
{
     cout << "enter your weight: "; cin >> weight;
}
// function to set height.
void secretType::setHeight()
{
     cout << "enter your height in decimal format(0ft.0in): "; cin >> height;
}
// function to return name.
string secretType:: getName()const
{
       return name;
}
// function to return age.
int secretType:: getAge() const
{
    return age;
}
// function to return weight.
int secretType:: getWeight() const
{
       return weight;
}
// function to return height.
double secretType:: getHeight() const
{
       return height;
}
// function to print name.
void secretType:: print() const
{
     cout << "name: " << name << " age: " << age << " weight: " << weight << " height: " << height << endl;
}

[SpaceCadet]

A polite observation regarding the constuctor implementation...

secretType::secretType(string name, int age, int weight, double height)
{
  this->name = name;
  this->age = age;
  this->weight = weight;
  this->height = height;
}

You initial code was close to implcitly inlining the constructor. Be careful of this for many reasons. The one that comes to mind is that debuggers can have trouble with inline functions.

[SKeane]

Or?

secretType::secretType(string name, int age, int weight, double height)
: name(name), age(age), weight(weight), height(height)
{
}

[SpaceCadet]

That is more efficient and preferrable.

[nadroj]

if your serious about this class then you should implement better encapsulation.

you have encapsulated your private variables (ie name, age, etc), and have used public accessor functions (gets/sets) for them. this is good, but with the implementations of your accessor functions you dont protect your private data at all. ie, there is no error checking. i could enter an age of -2.

if your just playing around with stuff, otherwise, then its a good start! have fun

[robasc]

Thanks for the information. Yes, I am still learning alot about classes and having fun with them but in the same sense I am also serious, so thanks for all of your help.