Storing in an Array

i would like to know if i am on the right tracks or completely off the rails with this program. i need to Store the name in an array. Then ask for their surname. The program should declare a third array large enough to hold both names including a space between them. The names should both be copied to the third array (with a space between them) and the resultant array output to the screen. i amnot use any string library functions; manage the arrays yourself using loops to do the name copying and concatenation.

This is what i have got soo far and am stuck with the output the final array

Code:

---


char Fname[10];
char Lname2[10];
char FullName;
int i;

cout <<"enter your first name";

for (i=0; i<3; i++)
    {
    cin >> Fname[i];
    }
   
cout<<"Please enter you Second Name";

for (i=0; i<3; i++)
    {
    cin >>Lname2[i];
    }
   
for (i=0; i<20; i++)
{
cout << Fname[i] <<Lname2[i];
 }     
system("pause");
}

---

Read it in with cin.getline().
Printf is a bit more comfortable to use.
Do not use system("pause"), look what I've used

Code:

---

#include <iostream>

int main(){
    char Fname[10];
    char Lname[10];
    char FullName;
    int i;
    printf("Enter your first name: ");
    std::cin.getline(Fname,10,'\n');
    printf("Enter your second name: ");
    std::cin.getline(Lname,10,'\n');
    printf("%s %s\n",Fname,Lname);   
    std::cin.ignore(std::numeric_limits<std::streamsize>::max(),'\n');
}

---

with that code, is it copying it to array1 and array2 to array3? and i thought there were loops to get it to work then way the problem has been set out?

No, there are 2 arrays.
It reads the first name to the first array and the last name to the second array.

ah right, but i need it to check the length cause i needed summat like

Code:

---

for(i=0; i<10; i++)

---

or something like that. once it has checked the first array it stores it and then asks for the second name does the same thing, Then i need The names to both be copied to the third array (with a space between them) and the resultant array output to the screen.

Yes, but if you had taken the time to read his message, you would have known that was not what he wanted to do.

peckitt99:
In your code, Fullname cannot possibly store the concatenated string, since it is a char, not a char[]. You will need to copy the characters from the first string, until you encounter the null character, '\n'. Then you copy the white space, and then copy the characters from the second name until you encounter the null character.

KAISER is it possible for some example code to get me started on it?

Now it does that:

Code:

---

#include <iostream>

int main(){
    char Fname[10];
    char Lname[10];
    char FullName[20];
    printf("Enter your first name: ");
    std::cin.getline(Fname,10,'\n');
    printf("Enter your second name: ");
    std::cin.getline(Lname,10,'\n');
    sprintf(FullName,"%s %s",Fname,Lname);
    printf("%s\n",FullName);   
    std::cin.ignore(std::numeric_limits<std::streamsize>::max(),'\n');
}

---

First of all, you need to define Fullname as an array of 20 characters (including null termination), as 'char fullname[20];'. The loop(s) could be something like:

Code:

---

int i = 0;
while (Fname[i] != '\0') {
  Fullname[i] = Fname[i];
  i ++;
}
Fullname[i] = ' ';
i ++;
int j = 0;
while (Lname[j] != '\0') {
  Fullname[i] = Lname[j];
  j ++;
}

---

yeah that sound more familiar than maxorators code. ill give it a go n see how i go along

His code is perfectly correct, but as you said in the first post that you are not to use any built in string handling, it is not what you asked for.

i have got all the code working with all the other bits but am unsure how to input it all. i tried

Code:

---

Fullname[20] = Fname[i] + Lname[i]

---

the output i got from that was just the first name then a bunch of other characters.

I don't get the question. I though you wanted to 'cin >> Fname;' and 'cin >> Lname;', and then do the copying.

When working with arrays, the assignment operator does not do what you might think. When you learn about pointers you will know why.

well when i got the 2 names in the arrays i need to get the third array to output both the names and put in the space inbetween the Fname and Lname. if this makes any more sence?

The copying is already done, so you just output it. The entire program would look something like this:

Code:

---

int main() {
  char Fname[10];
  char Lname[10];
  char Fullname[20];
  cout << "First name: ";
  cin >> Fname;
  cout << "Family name: ";
  cin >> Lname;
  int i = 0;
  while (Fname[i] != '\0') {
    Fullname[i] = Fname[i];
    i ++;
  }
  Fullname[i] = ' ';
  i ++;
  int j = 0;
  while (Lname[j] != '\0') {
    Fullname[i] = Lname[j];
    i ++;
    j ++;
  }
  Fullname[i] = '\0';
  cout << Fullname << endl;
  return 0;
}

---

yeah i got that but it is the last name that messes up when you output it all. the first name comes out fine but the last name dosnt it comes out in odd ascii charactures.

My code works perfectly well. If you please post yours it will be easier to find what you are doing wrong.

my code is the same as yours i think but here it is anyway...

Code:

---

#include <iostream>
#include <iomanip>

int main()
{

using namespace std;

  char Fname[10];
  char Lname[10];
  char Fullname[20];
 
 
  cout << "First name: ";
  cin >> Fname;
  cout << "Family name: ";
  cin >> Lname;
 
  int i = 0;
 
      while (Fname[i] != '\0')
      {
          Fullname[i] = Fname[i];
          i ++;
      }
 
  Fullname[i] = ' ';
  i++;
 
  int j = 0;
 
      while (Lname[j] != '\0')
      {
          Fullname[i] = Lname[j];
         
          j ++;
      }

  cout << Fullname << endl;
 
 system("pause");
}

---

it also comes up with the first letter of the first name as the second name

Oh, I had done a bracket typo in my code. It is functional now.

The reason it outputted strange characters was that I forgot to terminate the string with a '\0'. And I had forgot to increment i in the last loop. It is getting late.

so what is needed in the code?

yeah i think i got it thanx

Well I did update my code, so just check it. It should be really simple to understand as well.

now i need to re-do the program to show i can use strcyp() n strncat(), all fun

Quote:

---

Originally Posted by peckitt99

now i need to re-do the program to show i can use strcyp() n strncat(), all fun

---

Why are you using c strings? Use std::string and all your problems will go away. :) With strcyp() and strncat() anyway. That's what it's there for.

I think he needs to do it with strncpy() and strncat() not with strings.