Remember, 0 based counting in C++... generally when iterating through a vector (say, named vec) you go from 0 to less than vec.length().
The problem with your program is infinite recursion.
randomizecard calls check, check calls randomize, randomize calls check, etc, forever. The allocated memory to store all the function calls (the stack) gets filled with those calls, and then the program crashes.
Also, instead of using parrallel arrays of int, you might want to learn structs. IE,
Code:
struct card {
int suit;
int case;
};
And then declare the list of cards like this.
apvector<card> cardList;
Finally, that sorting version is just not gonna cut it. As a fairly simple solution, I recommend making a "copied deck", in order, with 1 of each card. Then pick a random card out of the copy list (remove it from the copied list), and put it into the real one. Repeat until the copied list is empty, and you will have a random deck, somewhat efficiently (no checks needed to see if you have duplicated a card)
