Memory leak in copying one char to another

Code:

---

        do{
                for (int i = 0;i <= New->PathNumbers;i++, ActualPath++)
                {
                        if ( strcmp(";", New->Paths) == 0 )
                        {
                                ActualPath++;
                                i++;
                                break;
                        }
                        strcpy( &Path[i], &New->Paths[i] );
                }

---

Path is char*
New->Paths is char*

New->Paths has the string "Game" in it.

Whats wrong with this?

Well, if you have a memory leak, maybe you're not deleteing something.

sorry its not memory leak. I dont know what error is >.<

maybe its because it is always comparing New->Paths with ";". So if New-Paths == "game" then the loop will never do anything. Maybe this is what you want? strcmp() is overkill, just compare the characters.

Code:

---

        do{
                for (int i = 0;i <= New->PathNumbers;i++, ActualPath++)
                {
                        if ( New->Paths[i] == ';' )
                        {
                                ActualPath++;
                                i++;
                                break;
                        }
                        strcpy( &Path[i], &New->Paths[i] );
                }

---

> for (int i = 0;i <= New->PathNumbers;i++, ActualPath++)
Well your loop probably goes one past the end. More likely it should be:

Code:

---

                for (int i = 0;i < New->PathNumbers;i++, ActualPath++)

---

> strcpy( &Path[i], &New->Paths[i] );
And unless Path and New->Paths are arrays of char *, this statement doesn't make much sense. If you are just copying one char, at a time, you would use:

Code:

---

Path[i] = New->Paths[i];

---

But then you would need to terminate the char array at the end with of the for-loop with:

Code:

---

Path[i] = '\0';

---

I would guess that the code is intended to break up a list of paths (like "C:\windows;C:\windows\system") into Paths[]? Or maybe just count how many paths are in Path? Or am I completely off?

Yes, it is suposed to break a list of paths that is inside a file, the program is a self-updater that i am doing, it downloads the file with the version and the paths, so if the version is old, it download the paths, almost everything is working except that part.

I think the main problem is here:

Code:

---

strcpy( &Path[i], &New->Paths[i] );

---

ok, i tryed this:

Code:

---

Path[i] = New->Paths[i];

---

but it isnt still working, the debugger says that it is the problem

I think i got it, the problem is that "Path" and "New->Paths" were char*, i simply converted them to char*[30], it was causing a buffer overflow. Thank you for the help

It isn&#180;t still working as i want, when i have like "Dir1;Dir2;Dir3", even with the strcmp, it thinks that there is no ';', so it don&#180;t download only "Dir1", but download all the string.

Code:

---

typedef struct {
        float Version;
        int PathNumbers;
        char *Paths[60];
} sFile;

char *Path[60];

...

sFile *New;

ActualPath = 0;
        do{
                for (int i = 0;i < New->CharNumbers;i++, ActualPath++)
                {
                        if ( strcmp(";", (const char*)New->Paths) == 0 )
                        {
                                ActualPath++;
                                i++;
                                goto Download;
                        }
                        Path[i] = New->Paths[i];
                }

Download:
                if ( pDownloader->DownloadFile( (const char*)Path, (const char*)Path ) != 0 )
                          return ERROR;
        }while ( ActualPath < New->CharNumbers );

---

Quote:

---

Originally Posted by Scarvenger

It isn´t still working as i want, when i have like "Dir1;Dir2;Dir3", even with the strcmp, it thinks that there is no ';', so it don´t download only "Dir1", but download all the string.

---

Well, that's closer to stating your actual intent. Posting a small but complete and compileable snippet of code that demonstrates the problem will only get you an answer more quickly.

So... you're trying to parse a semicolon-delimited string?
Parsing a String into Tokens Using strcspn 2

Consider a break instead of the goto.