Newbie needs help plz

Hi
I am learning C++ for the first time; I use Dev C++ as i am 14 with no cash;
My programe has two if statments in and i use the cin.get(); thing to see what i have done. but after the second if statment, the dos window with my programe in it, is gone.
What do i do; can someone help me plz:(

Code:

---

#include <iostream>
using namespace std;

int main()
{
    char N;
    char Y;
    int uname;
    int pword;
   
    cout << "Welcome to the hackers gateway\n" <<endl;
    cout << "Do you have an account? Y or N (You need to say 'N' if you say"; <<endl;
    cin >> N;
 
    if (N == true);
      {
            cout << "Please type in your username\n";
            cin >> uname;
            cout << "And now your Password";
            cin >> pword << endl;
            cout << "You now have grated access to the hackers gateway\n";
            cout << "Well done!";
            cin.get();
        }
       
        cout << "To gain access to the hackers gateway";
        cout << "Please enter your username\n";
     
        cin >> uname;
       
        cout << "Please enter your Password";
       
        cin >> pword;
       
        cout << "Checking username and password....";
     
        if (uname AND pword == true);
          {
                  cout << "Hello and Wellcome to the hackers gateway"; <<endl;
                           
                               
          }
       
 
   
    cin.get();
    return 0;
}

---

You need to clear the input buffer, there are additional '\n' in the input stream from where you took in answers... look into cin.ignore();

I supposed you are writing in Windows. It is a console prograqm. As you are new, read the main site and forum FAQ before sending your question. You get your answer faster and better there.
add

Code:

---

cin.ignore(2);

---

before cin.get() .

thanks for the advice but still no luck

Worked it out!
Thanks!

>Worked it out!
Could you specify how you worked it out for people with the same question?

>> if (uname AND pword == true);

Do you need the ';' there, and the AND ... is that legal?

I would use:

Code:

---

if ( uname == true && pword == true )
{
        cout<< "You have successfully logged in!";
}

---

or something. However, it would work better if you had:

Code:

---

if ( uname == 42 && pword == 42 )
// you have set the username and the password
{
        cout<< "You have successfully logged in!";
}
else
{
        cout<< "That is not a valid username or password!";
}

---

You can set the numbers of the username and the password. It may be better to use a string for the username though.

I did this

Code:

---

  if (uname, pword == true);

---

worked fine =P
The semi colo after the parenthesis are uneeded as well

But, alas, im 16 and just started on this language as well...lol

There have been multiple discussions about using commas in if statements on this board... I will look for one later and link it but for now. How you have that written. It only evaluates pword == true... uname isn't even considered.

And in the OP code, it just evaluates uname to be non-zero/null

Take my word for it, it doesn't work as you wish. Try setting the password in the if statement to a number (999 for instance), and see what happens when you enter the wrong uname.

If you see my and Wraithan answer is the same, its because we send it at the same time. Unfortunately I only solved the problem that OP pointed I didn't mention whole the code.
Now it seems that OP problem is solved somehow, but I have question: How OP code can ever be compiled with that AND?
I remember a header with these defines:

Code:

---

#define AND &&
#define OR ||
...

---

But this header is not included in OPs code.

i hade alot of hard times geting the cin.get to work all the time so what i do is found a way to do it whitout that


i use

#include <cstdio> for use in system ........ and use

system("PAUSE");

hope it helps u if u dont got it=)

>>i hade alot of hard times geting the cin.get to work all the time so what i do is found a way to do it whitout that

If you couldn't make it work, its because you didn't read about it. Like now. If you just read other posts of this thread, you can make it work. And don't use that unsafe method.

>> #define AND &&
>> #define OR ||

Bad bad bad. That's like saying:

#define begin {
#define end }
blah blah

then you can do C or C++ in pascal. There's no need to do the above, && and || etc are fine IMO.

I didn't say they are good. AND that header came with my MSVS. AND you didn't answer my question.

He didn't, but you just did; MSVC.

So why asking something if you know the answer? wait... don't answer that. I know the answer

Did I say anything to you siacoshkc, saing that what I wrote was inteded towards you? I just said in general.



>> If you couldn't make it work, its because you didn't read about it. Like now. If you just read other posts of this thread, you can make it work. And don't use that unsafe method.

Also, I don't see any '?' for a question ;)

Quote:

---

Originally Posted by twomers

>> #define AND &&
>> #define OR ||

Bad bad bad. That's like saying:

#define begin {
#define end }
blah blah

then you can do C or C++ in pascal. There's no need to do the above, && and || etc are fine IMO.

---

Hardly. Not only are the quoted macros not "bad bad bad", they have a legitimate purpose. For example, what if you have a keyboard that doesn't support the requisite characters? C supports trigraphs for that reason, and C++ supports trigrahs and digrahs. In fact, C blesses the idea with the iso646.h header where the macros aren't much different, and C++ reserves actual keywords such as "and", "or", and "not", for the same purpose.

I didn't think of that. But to be honest, how many keyboards do you know which don't have &'s or |'s or whatever? I was always told that that kind of defining is 'bad bad bad' ...

How many keyboards do you know that don't have a # on them!!?

The #define is always good for a little obfuscation ;)

>But to be honest, how many keyboards do you know which don't have &'s or |'s or whatever?
None, but my experience with other keyboard layouts is very minimal.

>I was always told that that kind of defining is 'bad bad bad' ...
For the most part it is. If there weren't a standard solution, I would be hesitant to even talk about it unless asked a pointed question.

AND is legal if you #include <iso646.h>

>>AND is legal if you #include <iso646.h>
That header is the one I pointed to.

>>Also, I don't see any '?' for a question
This is my post:

Quote:

---

If you see my and Wraithan answer is the same, its because we send it at the same time. Unfortunately I only solved the problem that OP pointed I didn't mention whole the code.
Now it seems that OP problem is solved somehow, but I have question: How OP code can ever be compiled with that AND? <<<<THIS IS THE QUESTION MARK
I remember a header with these defines:

Code:

---

#define AND &&
#define OR ||

---

...But this header is not included in OPs code.

---

Review the thread.