Thread: nested for statements

I do not understand what happens when you have more than one for statements in the same block! I am messing around trying to make a program that reverses whatever you type in (I did this type of thing in class, last year for VB.net), but so far it is not working. I just reworked this before I posted it, I think it may work now:

Code:

#include<iostream>
#include <cstdlib>
using namespace std;
int main() {

char tar [10];
char rat [10];
int length, i, b;
length = strlen(tar);
cout << "Enter a string: ";
cin.get(tar);
for(i = 0; i < (length -1); i++){ 
	for(b = length; b >= 0; b--) 
		rat[i] = tar[b];
}
cout << "Your string reversed is: " << rat << i << ' ' <<b;
return 0;
}

And the error I get:

.\hypotenuse.cpp(11) : error C2664: 'std::basic_istream<_Elem,_Traits> &std::basic_istream<_Elem,_Traits>::get(_Elem &)' : cannot convert parameter 1 from 'char [10]' to 'char &'
with
[
_Elem=char,
_Traits=std::char_traits<char>
]

Don't mind the strange file name, I just reuse the same file for screwing around, to prevent a massive directory of useless programs. BTW I give my variables and that strange names because I'm to lazy to think up a descriptive name, nor do I care, after all, it's not like anyone else is going to use this (I'm not making an application or anything :P)

Please search the forum for "reverse a string," you will find many answers there.
> http://cboard.cprogramming.com/showt...reverse+string

The for statements should compile ok. The compile error you get is because you are calling get and passing in a character array. The get() function takes a single character. Perhaps you meant to use getline.

If you insist on using char arrays try this way

Code:

#include<iostream>
//#include <cstdlib>   // not needed here
#include <cstring>     // for strlen()

using namespace std;

int main() {

    char tar [10];
    char rat [10];
    int length, i;
    cout << "Enter a string: ";
    cin.get(tar, sizeof(tar) );   // this version of get needs the size of the buffer
    length = strlen(tar);         // must be called after input
    
    for(i = length-1; i >= 0; i--) // one loop should do
        rat[length-i-1] = tar[i];
    
    rat[length]='\0';              // needs a terminating zero
    
    cout << "Your string reversed is: " << rat << endl;
    return 0;
}

Kurt