FE2 beta version

This is a discussion on FE2 beta version within the C++ Programming forums, part of the General Programming Boards category; Im in the process of finishing my File Editor so have a look and tell me what you think of ...

  1. #1
    Registered User L_U_K_E's Avatar
    Join Date
    Apr 2006
    Posts
    106

    FE2 beta version

    Im in the process of finishing my File Editor so have a look and tell me what you think of it at the specified e-mail (see readme.txt).Thanx...
    Attached Files Attached Files

  2. #2
    Registered User
    Join Date
    Mar 2006
    Posts
    725
    #1 The indentation looks lousy, especially if your screen is a little narrow. What's wrong wiith just four spaces?
    #2 system("cls")... that's a bad idea.
    #3
    Code:
    31| cin >> selection;
    #4
    Code:
    44| if (!a_file.is_open())
    #5
    Code:
    90| else (a_file.good());
    #6 There is no way I get to read my file before I blindly edit it.
    #7 It's buggy, even in option 1 it will enter an infinite loop. See #4.
    #8 You don't have the permissions to create this folder on my computer.
    Code:
    ofstream c_file("D:\\LW_INFO\\LUF.txt");
    ...
    ...
    #99 I can't enter newlines into my file?! What is this?!
    ...
    ...
    Code:
    #include <stdio.h>
    
    void J(char*a){int f,i=0,c='1';for(;a[i]!='0';++i)if(i==81){
    puts(a);return;}for(;c<='9';++c){for(f=0;f<9;++f)if(a[i-i%27+i%9
    /3*3+f/3*9+f%3]==c||a[i%9+f*9]==c||a[i-i%9+f]==c)goto e;a[i]=c;J(a);a[i]
    ='0';e:;}}int main(int c,char**v){int t=0;if(c>1){for(;v[1][
    t];++t);if(t==81){J(v[1]);return 0;}}puts("sudoku [0-9]{81}");return 1;}

  3. #3
    Registered User whiteflags's Avatar
    Join Date
    Apr 2006
    Location
    United States
    Posts
    7,667
    A limit on the max file size is probably a fine idea too. You don't want to let user's write documents large enough to fill their hard drives.

  4. #4
    Registered User L_U_K_E's Avatar
    Join Date
    Apr 2006
    Posts
    106
    I want constructive critism not just nit picking!

  5. #5
    (?<!re)tired Mario F.'s Avatar
    Join Date
    May 2006
    Location
    Portugal
    Posts
    7,438
    I suggest you reexamine your evaluation of the criticism that was given to your code. It was good criticism.
    The programmer’s wife tells him: “Run to the store and pick up a loaf of bread. If they have eggs, get a dozen.”
    The programmer comes home with 12 loaves of bread.


    Originally Posted by brewbuck:
    Reimplementing a large system in another language to get a 25% performance boost is nonsense. It would be cheaper to just get a computer which is 25% faster.

  6. #6
    Registered User L_U_K_E's Avatar
    Join Date
    Apr 2006
    Posts
    106
    Some of it yes but the rest is just taking the mic. out of me.

  7. #7
    (?<!re)tired Mario F.'s Avatar
    Join Date
    May 2006
    Location
    Portugal
    Posts
    7,438
    If you can't take it, don't ask for it.

    Also, don't ask on a public forum for people to reply to your personal email. That is rude.
    The programmer’s wife tells him: “Run to the store and pick up a loaf of bread. If they have eggs, get a dozen.”
    The programmer comes home with 12 loaves of bread.


    Originally Posted by brewbuck:
    Reimplementing a large system in another language to get a 25% performance boost is nonsense. It would be cheaper to just get a computer which is 25% faster.

  8. #8
    Code Goddess Prelude's Avatar
    Join Date
    Sep 2001
    Posts
    9,796
    >I want constructive critism not just nit picking!
    My my, aren't we rude after asking volunteers for their opinions. How about you try being a little more grateful that someone bothered to point out places your code could be improved?
    My best code is written with the delete key.

  9. #9
    Registered User
    Join Date
    Mar 2006
    Posts
    725
    I feel like Simon Cowell right now


    Disclaimer:
    ***If you don't want us to criticize your code, please do not post it here. Thank you.***



    By the way, you didn't even read my above post in it's entireity. I put in a line of correct code, flagged as incorrect. Did you notice it?
    Last edited by jafet; 06-07-2006 at 09:28 PM.
    Code:
    #include <stdio.h>
    
    void J(char*a){int f,i=0,c='1';for(;a[i]!='0';++i)if(i==81){
    puts(a);return;}for(;c<='9';++c){for(f=0;f<9;++f)if(a[i-i%27+i%9
    /3*3+f/3*9+f%3]==c||a[i%9+f*9]==c||a[i-i%9+f]==c)goto e;a[i]=c;J(a);a[i]
    ='0';e:;}}int main(int c,char**v){int t=0;if(c>1){for(;v[1][
    t];++t);if(t==81){J(v[1]);return 0;}}puts("sudoku [0-9]{81}");return 1;}

  10. #10
    Registered User L_U_K_E's Avatar
    Join Date
    Apr 2006
    Posts
    106
    Sorry i took the wrong way but i am apoligizing for any hurt i may have caused anyone on the day!

    P.S I took a break and have only just started changing it but you'll be pleased to know that i changed the system("cls"); thingy!
    Last edited by L_U_K_E; 06-14-2006 at 02:13 PM.

  11. #11
    Registered User
    Join Date
    Mar 2006
    Posts
    725
    ... you didn't hurt us, it seemed like the other way round though
    Code:
    #include <stdio.h>
    
    void J(char*a){int f,i=0,c='1';for(;a[i]!='0';++i)if(i==81){
    puts(a);return;}for(;c<='9';++c){for(f=0;f<9;++f)if(a[i-i%27+i%9
    /3*3+f/3*9+f%3]==c||a[i%9+f*9]==c||a[i-i%9+f]==c)goto e;a[i]=c;J(a);a[i]
    ='0';e:;}}int main(int c,char**v){int t=0;if(c>1){for(;v[1][
    t];++t);if(t==81){J(v[1]);return 0;}}puts("sudoku [0-9]{81}");return 1;}

  12. #12
    Registered User L_U_K_E's Avatar
    Join Date
    Apr 2006
    Posts
    106
    Hah i often take things very personaly(lol)!

    By the way would you recommend i change:
    Code:
    ofstream b_file("D:\\LW_INFO\\LUF.txt");
    to
    Code:
    ofstream b_file("C:\\LW_INFO\\LUF.txt");
    As some people only have the C:\ drive and others may have other names for a second or even third hard drive or flash drive!SO tell me wat you think plz.Thanx.

    P.s I have also added a caution message about the folders i use in the prog and what they are used for and tell them not to use my prog if they dont like this idea!
    Last edited by L_U_K_E; 06-15-2006 at 09:29 AM.

  13. #13
    Registered User whiteflags's Avatar
    Join Date
    Apr 2006
    Location
    United States
    Posts
    7,667
    I'd recommend leaving the drive letter out period, unless you store a LW_INFO folder on a CD or something. Every OS that I know of understands relative filepaths.

  14. #14
    Registered User L_U_K_E's Avatar
    Join Date
    Apr 2006
    Posts
    106
    Thanx for your help i'll do that.

  15. #15
    Registered User L_U_K_E's Avatar
    Join Date
    Apr 2006
    Posts
    106
    Does anyone know why this piece of code doesn't work:
    Code:
    string ver;
    
    ofstream version_file("version.txt");
    getline(version_file,ver);
    cout<<ver;
    cin.get();

Page 1 of 2 12 LastLast
Popular pages Recent additions subscribe to a feed

Similar Threads

  1. Problem building Quake source
    By Silvercord in forum Game Programming
    Replies: 16
    Last Post: 07-11-2010, 09:13 AM
  2. No Version info tab in file properties?
    By cpjust in forum Windows Programming
    Replies: 2
    Last Post: 06-03-2008, 03:42 PM
  3. How to set File Version of VC++ 6 dll
    By mercury529 in forum Windows Programming
    Replies: 3
    Last Post: 12-08-2006, 01:49 PM
  4. Beta version compiled with -DWINVER=0x0500
    By wow in forum Windows Programming
    Replies: 3
    Last Post: 03-20-2006, 06:35 AM
  5. Released Beta version of my game today. Check it out.
    By DeSeis in forum Game Programming
    Replies: 1
    Last Post: 10-30-2002, 05:13 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21