Thread: Back to where I started...

Well, I thought I successfully learned how to erase a user given location in a vector...but since I switched over to Visual Studio 2005... I've been getting strange bugs...

My Code...

Code:

void Phonebook::Delete()
{
     if(vEntries.empty())
     {
            CLEARSCREEN;
            cout<<"\n\t\t\tCannot Delete...Entry list is empty!"<<endl;
            cout<<"\t\t\tBeing sent back to menu";
            Sleep(500);
            cout<<".";
            Sleep(500);
            cout<<".";
            Sleep(500);
            cout<<".";
            Sleep(500);
            CLEARSCREEN;
            return;
     }
     unsigned int ieDelete=0;

     cout<<"\n\t\t\tDelete which entry? ( 1 - "<<vEntries.size()<<" )";
     cout<<"\n\t\t\t->: ";
     cin>>ieDelete;
     if(ieDelete == 1)
     {
                 vEntries.erase(vEntries.begin());
     }
     else if(ieDelete == vEntries.size())
     {
                 vEntries.erase(vEntries.end());
     }
     else if(ieDelete < 1)
     {
          cout<<"\n\t\t\tChoice less than 1. Returning...";
          cin.get();
          CLEARSCREEN;
     }
     else if(ieDelete > vEntries.size())
     {
          cout<<"\n\t\t\tChoice higher than number of entries. Returning...";
          cin.get();
          CLEARSCREEN;
     }
     else
     {
          vEntries.erase(vEntries.begin() + (ieDelete-1));
     }
     CLEARSCREEN;
}

The code underlined is where the program has a fatal error... and the VS debugger pops up... I don't really get how to use the debugger yet... but I do know that I did have a problem with the same line before... but I fixed it in Dev C++ to the line you see above. But in VS it doesn't work right in the program...

Why would you want to be able to do such a thing to a phonebook.

condition two not right

Kuphryn

I must tell you that insert/delete operations in random vector positions are extremely computationally expensive.

So, what is another way to do this without the expense?

By the way, why are you clearing the screen in some of the conditionals if you're going to do it again in the end?

Well, whenever I open up the IDE, it's usually at night, so the code is probably sloppish...

Using a macro is bad, especially if you don't need one in the first place. This approach is preferred, and safer to boot:

Code:

Code:
void clearscreen()
{
    //insert clearscreen code here
}

I will keep this information for future reference...but for right now... lol ... its not really needed since it isn't a large program.

condition two not right

Care to give any details?

Why would you want to be able to do such a thing to a phonebook.

Well, this program started out at Phonebook1 then Phonebook2 etc. and now the final one is on Phonebook4. At first, I had a simple program that would output phonebook info to a .txt file in a formatted style. And now at Phonebook4, I learned about vectors, and this program was simply an excercise. And, in the program you can open a file... and it displays entries with 1-(vector size). So you can edit the phonebook info through the program... its just an addon to work with vectors...

**Can anybody give any advice on the underlined line?

Thanks for the comparison... but what does it mean?