Open last used file

I want to open the last used file i have my prog save the name of it in a text file and then read the name of it but it wont open it.Please could someone ave a look and tell me whats the matter:

Code:

---

ifstream a_file("D:\\Text LOG\\Txt_log.txt");
                  getline(cin,txt);
                  a_file.close();
                  ifstream b_file(txt.c_str(),ios::app);
                  getline(b_file,txtt);
                  cout<< txtt;
                  cout<<setfill('-')<<setw(80)<<("-")<<endl;
                  cout<<"Please enter some text to be output to this file: ";
                  getline(cin,x);
                  b_file>> x;
                  cin.get();
                  system ("cls");
                  break;

---

>>ifstream b_file(txt.c_str(),ios::app);

std::ios::app should be used for ofstreams when appending data to a file.

I tried that still doesn't work.

Tried what exactly?

Have you checked that the string you read from the first file is valid?

Quote:

---

ifstream a_file("D:\\Text LOG\\Txt_log.txt");
getline(cin,txt);
a_file.close();

---

Try changing getline(cin,txt); to getline(a_file,txt).
From the code you have right now, you are gathering input from the user through the cin stream and setting it to the string 'txt'.

First, you read from b_file, then you try to write to it. Neither ifstream or ofstream allows this. Use fstream instead.

Also, you do not do any error-checking to ensure the files have been opened correctly. You can use the methods is_open() and good() for this.

New problem! I am starting from scratch and i am now adding a check to see if the file exists and well you can read the code and find out everything else.Please tell me whats the matter:

Code:

---

out<<"Selection 1. Create a new file and input some text."<<endl;
                                              cout<<endl;
                                              cout<<setfill('-')<<setw(80)<<"-"<<endl;
                                              cout<<"Please enter the directory and filename:";
                                              getline(cin,filename);
                                              ofstream a_file(filename.c_str());
                                              if (!a_file.is_open())
                                              {
                                              cout<<"Please input some text that will be written to the file you specified."<<endl;
                                              cout<<">";
                                              getline(cin,text);
                                              cin.ignore();
                                              a_file<< text;
                                              a_file.close();
                                              ofstream b_file("D:\LW_INFO\LUF.txt");
                                              b_file<< filename;
                                              b_file.close();
                                              break;
                                              }
                                              else
                                              {
                                                    system("cls");
                                                    cout<<"Error: File already exists please specifiy a different name.";
                                                    cin.get();
                                                    system("cls");
                                                    break;
                                              }

---

If you really want an answer you should not let us guess what the problem is.
You're not telling what the problem is.
I'm not telling what's wrong with that line

Code:

---

ofstream b_file("D:\LW_INFO\LUF.txt");

---

Kurt

I changed that

Code:

---

ofstream b_file("D:\\LW_INFO\\LUF.txt");

---

and sorry bout that. My problem is that the user enters a new filename and my prog makes it and my problem happens when it gets to this...

Code:

---

if (!a_file.is_open())

---

I figuered out what it is. It makes the file THEN checks to see if the file exists and because they just made it it does. Please help(sorry i dont know how to word it,lol).

if you don't want to create a new file, you could at first open it for input. if that succeeds you could close it again and open it for output.
Kurt

No, i want to create a new file.

Quote:

---

Originally Posted by L_U_K_E

No, i want to create a new file.

---

Then I don't understand the problem.
EDIT: after thinking again.
Still the same procedure to check if it exists open it for input. if that succeeds exit with an error message. If it doesn't open it for output.
Kurt

the user makes a NEW FILE, but i want my prog to check if a file in the SAME directory has the SAME filename if it does it displays an error message asking them to change the name if the name is unique it makes the NEW FILE and outputs text to that file.

See my edit
Kurt

Please could you look at the code and make some changes to it then post it here 4 me to see what it is thats the matter??

Code:

---

{
  system("cls");
  cout<<"Selection 1. Create a new file and input some text."<<endl;
  cout<<endl;
  cout<<setfill('-')<<setw(80)<<"-"<<endl;
  cout<<"Please enter the directory and filename:";
  getline(cin,filename);
  ofstream a_file(filename.c_str());
  if ( !a_file.is_open() )
  {
      a_file.close();
      ifstream b_file(filename.c_str());
      cout<<"Please input some text that will be written to the file you specified."<<endl;
      cout<<">";
      getline(cin,text);
      cin.ignore();
      cout<< text;
      b_file.close();
      ofstream c_file("D:\\W_INFO\\LUF.txt");
      c_file<< filename;
      c_file.close();
      break;
  }
  else
  {
      system("cls");
      cout<<"Error: File already exists please specifiy a different name.";
      cin.get();
      system("cls");
      break;
  }
}

---

Headers:

Code:

---

#include <iostream>
#include <iomanip>
#include <fstream>
#include <string>
#include <windows.h>

---

Please if someone has the time look at this.

Opening the file as an ofstream isn't a good way to see if the file exists. Try ifstream.

Thanx for the tip.

Is there anything like ios::dontreplace(or something or nothing) that i can add somewhere so a same named file will not be deleted and then i can ask them to change the filename???

In pre-standard C++, there were ios::nocreate and ios::noreplace, however they don't exist in standard C++ anymore. You should just try opening the file and check yourself.