cin.get(); doesn't work even with cin.ignore();

I have just started to learn C++ and find it very fun. I know VB very well and know a bit of Pascal. I was writing my first program and this is all the code.

Code:

#include <iostream.h>
#include <stdlib.h>

using namespace std;

int main()
{
 cout<<"Hello\n";
cout<<"Please enter your name\n";

int name;

cin>> name;
cin.ignore();
cout<<"Now enter your age\n";

int age;

cin>> age;
cin.ignore();
cout<<"So you are called"<< name <<"and you are"<< age <<"years old\n";
cin.get();
}

The program is VERY simple and it is meant to ask for your name and age and then say it back to you. When it starts is says this:

Hello
Please enter your name

I enter my name and press enter but instead of asking me how old I am it ends the program. I searched the forum and found a thread that said to add cin.ignore(); so that the enter was ignored. I added this but the same thig happens. Debbuging finds nothing and I don't know how to fix it.
Any help would be goo
Thanks
Calum N

Several things. First you are trying to read a name (which is a string) into an int variable, which holds a number. That won't work. You have to #include <string> and make name a string variable. Second, you are using <iostream.h> which is outdated and non-standard. Switch to <iostream>. Finally, make sure that when you enter your name, you only enter one word. You can code your program so that it can take in multiple words, but that is more advanced so don't try to do that just yet.

Change

Code:

int name;

to

Code:

char name[256];

Thanks Dave and cunnus
I thought about iostream.h but Dev C++ had iostream.h as the default so I left it.
Thanks

Or do what davide said and:

Code:

#include <string>

string name

Do you know how to change what Dev-C++ shows you when you make a new source?

>> char name[256];
I would not do that. There's no reason to use a C style string here.

Use string instead.

I have changed the char thing into string.
I wondered what char did.
I don't know how to change what Dev C++ shows.
I have added if things so that it says whether you are a child or an adult
This is my updated code:

Code:

#include <iostream>
#include <stdlib.h>
#include <string>

using namespace std;

int main()
{
 cout<<"Hello\n";
cout<<"Please enter your first name and press enter\n";

string name;

cin>> name;
cin.ignore();
cout<<"Now enter your age\n";

int age;

cin>> age;
cin.ignore();
cout<<"So you are called "<< name <<" and you are "<< age <<" years old\n";
if ( age < 18) {
cout<<"You are a child!\n";
}
else if ( age > 19) {
cout<<"You are old\n";
}

cin.get();
return 0;
}

Originally Posted by calumn

I have changed the char thing into string.
I wondered what char did.

string is a C++ implementation of a char array with checks and boundaries and dynamic allocation and more all rolled into a nice transparent package.

Code:

if ( age < 18) {
cout<<"You are a child!\n";
}
else if ( age > 19) {
cout<<"You are old\n";
}

Well that's great, but what if, when asked, the user enters 18? Your program explodes. Fix that.

I have been working on it a bit and have been using more advanced ifs.

Code:

#include <iostream>
#include <stdlib.h>
#include <string>

using namespace std;

int main()
{
 cout<<"Hello\n";
cout<<"Please enter your first name and press enter\n";

string name;

cin>> name;
cin.ignore();
cout<<"Now enter your age\n";

int age;

cin>> age;
cin.ignore();
cout<<"So you are called "<< name <<" and you are "<< age <<" years old\n";
if ( age <= 12 and age > 0) {
cout<<"You are a child!\n";
}
else if ( age >= 13 and age <= 19) {
cout<<"You are a teenager\n";
}
else ( age > 19 and age <= 55) {
cout<<"You are an adult\n";
}
cin.get();
return 0;
}

I added another else but it doesn't seem to work
I will add another one saying over 55 after i get this to work but it doesn't seem to.

These are the errors:
c:\docume~1\neilson\mydocu~1\progra~2\c__~1\abouty ~1.cpp: In function `int main()':

c:\docume~1\neilson\mydocu~1\progra~2\c__~1\abouty ~1.cpp:23: parse error before `age'

c:\docume~1\neilson\mydocu~1\progra~2\c__~1\abouty ~1.cpp:25: confused by earlier errors, bailing out

Thanks for all your help

'and' isn't a C++ keyword... you need '&&'

I used to have the && but someone on msn told me to change it to and and it still worked.
I have changed the and back into && but it still gives me the exact same errors

Yay I fixed it:

Code:

{
 cout<<"Hello\n";
cout<<"Please enter your first name and press enter\n";

string name;

cin>> name;
cin.ignore();
cout<<"Now enter your age\n";

int age;

cin>> age;
cin.ignore();
cout<<"So you are called "<< name <<" and you are "<< age <<" years old\n";
if ( age <= 12 && age > 0) {
cout<<"You are a child!\n";
}
else if ( age >= 13 && age <= 19) {
cout<<"You are a teenager\n";
}
else if ( age > 19 && age <= 55) {
cout<<"You are an adult\n";
}
cin.get();
return 0;
}

I didn't have an if after the last else

>> 'and' isn't a C++ keyword... you need '&&'
Yes, it is. However, you should probably just use && since that is the more commonly used version.

It worked fine both ways
I have added it so it will always tell you your age like a child or teenager

Code:

#include <iostream>
#include <stdlib.h>
#include <string>

using namespace std;

int main()
{
 cout<<"Hello\n";
cout<<"Please enter your first name and press enter\n";

string name;

cin>> name;
cin.ignore();
cout<<"Now enter your age\n";

int age;

cin>> age;
cin.ignore();
cout<<"So you are called "<< name <<" and you are "<< age <<" years old\n";
if ( age <= 12 && age > 0) {
cout<<"You are a child!\n";
}
else if ( age >= 13 && age <= 19) {
cout<<"You are a teenager\n";
}
else if ( age > 19 && age <= 55) {
cout<<"You are an adult\n";
}
else if ( age > 55) {
cout<<"You are ancient\n";
}
else if ( age < 0) {
cout<<"You haven't been born yet\n";
}
cin.get();
return 0;
}