linkedlist pointer in class

Hi..

I have a sockclass that will be used in linkedlist separetly and also in another class (aclass) with its public members.

Code:

class sclass {
public:

int member;
int sth;
SOCKET s;

sclass *next;
}

Code:

class aclass : public sclass {
public:
char *p;

aclass *next;
}

Now what would be the best way to use *next pointer in both cases for linked list? To leave it as it is, or to put void *pointer in sclass and then point to sclass or aclass (if I will use aclass with public members of sclass), or just leave it as it is? I want my code to be professional, so Im asking for your advice..

What do you think would be the best way to do it?

Thanks for help
Kind regards

Don't put a next variable in aclass. Leave the next variable in sclass as an sclass*. This is what polymorphism is. When you add a new instance to the list, you use new sclass or new aclass, and you can save the result as an sclass*.

Just make sure your sclass has a virtual destructor, and that aclass can access the next value somehow (currently next is private). Creating a protected or public access method for the next item is probably the best way.

Whenever you want to use an aclass stored in the sclass*, you should be calling virtual methods in the base class that may or may not be overriden in the derived class (or calling non-virtual methods in sclass that call other virtual methods).

What exactly are you trying to do there? That's not how inheritance is used.. you have no public or protected interface for the base class, so your derived class will not have any access to its members

I want my code to be professional, so Im asking for your advice

I guess if you really want to it to look professional, you should use the STL linked list

Yes it was my mistake to put there private instead of public.

Originally Posted by Bench82

I guess if you really want to it to look professional, you should use the STL linked list

Why would STL linked list be more "professional?

Originally Posted by Daved

Just make sure your sclass has a virtual destructor

Why would I need a virtual destructor?

>> Why would I need a virtual destructor?
You need a virtual destructor in order to delete a derived class instance through a pointer to the base class. Since you would be storing all instances of aclass in the list through sclass pointers, the virtual destructor makes sure that when you clean them up they are destroyed properly.

>> Why would STL linked list be more "professional?
You shouldn't write from scratch code that is already available to you, especially when that code is part of the standard library that is extremely widely used and tested. If this isn't part of a learning or teaching exercise, you really should use standard containers instead of your own versions in C++.