limits.h problem!!

Hello,

A few weeks ago, I was asking about how to ignore a return after a cin (affected my getlines). Now, I switched compilers, and have a serious issue:

Code:

---

main.cpp(38) : warning C4003: not enough actual parameters for macro 'max'
main.cpp(38) : error C2589: '(' : illegal token on right side of '::'
main.cpp(38) : error C2143: syntax error : missing ')' before '::'
main.cpp(38) : error C2059: syntax error : ')'

---

Here is the code

Code:

---

37: cin >> option;
38: cin.ignore(numeric_limits<streamsize>::max(),'\n');
39: return option;

---

I'm using the 1998 version of Microsoft Visual C++ (if that helps at all).

There is a difference between using <limits>, <limits.h>, and <climits> -- which is it that you are using?

numeric_limits is in <limits>, and you should be using the std namespace for cin, numeric_limits and streamsize.

OK. heres the code (i used two limit files)

Code:

---

#include <iostream>
#include <fstream>
#include <math.h>
#include <time.h>
#include <iomanip>
#include <conio.h>
#include <string>
#include <cmath>
#include <cstdlib>
#include <stdlib.h>
#include <limits.h>
#include <limits>
#include <stdio.h>
#include <cctype>
#include <ctype.h>
#include <cstdlib>
#include <windows.h>

using namespace std;
bool checkFile(char filename[255])
{
    ifstream check (filename);
    if (check)
        return 0;
    else
        return 1;
}

class movie
{
        public:
        string title;
        string cat;
        string genre;
        movie *next;
};

int mainMenu()
{
    int option;
   
    cout << "+-----------------------------+" << endl;
    cout << "|          MAIN MENU          |" << endl;
    cout << "+-----------------------------+" << endl <<
            "| 1. Enter a new movie        |" << endl <<
            "| 2. Show media              |" << endl <<
            "| 3. Search media            |" << endl <<
            "| 4. Help                    |" << endl <<
            "| 5. About                    |" << endl <<
            "| 6. Quit                    |" << endl <<
            "+-----------------------------+" << endl <<
            "|    :ENTER AN OPTION:      |" << endl <<
            "+-----------------------------+" << endl;
    cin >> option;
    cin.ignore(numeric_limits<streamsize>::max(),'\n');
    return option;
}

void decide(int opt, movie *head)
{
    string title;
    string cat;
    string genre;
    int a = 0;
    ifstream check ("movie.ini");
    if (!check)
    {
                a = 1;
    }
    check.close();
   
    if (opt == 1)
    {
            cout << "Enter movie title: ";
            getline(cin,title,'\n');
            cout << "Enter movie category: ";
            getline(cin,cat,'\n');
            cout << "Enter movie genre: ";
            getline(cin,genre,'\n');
                        ofstream fOut ("movie.ini", ios::app);
            if (a != 1)
                fOut << endl;
               
            fOut << title << endl << cat << endl << genre;
            fOut.close();
    }
    if (opt == 2)
    {
          int cnt = 1;
          movie *list;
          list = head;
          system("cls");
          cout << setw(3) << left << "#" << setw(40) << left << "Movie" <<  setw(17) << left << "Category" <<  setw(17) << left << "Genre\n" << endl;
          while (list != NULL)
          {
                cout << setw(3) << left << cnt << setw(40) << left << list->title <<  setw(17) << left << list->cat <<  setw(17) << left << list->genre << endl;
                list = list->next;
                cnt++;
          }
    }
    if (opt == 4)
        cout << endl << endl << " -- Error opening help file!" << endl << endl;
    if (opt == 5)
        MessageBox(NULL,"(C) 1991-2006 Matt Nesterenko","About Media Manager",MB_OK);
    if (opt == 6)
        exit(0);
}

void menu(string menu, movie *head)
{
    int opt;
    if (menu == "main")
        opt = mainMenu();
    decide(opt, head);
}

void orderInsert(movie *head, movie *mNode)
{
    bool done = false;
    movie *prev;
    movie *curr;

    prev = curr = head;
   
    if (mNode->title <= head->title)
    {
          mNode->next=head;
          head=mNode;
    }
    else
    {
        while (curr != NULL && !done)
        {
              if (mNode->title <= curr->title)
              {
                    mNode->next = curr;
                    prev->next = mNode;
                    done = true;
              }
              prev = curr;
              curr = curr->next;
        }
        if (!done)
            prev->next = mNode;
    }
}

int main (int argc, char *argv[])
{
    movie *head;
    movie *mNode;
    movie *tail;
   
    char title[255], cat[255], genre[255];

    while (1)
    {
        ifstream input( "movie.ini");
       
        head = tail = NULL;
       
        if (input)
        {
            while (input.getline(title, 255, '\n') &&
                    input.getline(cat, 255, '\n') &&
                    input.getline(genre, 255, '\n'))
            {
                  mNode = new movie;
                  mNode->title = title;
                  mNode->cat = cat;
                  mNode->genre = genre;
                  mNode->next = NULL;
                  if (head == NULL)
                    head = mNode;
                  else
                  orderInsert(head,mNode);
            }
        }
        menu("main", head);
        cout << endl << endl;
        system("pause");
        system("cls");
    }
   
    system("pause");
    return 0;
}

---

first get rid of whatever geriatric version of visual stuidio you're using. It's out of date and frankly, crap. You can get a shiny new version of visual C++ 2005 for free from msdn.

Second, you're including <limits.h> and <limits>. Just use <limits>

Code:

---

#include <iostream>
#include <fstream>
#include <math.h>
#include <time.h>
#include <iomanip>
#include <conio.h>
#include <string>
#include <cmath>
#include <cstdlib>
#include <stdlib.h>
#include <limits.h>
#include <limits>
#include <stdio.h>
#include <cctype>
#include <ctype.h>
#include <cstdlib>
#include <windows.h>

---

How can you possibly need so many headers? I don't think I've ever seen so many includes all in one chunk.

First of all, drop all the .h headers (except possibly windows.h, but do you need that?) Then try to trim it down even more.

Actually, this is my includes.h file (for my c++ class) It has every include file that I can possibly use :D (except the limit problem)

when you say drop the .h parts. I need conio.h (or is it just plain conio) ?

Quote:

---

Originally Posted by ChaosEngine

first get rid of whatever geriatric version of visual stuidio you're using. It's out of date and frankly, crap. You can get a shiny new version of visual C++ 2005 for free from msdn.

Second, you're including <limits.h> and <limits>. Just use <limits>

---

Where can i get this "shiny new version?" (url)

another way to clear the stream is to use istream::seekg :

Code:

---

istream &
flush(istream & is)
{
        is.clear();
        is.seekg(ios::end);
        return is;
}

int
main()
{
        int i;
        do
        {
                flush(cin);
                cout << "enter an integer:" << endl;
                cin >> i;
        }
        while(cin.fail());
}

---

The problem is probably due to the use of a macro for max that is included in visual C++ (probably in windows.h).

Try adding #define NOMINMAX to the top of the file.

Quote:

---

Originally Posted by guitarist809

Actually, this is my includes.h file (for my c++ class) It has every include file that I can possibly use :D (except the limit problem)

when you say drop the .h parts. I need conio.h (or is it just plain conio) ?

---

I believe conio.h is included in windows.h or iostream, I could be wrong though...

Quote:

---

Originally Posted by Sebastiani

another way to clear the stream is to use istream::seekg :

Code:

---

istream &
flush(istream & is)
{
        is.clear();
        is.seekg(ios::end);
        return is;
}

int
main()
{
        int i;
        do
        {
                flush(cin);
                cout << "enter an integer:" << endl;
                cin >> i;
        }
        while(cin.fail());
}

---

---

Thanks for the code, but I dont understand it.



Also, I downloaded the Visual c++ Express from MSDN, I have 30 days to enter in a key I don't have AND it can't find the windows API (windows.h) or (windows)

Quote:

---

Originally Posted by bikr692002

I believe conio.h is included in windows.h or iostream, I could be wrong though...

---

I don't think it's included :(

really?
Oh wait, I'm thinking of stdlib.h or something like that

conio.h is a non-standard header for console manipulation (originally came with Borland compilers, I believe). at any rate, you can probably omit it since you aren't using any of its API.

>> Thanks for the code, but I dont understand it.

it simply clears the failure state of the stream and then seeks past whatever remains in its buffer.

Quote:

---

Originally Posted by guitarist809

Where can i get this "shiny new version?" (url)

---

msdn.microsoft.com

bookmark it. it has all the documentation for the C++ standard library and all the ms APIs (win32, mfc, atl, com, etc)

If you can find the free visual studio from there, give up programming.

>> bookmark it.

just don't bookmark the reference pages - microsoft is notorious for changing it's links. ;)

Change this

Code:

---

#include <iostream>
#include <fstream>
#include <math.h>
#include <time.h>
#include <iomanip>
#include <conio.h>
#include <string>
#include <cmath>
#include <cstdlib>
#include <stdlib.h>
#include <limits.h>
#include <limits>
#include <stdio.h>
#include <cctype>
#include <ctype.h>
#include <cstdlib>
#include <windows.h>

---

to

Code:

---

#include <iostream>
#include <fstream>
#include <iomanip>
#include <string>
#include <cstdlib>
#include <windows.h>

---

By the way, you tried to include <cstdlib> twice ;)


Also, your media manager doesn't allow for duplicate values, and will overwrite old values, but the user isn't told that!

All you ever use the windows API for is to display your name. So egoistic! Just display your credits section in the console and get rid of the include.

Additional credit: implement a "sort movies by ___" option :D


By the way, have you ever thought of using vectors, maps or lists?

> Actually, this is my includes.h file (for my c++ class) It has every include file that I can possibly use
While this seems a good idea in preventing things from being undefined, you will never learn where things are defined.

It also needlessly increases compilation times.
For example, on my system (excluding conio.h and windows.h), all those header files add up to a massive 800K of data before the compiler gets to the couple of K of source code you wrote. Adding windows.h will add another big chunk to that.

In any case, your include.h file is also hugely redundant by itself!

hmmm. oh well. I still dont' get why it worked in Dev C++, but now it doesn't work in a Professioal compiler.

~one of the many mysteries of microsoft~

I mentioned it earlier. Did you add the #define NOMINMAX?