Problem with file writing

Hi!

Code:

void test (int cod)
{
	fstream fa, fb;
	sSeg s;
	sCon c;
	long pos, pos1;
	
	
        pos = search(cod); //returns position of cod in teste1.bin file
        pos1= search_1(cod) //returns position of cod in teste2.bin file

        fa.open("test1.bin",ios::in|ios::out|ios::binary);
	
	if(!fa) {cerr<<"...";}
	
	
	fb.open("test2.bin",ios::in|ios::out|ios::binary);
	
	if(!fb)	{cerr<<"..";}
	
	
	fa.seekg(pos);
	fa.read((char *)&s, sizeof s);
	fa.seekp(pos);
	s.cod_seg = (-1);
	fa.write((char *)&s, sizeof s);
	
	
	fb.seekg(pos1);
	while(fb.read((char *)&c, sizeof c))
	{
		if(c.cod_seg == cod)
		{
			c.cod_ap = (-1);
			fb.write ((char *)&c, sizeof c);
		}
	}
	fa.close();
	fb.close();
}

Why can't i write the modifications( c.cod_ap=1) in the test2.bin file?
The function apparently works but when i list the test2.bin file the changes do not appear.

Any ideas?

Thanks

Code:

if(!fa) {cerr<<"...";}

This is not supposed to work, since fa is a fstream object it will never evaluate as false if i'm seeing things correctly. Even if it works, the advised way for checking if a file was correcly open in this case would be:

Code:

if (!fa.is_open()) {}

Originally Posted by LinuxCoder

Code:

if(!fa) {cerr<<"...";}

This is not supposed to work, since fa is a fstream object it will never evaluate as false if i'm seeing things correctly. Even if it works, the advised way for checking if a file was correcly open in this case would be:

Code:

if (!fa.is_open()) {}

This seems to work just fine. The function runs and changes the test1.bin file but doesn't change the test2.bin one.

This seems to work just fine. The function runs and changes the test1.bin file but doesn't change the test2.bin one.

I was not stating that the error was coming from there, simply stating that from my knowledge the mentioned piece of code is always going to evaluate to true even if the file is not open, that's all.

Now for other doubts about your code

• are you sure the values returned in the following code is valid?
  Code:

          pos = search(cod); //returns position of cod in teste1.bin file
          pos1= search_1(cod) //returns position of cod in teste2.bin file

• because if not the following calls could not work as expected
  Code:

  fb.seekg(pos1);
  ...
  fb.write ((char *)&c, sizeof c);

Other than that at this moment i don't see any reason for this not to work.

Hi!

I went throught the code, listing the values of the writed line of the test2.bin file and they are changed, but after the program closes (fa.close and fb.close) and i list the whole file the change is not there...

Try flushing the file streams before closing the file. Sorry if i'm not being much of a help but the code is too dependant on other stuff and as such i can't try it here.

Hhehehe.

It worked!!!Just inserted a flush in the right spot:

Code:

if(c.cod_seg == cod)
		{
			c.cod_ap = (-1);
			fb.write ((char *)&c, sizeof c);
                        fb.flush();
		}

Obrigado!!!

Really glad you made it mate

De nada