Class Templates and member functions

Hello,

I am trying to convert a regular class to a templated one.

I thought this would be simple enough, but now I my functions do not compile.

Where have I cone wrong?

Code:

template<class T>
class BankAccount
{ private:
    string CustFirst;
    string CustLast;
    int    CustAccNum;
    int    PinNum;
    T      AccBalance;

    public:

      void openAccount(int index);
};

~~ Program Body ~~

Code:

void BankAccount::openAccount(int index)
{ int AccNum = 100100 + index;

  system("cls");
  cout<< "********** Bank of Regis **********" << endl << endl;
  cout<< " New Account Number < " << AccNum << " > " << endl << endl;
  cout<< " Enter customers first name: " << endl;
  cout<< " ->: " ;
  cin>> CustFirst;
  cout<< " Enter customers last name: " << endl;
  cout<< " ->: " ;
  cin>> CustLast;
  cout<< " Enter customers PIN number: " << endl;
  cout<< " ->: " ;
  cin>> PinNum;
  cout<< " Enter inital deposite amount: " << endl;
  cout<< " ->: $";
  cin>> AccBalance;

  CustAccNum = AccNum;

  system("cls");
  cout<< "********** Bank of Regis **********" << endl << endl;
  cout<< "          Account Summary          " << endl;
  cout<< " Account# " << CustAccNum << endl;
  cout<< " Customer " << CustFirst << " " << CustLast << endl;
  cout<< " Balance  $" << AccBalance << endl << endl;
  cout<< "***********************************" << endl;
  system("pause");
 }

1 . why are you making this class a template? I see no design need for genericity here. Or are you just doing it for the practice?

2. what errors are you getting?

most likely you've put the method body in a cpp file and unless you're one of the 0 people on this board using the comeau compiler that won't work.

BTW as a general design principle, you should seperate model classes (i.e class that represent the appliction logic, i.e. a BankAccount class) from user interface code.

Code:

template<class T>
void BankAccount<T>::openAccount(int index)

You have to template the function as well.

I concede that templating the class is over kill, and a bit pointless, but I am trying to learn. Baby steps and all.

I tried telmplating the functions as suggested, but still got errors. Here is the code in it entirety. I commented out the templating because of the errors.

I would appreciate it if you could take a look at it.

I am using Dev C++

Code:

#include <iostream>
#include <iomanip>
#include <string>

using namespace std;

const int MaxSize = 100;     // Size of account database

//template<class T>
class BankAccount
{ private:
    string CustFirst;
    string CustLast;
    int    CustAccNum;
    int    PinNum;
//    T      AccBalance
    double AccBalance;

    public:
      void openAccount(int index);
      void accDeposite();
      void accWithdraw();
      void dsplyAcc();
      bool operator==(int find);

};

int main()
{  char selection = '\0';
   int  exit = 0;
   int  index = 0;
   int  find = '\0';;
//   BankAccount<double> AccountDatabae[MaxSize];
   BankAccount *AccountDatabase[MaxSize];

   do
    { system("cls");
      cout<< "********** Bank of Regis **********" << endl << endl;
      cout<< " 1. Open Account                   " << endl;
      cout<< " 2. Make a witdraw                 " << endl;
      cout<< " 3. Make a deposite                " << endl;
      cout<< " 4. View Account                   " << endl;
      cout<< " 5. Exit                           " << endl << endl;
      cout<< "***********************************" << endl;
      cout<< " ->: ";
      cin>> selection;

      switch(selection)
       { case '1':
             if(index<MaxSize)
              { //AccountDatabase[index] = new BankAccount<doubld>;
                AccountDatabase[index] = new BankAccount;
                AccountDatabase[index] -> openAccount(index);
                ++index;
              }
           break;

         case '2'://~~~~~~~~~~~~~~ Account Withdraw
           system("cls");
           cout<< "********** Bank of Regis **********" << endl << endl;
           cout<< " Enter your account number " << endl;
           cout<< " ->: ";
           cin>> find;
           for(int i=0; i<index; ++i)
             { if(*AccountDatabase[i]==find)
                 { AccountDatabase[i]-> accWithdraw();
                   break;
                 }
             }
           find = '\0';
           break;

         case '3'://~~~~~~~~~~~~~~ Account Deposite
           system("cls");
           cout<< "********** Bank of Regis **********" << endl << endl;
           cout<< " Enter your account number " << endl;
           cout<< " ->: ";
           cin>> find;
           for(int i=0; i<index; ++i)
             { if(*AccountDatabase[i]==find)
                 { AccountDatabase[i]-> accDeposite();
                   break;
                 }
             }
           find = '\0';
           break;

         case '4'://~~~~~~~~~~~~~~ Account View
           system("cls");
           cout<< "********** Bank of Regis **********" << endl << endl;
           cout<< " Enter your account number " << endl;
           cout<< " ->: ";
           cin>> find;
           for(int i=0; i<index; ++i)
             { if(*AccountDatabase[i]==find)
                 { AccountDatabase[i]-> dsplyAcc();
                   break;
                 }
             }
           find = '\0';
           break;

         case '5'://~~~~~~~~~~~~~~ Program Exit
            exit = 1;
           break;

         default:
            { cout<< " You have made and invalid selection " << endl << endl;
              system("pause");
            break;
            }
       }
    }while(exit != 1);

  return 0;
}

//template<class T>
void BankAccount::openAccount(int index)
{ int AccNum = 100100 + index;

  system("cls");
  cout<< "********** Bank of Regis **********" << endl << endl;
  cout<< " New Account Number < " << AccNum << " > " << endl << endl;
  cout<< " Enter customers first name: " << endl;
  cout<< " ->: " ;
  cin>> CustFirst;
  cout<< " Enter customers last name: " << endl;
  cout<< " ->: " ;
  cin>> CustLast;
  cout<< " Enter customers PIN number: " << endl;
  cout<< " ->: " ;
  cin>> PinNum;
  cout<< " Enter inital deposite amount: " << endl;
  cout<< " ->: $";
  cin>> AccBalance;

  CustAccNum = AccNum;

  system("cls");
  cout<< "********** Bank of Regis **********" << endl << endl;
  cout<< "          Account Summary          " << endl;
  cout<< " Account# " << CustAccNum << endl;
  cout<< " Customer " << CustFirst << " " << CustLast << endl;
  cout<< " Balance  $" << AccBalance << endl << endl;
  cout<< "***********************************" << endl;
  system("pause");
 }

//template<class T>
void BankAccount::accDeposite()
{ double deposite = 0.00;
  int temp = '\0';

  cout<< " Enter your PIN " << endl;
  cout<< " ->: ";
  cin>> temp;

  if(temp == PinNum)
    { do
       { system("cls");
         cout<< "********** Bank of Regis **********" << endl << endl;
         cout<< " Deposite Amount                   " << endl;
         cout<< " ->: $";
         cin>> deposite;
         if(deposite<0)
           { cout<< " Invalid deposite amount" << endl << endl;
             system("pause");
           }
          else
            { AccBalance+=deposite;
            }
        }while(deposite<0);
    }
    else
      { cout<< " Invalid PIN" << endl << endl;
        system("Pause");
      }
  temp = '\0';
}

//template<class T>
void BankAccount::accWithdraw()
{ double amt = 0.00;
  int temp = '\0';

  cout<< " Enter your PIN " << endl;
  cout<< " ->: ";
  cin>> temp;

  if(temp == PinNum)
    { do
       { system("cls");
         cout<< "********** Bank of Regis **********" << endl << endl;
         cout<< " Withdraw Amount " << endl;
         cout<< " ->: $";
         cin>> amt;
         if(amt>AccBalance)
           { cout<< " You can not withdraw more than" << endl;
             cout<< " $" << AccBalance << endl<< endl;
             system("pause");
           }
          else
            { AccBalance -= amt;
              amt = '\0';
            }
       }while(amt>AccBalance);
    }
    else
      { cout<< " Invalid PIN " << endl << endl;
        system("pause");
      }
  temp = '\0';
}

//template<class T>
void BankAccount::dsplyAcc()
{ int temp = '\0';

  cout<< " Enter your PIN " << endl;
  cout<< " ->: ";
  cin>> temp;

  if(temp == PinNum)
    {  system("cls");
       cout<< "********** Bank of Regis **********" << endl << endl;
       cout<< "          Account Summary          " << endl;
       cout<< " Account# " << CustAccNum << endl;
       cout<< " Customer " << CustFirst << " " << CustLast << endl;
       cout<< " Balance  $" << AccBalance << endl << endl;
       cout<< "***********************************" << endl;
       system("pause");
    }
    else
      { cout << " Invalid PIN " << endl << endl;
        system("pause");
      }
    temp = '\0';
}

//template<class T>
bool BankAccount::operator==(int find)
{ if(CustAccNum == find)
    { return(1);
    }
   else
     { return(0);
     }
}

When you template a class and it's objects, you have to address the template everytime you address it.

Code:

template<class Foo>  // Now the class is being templated
class DataContainer {
     public:
         DataContainer();
         void somefunc();
};

/* Now lets template the functions. Don't forget the class is templated, therefor the scope must also use the templalte */

DataContainer<Foo>::DataContainer() {}     /* Look at the template before the scope resolution operator */

void DataContainer<Foo>::somefunc() {}

Look at this code: http://www.cprogramming.com/tutorial...stackcode.html

This is properly using templates.

First off. Thank your for your help and patience.

I have updated my off lined functions with the syntax.

Code:

void BankAccount<T>::Function()
{~~Foo~~; }

I am lost when it comes to scope.

Do I need to add

Code:

BankAccount<T>::BankAccount() {}

in the the BankAccount Class or where?

I am sorry that I am slow on the uptake when it comes to this stuff.

Regards,

Rich

Yes. The reason being is when you call the scope, you're calling the class. Just like when you create an object.

Code:

BankAccount<int> obj1;

You have to give the template a value. In the case of the member functions (including the constructor, destructor, and copy constructor) your templates value is the template name. See how they do it in the link?

I am lost when it comes to scope.

Think of it this way: every member function you define outside a class has to identify which class it belongs to. You attempted to do that here:

void BankAccount::openAccount(int index)

However, there is no class called BankAccount. For there to be a class called BankAccount in your program, there would have to be a declaration like this somewhere in your code:

Code:

class BankAccount
{
};

However, there isn't. There is this statement:

Code:

template<class T>
class BankAccount
{
};

But those are not equivalent. Since you decided to template your class, there will only be classes like "BankAccount for type int" and "BankAccount for type float". There will never be a class called just "BankAccount", and you will never be able to declare an object like this:

Code:

BankAccount myAcc;

C++ has very strict syntax, and you must follow it exactly. To try and learn a new topic and just guess at the syntax usually won't be very successful. Furthermore, when you are learning a new topic, you shouldn't bury it 100's of lines of irrelevant code. The reasonable thing to do is to create a very simple test class to learn the syntax. The class should have only a couple of member variables, a constructor, and one function to display the member variables. That's it.