simple char array question

[yahn]

i'm receiving characters from a socket and loading them into a buffer, i'm trying to concatenate the buffer into another character array and its not working. can anyone help me?

            char buffer[1024];
            int rc = recv(engine::esock.sock, buffer, sizeof(buffer), 0);

            if (rc != -1)
            {
                unsigned int value = unpack(buffer[0], buffer[1]);
                buffer[rc + 1] = '\0';

                switch (value)
                {
                    case(0): // creation accept
                        strcat(engine::exbuff, buffer);
                        break;
                }

                return (static_cast<double>(value));
            } 

if i change strcat(engine::exbuff, buffer) to something like strcat(engine::exbuff, "hello world") it will do as it should. to me this doesn't really seem logical. i know there are charcters in the array since if i call another function i can return the value of rc, and that is 4. can anyone tell me what is wrong?

[loopshot]

why do you have a switch statment with only one case, just use a if statement, its faster

[yahn]

i know that, i have that because i'm going to add a lot more cases eventually and it doesn't bother me to have just one right now. does anyone know why i'm having the strcat() problem?

[Quantum1024]

recv will recieve how ever much data is available, you shouldn't assume that it is any amount. If you know you are waiting for a specific number of bytes then check the return value and keep looping untill you've recieved it all. You unpack the first two bytes but you may have only recieved one.

recv will return 0 if the connection is closed you should check for this as well as -1.

buffer[rc + 1] = '\0';

If recieve returned 4 (you recieved 4 bytes) then the bytes are numbered buffer[0] to buffer[3] so you are skipping a byte and adding a zero.

case(0): // creation accept 
                        strcat(engine::exbuff, buffer);

If the first byte of your buffer was zero then strcat will see that as the NULL terminator and won't copy anything.

[yahn]

oo.. well then how do i get around that, i tried doing my own while loop to copy it myself and that didn't work either. maybe i just did something wrong?

void stradd(char str1[], char str2[], int a)
{
	int i = 0;

	while (i < a)
	{
		str1[i] = str2[i];
		i++;
	}
}



			if ((rc != -1) && (rc != 0))
			{
				unsigned int value = unpack(buffer[0], buffer[1]);
				buffer[rc] = '\0';

				switch (value)
				{
					case(0): // creation accept
						stradd(engine::exbuff, buffer, rc);
						break;
				}

				return (static_cast<double>(value));
			}