eof

Hi everyone

I did a counter to get the value from a simple number file, because I used the counter to

Code:

while ( counter <=10)
{
value=getline( filename, line);
sum+=value;
counter++;
}

now the problem if I had less than 10 lins in that file. it will give result of ( abnormal termination).

so, I changed it with

Code:

ifstream indata(filename)
while ( !filename.eof)
{
value=getline( filename, line);
sum+=value;
counter++;
}

but this gives me as well termination error with my orignal file with 10 lines and same error with a file of less than 10 line.
I know eof is not a good thing to terminate and exit the loop. but what else could I use.

so anyidea with example to fix similar error.

thank you all

all the result are wrong

I'm not sure, but try this.

Code:

do{
    value = getline(filestreamobject, line);
    if(!filestreamobject)
        break;
    sum += value;
counter++;
}while(counter<10);

P.S.
Why are you using getline(a_string, int);
should'nt it be getline(streamobject, int); ???

I know eof is not a good thing to terminate and exit the loop. but what else could I use.

Standard practice is to use your read statement as a while conditional:

Code:

ifstream indata(filename);
string line;

while( getline(indata, line) )
{

}

getline() returns the stream object indata, which will evaluate to true or false when it is in a while conditional(i.e. in a boolean context). If any stream error occurs, indata will evaluate to false, and the while loop will end. EOF is considered a stream error. So, when you reach the end of the file and there is no more data, the while loop will end. There are also other stream errors that can occur, and they will also cause the while loop to end, preventing an infinite loop which will occur if you use eof() as your while conditional.