Weird Problem?

Ok, I wormed out all my errors, now all I have are warnings. For some reason my game isint finding the right tile.

I'm getting this error:

Code:

Microsoft Windows XP [Version 5.1.2600]
(C) Copyright 1985-2001 Microsoft Corp.

C:\Documents and Settings\User 1>CD C:\Borland\BCC55\BIN

C:\Borland\BCC55\Bin>BCC32 C:\MazeOfPain.cpp
Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
C:\MazeOfPain.cpp:
Warning W8068 C:\MOPEngine.h 162: Constant out of range in comparison in functio
n MoveRight()
Warning W8068 C:\MOPEngine.h 162: Constant out of range in comparison in functio
n MoveRight()
Turbo Incremental Link 5.00 Copyright (c) 1997, 2000 Borland

Now, my problem is that MoveRight() is pritty big. I isolated line 162:

Code:

Death(); //162

My line before that however:

Code:

if(Saveme[0] == Enemy1 || Saveme[0] == Enemy2 || Saveme[0] == Enemy3 || Saveme[0] == Enemy4)
  Death(); //162

I have them declared as they should be:

Code:

#define Enemy1 '@'
#define Enemy2 '&' 
#define Enemy3 '$'
#define Enemy4 '%'

Death function:

Code:

void Death() { //Not finished.
 clrscr();
 exit(0);
}

I dont get why its saying its out of range?? I have like 50 other constants that work just fine.

I've read that bcc32 has this problem, where gcc and others do not. I'm not recommending to do it yet, incase I just don't see where the problem is (most likely), but you could try disabling that warning. I think this page has that information: -w-rng.

Its a problem though, its not the warning, its actualy not even reading that the character's their. I'm doublechecking my co-ordinants to see if I messed up on something obvious.

Try making them constants and not macros? (I don't know if those macros are right either... I skipped C). Just for the hell of it I'd try wrapping your if statement more logically.

Code:

const char Enemy1 = '@';
const char Enemy2 = '&';
const char Enemy3 = '$';
const char Enemy4 = '%';

if((Saveme[0] == Enemy1) || (Saveme[0] == Enemy2) || (Saveme[0] == Enemy3) || (Saveme[0] == Enemy4))

Code:

#include <stdio.h>
#include <stdlib.h>
#include <conio.h>

#define Enemy1 '@'
#define Enemy2 '&' 
#define Enemy3 '$'
#define Enemy4 '%'

void Death(void)
{ //Not finished.
   clrscr();
   exit(0);
}

void foo(const char *Saveme)
{
   if ( Saveme[0] == Enemy1 || Saveme[0] == Enemy2 || 
        Saveme[0] == Enemy3 || Saveme[0] == Enemy4 )
   {
      Death();
   }
}

int main (void)
{
   char Saveme[] = "@";
   foo(Saveme);
   return 0;
}

Code:

	c:\progra~1\borland\bcc55\bin\bcc32 -P- -c @MAKE0000.@@@
Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
test.c:
	c:\progra~1\borland\bcc55\bin\Ilink32 @MAKE0002.@@@
Turbo Incremental Link 5.00 Copyright (c) 1997, 2000 Borland
	c:\progra~1\borland\bcc55\bin\bcc32 -P- -S @MAKE0001.@@@
Borland C++ 5.5.1 for Win32 Copyright (c) 1993, 2000 Borland
test.c:

Yeah I dont know why this code is giving me an error... Weirder still is its only complaining about two of them, but they're four comparisons...

if((Saveme[0] == Enemy1) || (Saveme[0] == Enemy2) || (Saveme[0] == Enemy3) || (Saveme[0] == Enemy4))

Saveme[0] is not a constant char. (And it cant be either)

Originally Posted by Blackroot

Saveme[0] is not a constant char. (And it cant be either)

So? In your code you are only comparing them.

I blame it on bcc obviously, who knows what whacked up rules it has. Maybe you cant use macros like that, or initialize an array like that. I never liked Borland, but it was the first program I used so I of course didn't understand it.

I fixed it by making a seperate function to return its value -,-. Ah well, it works now. Thank you for your help .

Perhaps you have other enemies in a nearer scope to the comparison, which have a larger range.