Outputting an Array, what's wrong...?

Ok this code outputs a name, but i cant figure out how to output the array in my function, from the main( ).

I know the code in my getInfo function works, and if i output the information inside the function it works, however how do i output it from inside the main( ).

Code:

#include <iostream>
#include <string>
#include <fstream>
using namespace std;

bool getInputFilename(char fname[])						
{
	ifstream fin;										

	cout << "Please enter the filename for input : ";
	cin >> fname;										
														
	fstream fs(fname, ios_base::in);
	
	if (!fs)
	{
		return false;
	}
	else
	{
		fin.close();
		return true;
	}
}
											

bool getOutputFilename(char fname[])					
{
	ofstream fout;

	cout << "Please enter the filename for output : ";
	cin >> fname;										
														
	fout.open(fname);									

	if (fout.fail())									
		return false;

	fout.close();
	return true;										
}

void getInfo(ifstream& fin, ofstream& fout, int marks[], char name[])
{
		fin.getline(name, 100, '\n');
		for(int j=0; j<12; j++)
		{
			fin >> marks[j];
		}
}


void main()
{
	ifstream fin;
	ofstream fout;

	char name[100];
	int marks[12];

	char IFname[20], OFname[20];


	while (!getInputFilename(IFname))
	{
		cout << "Invalid filename try again!\n\n";
	}

	while (!getOutputFilename(OFname))
	{
		cout << "Invalid filename try again!\n\n";
	}

	fout.open(OFname);
	fin.open(IFname);


		getInfo(fin, fout, marks, name);

		fout << name << endl;
		fout << marks << endl;
	

	fout.close();
	fin.close();
}

code in blue is where i try to output the marks[j], tried a few things to no avail.

You need a loop to output marks. ( same as for input ).

Code:

for(int j=0; j<12; j++)
	fout << marks[j] << endl;

K

> void main()
Read the FAQ - main returns int

Cheers, that works fine now, however i try to read in the data until end of file, and it doesnt work, just runs continuously... code in blue is what i added to try input data until end of file:

Code:

#include <iostream>
#include <string>
#include <fstream>
using namespace std;

bool getInputFilename(char fname[])						
{
	ifstream fin;										

	cout << "Please enter the filename for input : ";
	cin >> fname;										
														
	fstream fs(fname, ios_base::in);
	
	if (!fs)
	{
		return false;
	}
	else
	{
		fin.close();
		return true;
	}
}
											

bool getOutputFilename(char fname[])					
{
	ofstream fout;

	cout << "Please enter the filename for output : ";
	cin >> fname;										
														
	fout.open(fname);									

	if (fout.fail())									
		return false;

	fout.close();
	return true;										
}

void getInfo(ifstream& fin, int marks[], char name[])
{
	while(!fin.eof())
	{
		fin.getline(name, 100, '\n');
		for(int j=0; j<12; j++)
		{
			fin >> marks[j];
		}
	}
}


void main()
{
	ifstream fin;
	ofstream fout;

	char name[100];
	int marks[12];

	char IFname[20], OFname[20];


	while (!getInputFilename(IFname))
	{
		cout << "Invalid filename try again!\n\n";
	}

	while (!getOutputFilename(OFname))
	{
		cout << "Invalid filename try again!\n\n";
	}

	fout.open(OFname);
	fin.open(IFname);


		getInfo(fin, marks, name);

		fout << name << endl;
		
		for(int j=0; j<12; j++)
			fout << marks[j] << " ";
	

	fout.close();
	fin.close();
}

Don't use eof() to control the loop. Check the return value of the input method (whether it be getline or >> or both). When it goes in an infinite loop, it is usually because an error occurred. eof() never returns true if an error occurs.

So use the getline call as the control of the while loop: while(fin.getline(name, 100, '\n')). To be extra safe, check the return value when you are reading in the marks: if (!(fin >> marks[j])) // indicate an error.

BTW, you really should be using the C++ string class like you tried before. If you aren't going to use it, then you don't need to #include<string>.

> void main()
Strrrrrike 2!

Hey, Salem! Ever heard of Michael Kaplan?
Strike One
Strike Two