HELP! What's wrong with my code!

I have made this program which im really certain would work, it compiles with no errors, but runs continuously after getting the name of the output file.

The program takes a loads of names each with 12 numbers, gets the name using getline, and puts the numbers into an array.

Or that's what it is meant to do, what have i missed?

Code:

#include <iostream.h>
#include <string>
#include <fstream>
using namespace std;

bool getInputFilename(char fname[])						
{
	ifstream fin;										

	cout << "Please enter the filename for input : ";
	cin >> fname;										
														
	fin.open(fname, ios::nocreate);						
														
	if (!fin.is_open())
		return false;									 
	
	fin.close();
	return true;										
}


bool getOutputFilename(char fname[])					
{
	ofstream fout;

	cout << "Please enter the filename for output : ";
	cin >> fname;										
														
	fout.open(fname);									

	if (fout.fail())									
		return false;

	fout.close();
	return true;										
}

void getInput(ifstream& fin, char name[], int marks[])
{
	while(!fin.eof())
	{
		fin.get();
		fin.getline(name, 100, '\n');

		for(int j=0; j<12; j++)
		{
			fin >> marks[j];

		}

		fin.get(); 
	}
	
}



void main()
{
	ifstream fin;
	ofstream fout;

	char name[100];
	int marks[12];

	char IFname[20], OFname[20];


	while (!getInputFilename(IFname))
	{
		cout << "Invalid filename try again!\n\n";
	}

	while (!getOutputFilename(OFname))
	{
		cout << "Invalid filename try again!\n\n";
	}


	fout.open(OFname);
	fin.open(IFname);

	getInput(fin, name, marks);

        fout << name << endl;
        fout << marks << endl;

	
	fout.close();
	fin.close();
}

I threw it into Visual C++ and am getting a comple error that 'nocreate' is an undeclared identifier.

I am not sure if that will help you...

What I would try is using cin.get(); rather then using cin >> for getting the output file.

first things first, change your #include <iostream.h> to just #include <iostream>
next, you're getting an error probably because ios::nocreate is deprecated. not used anymore... it's not included in the library <fstream>.
check out this website, i just now found all this out by searching google: http://www.devx.com/tips/Tip/14544
the solution to what you're trying to do is simple: try to open the file in read-only mode. if it exists, close the file, and reopen it in write mode. i just copied that info from the site... if the file doesn't exist, you will not be able to open it in read-only mode. hope that helps!

Comiles yet continuously runs without ending, any ideas? Changed ios::nocreate like you stated.

Code:

#include <iostream>
#include <string>
#include <fstream>
using namespace std;

bool getInputFilename(char fname[])						
{
	ifstream fin;										

	cout << "Please enter the filename for input : ";
	cin >> fname;										
														
	fstream fs(fname, ios_base::in);
	
	if (!fs)
	{
		return false;
	}
	else
	{
		fin.close();
		return true;
	}
}
											

bool getOutputFilename(char fname[])					
{
	ofstream fout;

	cout << "Please enter the filename for output : ";
	cin >> fname;										
														
	fout.open(fname);									

	if (fout.fail())									
		return false;

	fout.close();
	return true;										
}

void getInput(ifstream& fin, char name[], int marks[])
{
	while(!fin.eof())
	{
		fin.get();
		fin.getline(name, 100, '\n');

		for(int j=0; j<12; j++)
		{
			fin >> marks[j];

		}

		fin.get(); 
	}
	
}



void main()
{
	ifstream fin;
	ofstream fout;

	char name[100];
	int marks[12];

	char IFname[20], OFname[20];


	while (!getInputFilename(IFname))
	{
		cout << "Invalid filename try again!\n\n";
	}

	while (!getOutputFilename(OFname))
	{
		cout << "Invalid filename try again!\n\n";
	}


	fout.open(OFname);
	fin.open(IFname);

	getInput(fin, name, marks);

        fout << name << endl;
        fout << marks << endl;

	
	fout.close();
	fin.close();
}

Chnge void main to int main

And see my post in your other thread about using eof() to control the loop.