STL related

This is a discussion on STL related within the C++ Programming forums, part of the General Programming Boards category; i am trying to use some of the algorithms in STL , and i have problems making my class "STL-compliant". ...

  1. #1
    Registered User
    Join Date
    Dec 2005
    Posts
    7

    STL related

    i am trying to use some of the algorithms in STL , and i have problems making my class "STL-compliant". I defined the proper operators, but i get compile errors i am not able to get past when i try to use sort. any ideas about what i am making wrong?

    Code:
    #include <algorithm>
    #include <vector.h>
    class IPoint
    {
    public :
    	float energ,x,y,z;
    	char nume[10];
    	
    	IPoint();   //no arg constructor
    	IPoint(const IPoint& m);  //copy constructor
    	const IPoint& operator=(const IPoint& right); //copy assignment operator
    	IPoint(float, float, float, float, char*); 
    	void Set(float, float, float, float, char*);
    	bool operator==( const IPoint& right) ; //== operator
    	bool operator!=(const IPoint& right) ; //!= operator
    	bool operator<(const IPoint& right) ;  //< operator
    	bool operator>(const IPoint& right) ;  //> operator
    	
    };
    
    
    IPoint::IPoint()
    { 
    Set(0,0,0,0,"defname");
    }
    
    IPoint::IPoint(float en,float vx,float vy, float vz,char* a)
    {
    	Set(en,vx,vy,vz,a);
    }
    
    void IPoint::Set(float en,float vx,float vy, float vz,char *vnume)
    {
    	energ=en;
    	x=vx;
    	y=vy;
    	z=vz;
    	strcpy(nume,vnume);
    }
    
    IPoint::IPoint(const IPoint& p ){
      energ=p.energ;
    	x=p.x;
    	y=p.y;
    	z=p.z;
    	strcpy(nume,p.nume);
    };
    
    const IPoint& IPoint::operator=(const IPoint& right){
      if(this!=&right){
      IPoint(right);
      };
    return *this;
    };
    
    bool IPoint::operator==( const IPoint& right){
      return (energ == right.energ);
    };
    
    bool IPoint::operator!=(const IPoint& right){
      return (energ!=right.energ);
    
    };
    
    bool IPoint::operator>(const IPoint& right){
      return (energ>right.energ);
    
    };
    bool IPoint::operator<(const IPoint& right){
      return (energ<right.energ);
    
    };
    
    
    
    int main(){
     vector<IPoint> vect;
    
     IPoint pct;
     pct.Set(100,0,0,0,"1");
     vect.push_back(pct);
     pct.Set(150,0,0,0,"1");
     vect.push_back(pct);
     pct.Set(250,0,0,0,"2");
     vect.push_back(pct);
    
     if (vect[0]<vect[1]) cout<<"0<1"<<endl;
     sort(vect.begin(),vect.end()); 
    };

  2. #2
    Yes, my avatar is stolen anonytmouse's Avatar
    Join Date
    Dec 2002
    Posts
    2,544
    Change:
    Code:
    #include <algorithm>
    #include <vector.h>
    to:
    Code:
    #include <algorithm>
    #include <vector>
    #include <iostream>
    using namespace std;
    If that doesn't work, post the errors you are getting and the compiler you are using.

  3. #3
    Registered User
    Join Date
    Dec 2005
    Posts
    7
    thank you for looking at it. tried what you said and it does not work.

    here are the errors and the compiler:

    Code:
    []$ g++ test2.cpp
    /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/../../../../include/c++/3.4.3/bits/stl_algo.h: In function `const _Tp& std::__median(const _Tp&, const _Tp&, const _Tp&) [with _Tp = IPoint]':
    /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/../../../../include/c++/3.4.3/bits/stl_algo.h:2482:   instantiated from `void std::__introsort_loop(_RandomAccessIterator, _RandomAccessIterator, _Size) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<IPoint*, std::vector<IPoint, std::allocator<IPoint> > >, _Size =int]'
    /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/../../../../include/c++/3.4.3/bits/stl_algo.h:2553:   instantiated from `void std::sort(_RandomAccessIterator, _RandomAccessIterator) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<IPoint*, std::vector<IPoint, std::allocator<IPoint> > >]'
    test2.cpp:90:   instantiated from here
    /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/../../../../include/c++/3.4.3/bits/stl_algo.h:90: error: passing `const IPoint' as `this' argument of `bool IPoint::operator<(const IPoint&)' discards qualifiers
    /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/../../../../include/c++/3.4.3/bits/stl_algo.h:91: error: passing `const IPoint' as `this' argument of `bool IPoint::operator<(const IPoint&)' discards qualifiers
    /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/../../../../include/c++/3.4.3/bits/stl_algo.h:93: error: passing `const IPoint' as `this' argument of `bool IPoint::operator<(const IPoint&)' discards qualifiers
    /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/../../../../include/c++/3.4.3/bits/stl_algo.h:97: error: passing `const IPoint' as `this' argument of `bool IPoint::operator<(const IPoint&)' discards qualifiers
    /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/../../../../include/c++/3.4.3/bits/stl_algo.h:99: error: passing `const IPoint' as `this' argument of `bool IPoint::operator<(const IPoint&)' discards qualifiers
    []$ g++ -v
    Reading specs from /usr/lib/gcc/i586-mandrake-linux-gnu/3.4.3/specs
    Configured with: ../configure --prefix=/usr --libexecdir=/usr/lib --with-slibdir=/lib --mandir=/usr/share/man --infodir=/usr/share/info --enable-shared --enable-threads=posix --disable-checking --enable-long-long --enable-__cxa_atexit --enable-clocale=gnu --disable-libunwind-exceptions --enable-languages=c,c++,ada,f77,objc,java --host=i586-mandrake-linux-gnu --with-system-zlib
    Thread model: posix
    gcc version 3.4.3 (Mandrakelinux 10.2 3.4.3-7mdk)

  4. #4
    Registered User
    Join Date
    Nov 2005
    Posts
    52
    From the text of the error, I think what's happening (though you'd have to consult the implementation of std::sort to be sure!) is that the algorithm is calling your operator< in a way you didn't anticipate, causing the error. Try defining operator< as a free (friend) function:
    Code:
    class IPoint
    {
      //All the rest as before, except operator<
      friend operator<(const IPoint&, const IPoint&);
    };
    
    bool operator<(const IPoint& lhs, const IPoint& rhs){
      return (lhs.energ < rhs.energ);
    }
    Also, a couple of side notes:
    1. If you implement != and > as negation of == and <, you'll save on duplicate code.
    2. You really should make your data members private.
    3. PLEASE, if there's no other reason forcing you not to, make nume a std::string instead of a char[].

  5. #5
    Yes, my avatar is stolen anonytmouse's Avatar
    Join Date
    Dec 2002
    Posts
    2,544
    It seems that the g++ implementation of std::sort makes the objects const before passing them to the < operator. This causes a conflict because your operator overload functions are not marked as const. To fix this, you will have to mark these functions const. A const member function is a member function that does not change its object.
    Code:
    #include <algorithm>
    #include <vector>
    #include <iostream>
    using namespace std;
    
    class IPoint
    {
    public :
    	float energ,x,y,z;
    	char nume[10];
    	
    	IPoint();   //no arg constructor
    	IPoint(const IPoint& m);  //copy constructor
    	const IPoint& operator=(const IPoint& right); //copy assignment operator
    	IPoint(float, float, float, float, char*); 
    	void Set(float, float, float, float, char*);
    	bool operator==( const IPoint& right) const; //== operator
    	bool operator!=(const IPoint& right) const; //!= operator
    	bool operator<(const IPoint& right) const;  //< operator
    	bool operator>(const IPoint& right) const;  //> operator
    	
    };
    
    
    IPoint::IPoint()
    { 
    Set(0,0,0,0,"defname");
    }
    
    IPoint::IPoint(float en,float vx,float vy, float vz,char* a)
    {
    	Set(en,vx,vy,vz,a);
    }
    
    void IPoint::Set(float en,float vx,float vy, float vz,char *vnume)
    {
    	energ=en;
    	x=vx;
    	y=vy;
    	z=vz;
    	strcpy(nume,vnume);
    }
    
    IPoint::IPoint(const IPoint& p ){
      energ=p.energ;
    	x=p.x;
    	y=p.y;
    	z=p.z;
    	strcpy(nume,p.nume);
    };
    
    const IPoint& IPoint::operator=(const IPoint& right){
      if(this!=&right){
      IPoint(right);
      };
    return *this;
    };
    
    bool IPoint::operator==( const IPoint& right) const{
      return (energ == right.energ);
    };
    
    bool IPoint::operator!=(const IPoint& right) const{
      return (energ!=right.energ);
    
    };
    
    bool IPoint::operator>(const IPoint& right) const{
      return (energ>right.energ);
    
    };
    bool IPoint::operator<(const IPoint& right) const{
      return (energ<right.energ);
    
    };

  6. #6
    Registered User
    Join Date
    Dec 2005
    Posts
    7
    i added the const to the operator overloaded functions and i finally got it to compile and run without errors.
    the problem is that the sort algorithm is not sorting the vector. my blind guess is that it might have something to do with the way i defined the constructors, that makes it impossible for the algorithm to switch two elements in the vector, but i completlly get lost when i am trying to debug inside "sort()".

  7. #7
    Yes, my avatar is stolen anonytmouse's Avatar
    Join Date
    Dec 2002
    Posts
    2,544
    Code:
    const IPoint& IPoint::operator=(const IPoint& right){
      if(this!=&right){
      IPoint(right);
      };
    return *this;
    };
    Your assigment operator is wrong. The line IPoint(right); simply creates a temporary IPoint object that is destroyed at the end of the statement. The code in your assignment operator should be similar to the code in your copy constructor. Here is an article.

  8. #8
    Registered User
    Join Date
    Dec 2005
    Posts
    7
    thank you very much for your help. it works now.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. C Formatting Using STL
    By ChadJohnson in forum C++ Programming
    Replies: 4
    Last Post: 11-18-2004, 04:52 PM
  2. im extreamly new help
    By rigo305 in forum C++ Programming
    Replies: 27
    Last Post: 04-23-2004, 11:22 PM
  3. STL or no STL
    By codec in forum C++ Programming
    Replies: 7
    Last Post: 04-12-2004, 02:36 PM
  4. Prime Number Generator... Help !?!!
    By Halo in forum C++ Programming
    Replies: 9
    Last Post: 10-20-2003, 07:26 PM
  5. include question
    By Wanted420 in forum C++ Programming
    Replies: 8
    Last Post: 10-17-2003, 03:49 AM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21