*shakes head* I need help

I'm currently working on a code to use imbedded if functions....
Its kicking my butt now, I lost about an hours worth of tweaking and now I'm... bumbling around like an idiot. Let me show you my errors and then We'll move on to my mess of a code.

In function 'Int main()'
expected ) before ! token --- line 160

[ C:\WINDOWS\Desktop\MUD\Dev-Cpp\G__~1.EXE If Challenge Help.o: No such file or directory.

C:\WINDOWS\Desktop\MUD\Dev-Cpp\G__~1.EXE no input files ] x2

Code:

---


#include <iostream>
 
using namespace std;
 
int main()
{
        for (int i = 0; i < 10; i++ )
        {
                int books;
                int input;
           
                cout<<"How many books have you read this last year?\n";
                cin>> books;
                cin.ignore();
                cout<<"You read "<< books <<"?\n";
 
                if ( books >= 90 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" a : 42' Tv Set!\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
                  if ( input == 'a' )
                  {
                        cout<<"Wow! Congratulations! You've won a 42' Tv Set!\n";
                        cin.get();
                        }
                  else if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                  else if ( input != 'a' || input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                else if ( books >= 75 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;\
            if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }     
                      cin.get(); 
                }
                else if ( books >= 50 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                      cin.get(); 
                }
                else if ( books >= 25 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.ignore();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                      cin.get(); 
                }
                else if ( books >= 1 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                      cin.get(); 
                }
                else if ( books == 0 )
                {
            cout<<"Listed below are your options:\n";
                        cout<<"Sorry, Start reading and maybe you'll win something next time!\n";
                }
        else if ( books != 0 && books !> 0 || books < 0 )
        {
            cout<<"Error. Please enter a positive integer.\n";
                    cin.get();
        }
 
        cin.get();

---

I know its a mess, Ever since I lost my work, My brain has been .. jumbled and I can't figure out how I had it worked out

Your error is here:

Code:

---

else if ( books != 0 && books !> 0 || books < 0 )

---

There is no such thing as a "not greater than" operator. :p

Well there is, but it's called a "less than or equal to" operator ( <= )

Update:
1. When I enter a b c d or e to choose my prize, it gives me... I think its the error message, but cin.get(); isn't registering properly or something because its not pausing for me to see it, or looping... but I'm going to try to switch to a while loop assuming it works out

here it is currently:

Code:

---

#include <iostream>
 
using namespace std;
 
int main()
{
        for (int i = 0; i < 10; i++ )
        {
                int books;
                int input;
           
                cout<<"How many books have you read this last year?\n";
                cin>> books;
                cin.ignore();
                cout<<"You read "<< books <<"?\n";
 
                if ( books >= 90 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" a : 42' Tv Set!\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
                  if ( input == 'a' )
                  {
                        cout<<"Wow! Congratulations! You've won a 42' Tv Set!\n";
                        cin.get();
                        }
                  else if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                  else if ( input != 'a' || input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cin.get();
    }
                else if ( books >= 75 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore ();
            if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
        cin.get();   
                }
                else if ( books >= 50 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cin.get();
                }
                else if ( books >= 25 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.ignore();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cin.get();
                }
                else if ( books >= 1 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                }
                else if ( books == 0 )
                {
            cout<<"Listed below are your options:\n";
                        cout<<"Sorry, Start reading and maybe you'll win something next time!\n";
                }
        else if ( books != 0 && books != 1-320000 || books < 0 )
        {
            cout<<"Error. Please enter a positive integer.\n";
                    cin.get();
}
 cin.get();
 return 0;
}
}

---

Thanks

You might also want to look into the use of a switch statement: it will obviate the need for long if conditionals like this:

if ( input != 'b' || input != 'c' || input != 'd' || input != 'e' )

Its not the lesson I'm on, It was a challenge to do it using the if statement, imbeding if statements inside if statements... I was trying to avoid getting ahead of myself and going into switch statements

There are other ways to shorten that code though. Try to remove things that you appear to do in every condition and do those globally outside of the statements.

I don't want to shorten it, Just make it work *kicks at the prog*

If you haven't taken a break on it since I assigned it to you, then you should do so now. :)

Sometimes time away from code helps you gather your thoughts and write better when you get back to it.

ok, good Idea, I'll write a few easy progs and build on things with stuff I know that works... Get my mind off of it.... For some reason I just know that I'm missing something blatantly obvious... or some miniscule detail that shouldn't have been there in the first place... I implemented a while loop...

Ok, first off, your if statements.

You have if greater than 90, and your second if is greater than 75
Well, 91 is greater than both 75 and 90 (and every other if) so it eval’s true for everything.
Range it

If >= 90

If >=75 && < 90

If >= 50 && < 75

Ect…

Code:

---

else if ( books != 0 && books != 1-320000 || books < 0 )

---

Ok, that might make sense to you. But what are you trying to do, run something when it is less than but not 0.

If (books < 0)
That is it man!

Now, onto the problem in your code!
Formatting and be consistent!
And remember how I told you I like to put my {} on lines all by them selves?
This is your problem that is keeping you from compiling (the others will just give you errors in your output). You are missing one simple little “}”.

With consistence coding format, putting {} on separate lines (and indenting the closing the same as the opening) it would be really easy to find, how you have it, it is not so easy.

You never close your first if loop. Which means when you think you are closing your for-loop you are actually just closing your first if!

Quote:

---

Originally Posted by Enahs

If >= 90

If >=75 && < 90

If >= 50 && < 75

---

Think about your logic here.

If a statement doesn't evaluate true on the if >= 90 statement, and it evaluates true on the >= 75 statement, then that would automatically assume that it's less than 90. Two bounds are a waste unless for readability purposes.

First off, The definition of else is if the previous if isn't true, therefore the && declaration thingies isn't neccesary. Next I was trying to make it if they user input something other than a number, they would still receive the message. Lastly.. Ya I do need to work on my coding.. Let me throw up my current code though instead of that.. I changed loop types
here it is:

Code:

---

#include <iostream>
 
using namespace std;
 
int main()
{
                int books;
                int input;
                int i;
                while ( i != 32000 )
                {
                  cout<< i <<endl;
                  i++;
                 
           
                cout<<"How many books have you read this last year?\n";
                cin>> books;
                cin.ignore();
                cout<<"You read "<< books <<"?\n";
 
                if ( books >= 90 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" a : 42' Tv Set!\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
                  if ( input == 'a' )
                  {
                        cout<<"Wow! Congratulations! You've won a 42' Tv Set!\n";
                        cin.get();
                        }
                  else if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                  else if ( input != 'a' || input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cin.get();
    }
                else if ( books >= 75 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore ();
            if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
        cin.get();   
                }
                else if ( books >= 50 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cin.get();
                }
                else if ( books >= 25 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.ignore();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cin.get();
                }
                else if ( books >= 1 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                }
                else if ( books == 0 )
                {
            cout<<"Listed below are your options:\n";
                        cout<<"Sorry, Start reading and maybe you'll win something next time!\n";
                }
        else if ( books != 0 && books != 1-320000 || books < 0 )
        {
            cout<<"Error. Please enter a positive integer.\n";
                    cin.get();
}
            cout<<"Input any key to continue, type quit to close out.\n";
            cin>> i;
            cin.ignore ();
            cin.get();
            return 0;
}
}

---

Ok, let me know where my logic is wrong, thanks:)

Because 91 is greater than both 90 and 75

Code:

---

#include<iostream>


using namespace std;

int main()
{
 
    const int test = 10;


        if ( test >= 5) cout << "Greater than 5\n";

        if (test >= 1 ) cout << "Greater than 1\n";


return 0;
}

---

Will output both Greater than 5 and Greater than 1 because both are true.

*edit*
Though, if I bothered to learn to read in 1st grade I would have noticed he had else-if statements and not just if statements....so anyway....

Why don't you look at his code again. He uses else if.

*edit* Just read your *edit* so ummm... well this is ackward. :p

Quote:

---

Ok, let me know where my logic is wrong, thanks

---

Your return 0; is in your loop and not at the end of main.
Also, you use i in your while loop, but you do not initialize it to anything. So the first time around ‘i’ has nothing in it or garbage.
Try int i = 0;

*Edit*, also you are going to have trouble because you are inputing char's into a type of int.
Make that

Code:

---

char input;

---

And except for that list else-if wacky statement it should work.

Code:

---

if ( input == 'a' ) {
}

---

That means if input is the same as a(they typed in a) then do the following right?

You should define input as a char though not an int. There is no implicit cast in those if statements so reading in a character to an integer fails the stream.

define it as a char.. ok tutorials here I come, need to find out how to do that.. assumedly char input;

Yes.

WAHOO! Declaring it a char made all the difference... it also makes it possible for me to.. wow that helps alot, thanks!

Help with my while loop please, I obviously don't understand it.. I can't get it to start the program over for the life of me. at least not without making it just like the for loop in the sense that it goes to a certain number and then stops

Code:

---

#include <iostream>
 
using namespace std;
 
int main()
{
                int books;
                char input;
                char book;
                int i = 0;
                while ( i != 200 )
                {
                  cout<< i <<endl;
                  i++;
                 
           
                cout<<"How many books have you read this last year?\n";
                cin>> books || book;
                cin.ignore();
                cout<<"You read "<< books <<"?\n";
 
                if ( books >= 90 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" a : 42' Tv Set!\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
                  if ( input == 'a' )
                  {
                        cout<<"Wow! Congratulations! You've won a 42' Tv Set!\n";
                        cin.get();
                        }
                  else if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                  else if ( input != 'a' || input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";           
                }
                cout<<"Hint: Press enter\n";
                cin.get();
    }
                else if ( books >= 75 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore ();
            if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
        cout<<"Hint: Press enter\n";
        cin.get();   
                }
                else if ( books >= 50 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                          cin.get();         
                }
                cout<<"Hint: Press enter\n";
                cin.get();
                }
                else if ( books >= 25 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.ignore();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cout<<"Hint: Press enter\n";
                cin.get();
                }
                else if ( books >= 1 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                      else if ( input != 'e' )
                      {
                          cout<<"Error. Please enter your only option next time, e\n";
                          cin.get();
                }
                else if ( books == 0 )
                {
            cout<<"Listed below are your options:\n";
                        cout<<"Sorry, Start reading and maybe you'll win something next time!\n";
                }
        else if ( books < 0 )
        {
            cout<<"Error. Please enter a positive integer.\n";
                    cin.get();
            }
}
        else if ( book )
        {
            cout<<"Oops! Please inter a positive integer!\n";
            cin.get();
            }
            cout<<"Input 1 to continue, 200 to close out.\n";
            cin>> i;
            cin.ignore ();
            return 0;
}
}

---

Code:

---

                while ( i != 200 )
                {
                  cout<< i <<endl;
                  i++;

---

Code:

---

            return 0;
}
}

---

Change the while statement to while(1), which means the while loop is always true, and therefor going to repeat. Remove the cout, and i variable. Then add the ability to quit the program somehow (case or if statement), and all you do there is break; the loop.

Also move the return 0; down under the end of the while loop, so it isn't just getting to the end of the while loop and exiting. So it should be between the two curly braces.

Code:

---

                char choice = 'n';
                while (1)
                {
                  cout<< "quit?" <<endl;
                  cin >> choice;
                  if(choice = 'y')
                                    break;

---

Code:

---

}
            return 0;
}

---

BTW continue; is useful too. It will start the loop over again from the top, from where ever its encountered.

Oh ok, thank you much

You shouldn't make explicitly infinite loops and you shouldn't use the break keyword. Inao the idea behind this while loop is not to be count controlled, you should have it's condition be based on something in the progam and asking the user to input a seemingly random number at the end is not the way to do that. :)

Don't worry about the loop for now, that was extra credit, remember. ;)

Code:

---

      else if ( book )
        {
            cout<<"Oops! Please inter a positive integer!\n";
            cin.get();
            }

---

Shouldn't this, since book is defined as a character, mean if they type any characters it will give this message?

Quote:

---

Originally Posted by SlyMaelstrom

You shouldn't make explicitly infinite loops and you shouldn't use the break keyword. Inao the idea behind this while loop is not to be count controlled, you should have it's condition be based on something in the progam and asking the user to input a seemingly random number at the end is not the way to do that. :)

Don't worry about the loop for now, that was extra credit, remember. ;)

---

As if anyone new to learning programming doesn't learn these techniques in order to grasp concepts and actually get somewhere? I'd love to have seen how many people would quit if easier techniques for learning things were abolished. I'm pretty sure I've seen infinite loops in most tutorials I've ever read. Rare cases that they are problems don't tend to occur until the programmer is making programs advanced enough to already know more about them. I believe they are fine for learning/testing purposes. I also remember seeing one of your payrolled bot programmers using one yesterday.

Just base the while statement on the choice variable then. If its equal to 'y', then it will continue, otherwise it doesn't.

You don't teach someone things that you know are bad. Even if you expect them to know better when they get experienced. Bad teaching leads to bad habits.

It's like teaching a kid to throw something they broke under the sofa. Yes, they'll probably know that's bad when they're older, but it will lower their standards of the difference between what is good and what is bad.

Alright, I'm tired and making more mistakes by the minute. I'm going to crash and work on it some more tomorrow (I'd hope to have this in tonight, if you want what I have just tell me, I'll wait for a response to this post before I go) Also, how long is it going to take for the chat server to be back up? is it now?

Quote:

---

Originally Posted by SlyMaelstrom

You don't teach someone things that you know are bad. Even if you expect them to know better when they get experienced. Bad teaching leads to bad habits.

---

I don't agree that while(1) is so bad that it cant be used while learning. Its like using namespace std. Its just easier, and anyone who could get to programs where while(1) actually becomes a problem should easily be able to stop the "habit". I don't know where people get that bad habits die hard when it comes to programming. I've never have a problem with using std::, initializing variables, declaring const, etc. when I program for real and not to test. Maybe thats me, or maybe I don't notice it. I believe the learning benefit is greater than the risk. You should be familar with bad code anyway, as it carries through languages in different forms. Thats just my opinion.

However, I should have mentioned they are bad practice. Either or both of us should at least explain why they are bad. Infinite loops like this one could result in the program eating up computer memory. For example if you entered in something that was not accepted by cin, like if an int was expected, and a char was put used instead, that would result in an infinite loop. More: http://www.cis.nctu.edu.tw/chinese/d....html#faq-15.2 Maybe you use an infinite loop to recieve input from a file, but a problem occurs half way through and it doesn't reach the end like you expected, so you're stuck in the loop. Generally something unexpected might happen in your program and you might have no way of exiting the loop. Obviously. Sometimes they are necessary though, but definetly not in your case. In which case you should check for anything you suspect might result in a true infinite loop and prevent it. Probably even something to prevent too many loops for occurring too. Theres an even higher risk if someone else is using your code, or its a library of some sort for someone to use. Any time of infinite loop is suspicious, because you can't always know what will happen in order to prevent true infinite loops. I'm sure theres more too.

So.. avoid infinite loops, and btw, dont use using namespace std. Its still my opinion that using an infinite loop for quick and easy learning isn't that bad. I used and learned about goto's, but don't use them anymore because I know of better ways.

Edit: Before I go to bed, I've just decided I agree, whatever, people have bad habits. I don't find them hard to change, but whatever. I haven't been programming long enough to talk.

On a side note, just found this o.0: http://www.cs.rice.edu/~ian/Manifest...C++isBad.shtml

Quote:

---

¹ Java, while much better than C++, shares this same weakness: the smallest Java program requires about 12 keywords, each replete with meaning; a beginner must be told "put these words in your program in just this right order, else it won't work". I've seen many students needlessly frustrated because it takes 30min to figure out their non-working program resulted from only inscribing eleven of the dozen necessary arcane glyphs. They may understand conceptually exactly what they want to do, but the arbitrary details of excessive syntax take out all the interest. (Some studies suggest that the prevalent teaching mode — encouraging arbitrary tinkering with little direction or meaning just trying to get it to work — is one reason for the prounounced gender bias seen in the field of computer science.)

---

Seriously.. they have their purposes. It doesn't mean the language is bad, it just means its not the right choice.

can someone toss me a link on exceptions?

After the first question is asked "How many books have you read in the past year?" if I enter characters "faslkdfja" or any other combination of course, it throws me into an infinite loop... help!?

Here it is:

Code:

---

#include <iostream>
 
using namespace std;
 
int main()
{
                int books;
                char book;
                char input;
                char choice;
                while( choice != 'Y' )
                {
                cout<<"How many books have you read this last year?\n";
                cin>> books;
                cin.ignore();
                cout<<"You read "<< books <<"?\n";
 
                if ( books >= 90 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" a : 42' Tv Set!\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
                  if ( input == 'a' )
                  {
                        cout<<"Wow! Congratulations! You've won a 42' Tv Set!\n";
                        cin.get();
                        }
                  else if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                  else if ( input != 'a' || input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";           
                }
                cout<<"Hint: Press enter\n";
                cin.get();
    }
                else if ( books >= 75 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore ();
            if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
        cout<<"Hint: Press enter\n";
        cin.get();   
                }
                else if ( books >= 50 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                          cin.get();         
                }
                cout<<"Hint: Press enter\n";
                cin.get();
                }
                else if ( books >= 25 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.ignore();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cout<<"Hint: Press enter\n";
                cin.get();
                }
                else if ( books >= 1 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            cin.ignore();
            if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                      else if ( input != 'e' )
                      {
                          cout<<"Error. Please enter your only option next time, e\n";
                          cin.get();
                }
                else if ( books == 0 )
                {
            cout<<"Listed below are your options:\n";
                        cout<<"Sorry, Start reading and maybe you'll win something next time!\n";
                }
        else if ( books < 0 )
        {
            cout<<"Error. Please enter a positive integer.\n";
                    cin.get();
            }
}
            if ( books == book )
        {
            cout<<"Oops! Please inter a positive integer!\n";
            cin.get();
            }
            cout<<"Quit? Y/N\n";
            cin>> choice;
            if ( choice == 'Y' )
            {
                  break;
}
}
return 0;
}

---

Yay!!... not... Help please! lol

Nice indentation. :)

Code:

---

                char choice;
                while( choice != 'Y' )

---

There's a possibility that choice will be 'Y', and the loop will never execute. To fix it:

Code:

---

                char choice = 0;
                while( choice != 'Y' )

---

You need to flush the input buffer and clear it, etc. You're expecting a number, and if you give it a letter . . . you know.

http://faq.cprogramming.com/cgi-bin/...&id=1043284392

Code:

---

#include <iostream>
#include <cstdio>

using std::cin;
using std::cout;
using std::endl;

int main(void)
{
  int ch;
  char buf[BUFSIZ];
   
  cout <<"Flushing input" <<endl;
 
  while ((ch = cin.get()) != '\n' && ch != EOF);
 
  cout <<"Enter some text: ";
  cout.flush();
 
  if (cin.getline(buf, sizeof(buf)))
  {
    cout <<"You entered: " <<buf <<endl;
  }

  return 0;
}

---

So I need to add this to my code? excluding the couts? or.. how would I manage that?

You need to use cout.flush(), I think, and maybe cout.clear() or something. I don't really know. (I know how to do it in C, but that won't help . . . .)

Code:

---

bool InputCheck()
{
  if (cin.fail()) {
    cerr << "Error: Invalid input." << endl;
    cin.clear();
    cin.ignore();

    return 0;
  }

  return 1;
}

---

Just call InputCheck() after trying to receive input.

Can you help me figure out where to place that within the above code?

Code:

---

#include <iostream>
 
using namespace std;

bool InputCheck();

int main()
{
                int books;
                char book;
                char input;
                char choice;
                while( choice != 'Y' )
                {
                cout<<"How many books have you read this last year?\n";
                cin>> books;
                InputCheck();
                cin.ignore();
                cout<<"You read "<< books <<"?\n";
 
                if ( books >= 90 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" a : 42' Tv Set!\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            InputCheck();
            cin.ignore();
                  if ( input == 'a' )
                  {
                        cout<<"Wow! Congratulations! You've won a 42' Tv Set!\n";
                        cin.get();
                        }
                  else if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                  else if ( input != 'a' || input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";           
                }
                cout<<"Hint: Press enter\n";
                cin.get();
    }
                else if ( books >= 75 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" b : MP3 Player!\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            InputCheck();
            cin.ignore ();
            if ( input == 'b' )
                  {
                      cout<<"Good Job! You've won an MP3 player!\n";
                      cin.get();
                      }
                  else if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                      else if ( input != 'b' || input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
        cout<<"Hint: Press enter\n";
        cin.get();   
                }
                else if ( books >= 50 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" c : Sony Cd Player!\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            InputCheck();
            cin.ignore();
            if ( input == 'c' )
                  {
                        cout<<"The work paid off! You've won a Sony CD player!\n";
                        cin.get();
                        }
                  else if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.get();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'c' || input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                          cin.get();         
                }
                cout<<"Hint: Press enter\n";
                cin.get();
                }
                else if ( books >= 25 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" d : Book Subscription!\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            InputCheck();
            cin.ignore();
            if ( input == 'd' )
                  {
                        cout<<"This'll help you boost your score! Your very own National Book Club Subscription!\n";
                        cin.ignore();
                        }
                  else if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.ignore();   
                      }
                  else if ( input != 'd' || input != 'e' )
                  {
                        cout<<"Error. Please enter a, b, c, d, or e\n";
                        cin.get();           
                }
                cout<<"Hint: Press enter\n";
                cin.get();
                }
                else if ( books >= 1 )
                {
            cout<<"Listed below are your options:\n";
            cout<<" e : A peice of Candy!\n";
            cin>> input;
            InputCheck();
            cin.ignore();
            if ( input == 'e' )
                  {
                      cout<<"Here is some candy, maybe it will boost your brain power!\n";
                      cin.get();   
                      }
                      else if ( input != 'e' )
                      {
                          cout<<"Error. Please enter your only option next time, e\n";
                          cin.get();
                }
                else if ( books == 0 )
                {
            cout<<"Listed below are your options:\n";
                        cout<<"Sorry, Start reading and maybe you'll win something next time!\n";
                }
        else if ( books < 0 )
        {
            cout<<"Error. Please enter a positive integer.\n";
                    cin.get();
            }
}
            if ( books == book )
        {
            cout<<"Oops! Please inter a positive integer!\n";
            cin.get();
            }
            cout<<"Quit? Y/N\n";
            cin>> choice;
            if ( choice == 'Y' )
            {
                  break;
}
}

bool InputCheck()
{
  if (cin.fail()) {
    cerr << "Error: Invalid input." << endl;
    cin.clear();

    return 0;
  }

  return 1;
}

return 0;
}

---

I did modify the function from my own, but it should work.

I prefer this way to handle bad input. You have to #include <limits>. It is nicer in that it will ignore all bad data input by the user, unlike Dae's version which ignores 1 character only.

Code:

---

while (!(cin>> books))
{
  cin.clear();
  cin.ignore(numeric_limits<streamsize>::max(), '\n');
  // Prompt again here.
}

---

Quote:

---

Originally Posted by Daved

I prefer this way to handle bad input. You have to #include <limits>. It is nicer in that it will ignore all bad data input by the user, unlike Dae's version which ignores 1 character only.

Code:

---

while (!(cin>> books))
{
  cin.clear();
  cin.ignore(numeric_limits<streamsize>::max(), '\n');
  // Prompt again here.
}

---

---

The version I use is like that actually, of course thanks to Prelude. But I changed it to simplify. I forgot though, would you have to extract all characters from the stream since they would still be there if the wrong type was entered? or would they be extracted like normal, and just failed to be assigned?

Nevermind, I found the answer at gamedev, the bad input is still in the input stream. So yeah, you would most likely need to clear more than 1 character, haha. Thanks Daved.

Just to explain, another alternative would be cin.ignore(256,'\n');. Which says it will keep extracting up to 256 character or a \n (newline character) is encountered. But it would be more reliable to use limits incase theres more than 256 characters - where limits would detect the definite amount of characters to extract from the stream. The loop will continue until valid input is given, when (cin>> books) resolves to true, and if it isnt valid input it clears the input. Thats pretty good, I think I saw it used a while back.. but didn't understand it so I read past it.

A w e s o m e !