help with functions and array please

Hi Guys,

Very new with C++ so please bear with me ;-)

Been asked to create a SIMPLE program with an array [20] that holds values from 0 - 100. I then need to write functions to calculate:

- largest number in the array
- smallest number in the array
- the sum of all of the numbers in the array
- the mean of all of the numbers in the array

Now on my own I have started it off by splitting up the functions into four sections:

- void get_largest_number();
- void get_smallest_number();
- void get_sum_of_number();
- void get_mean_of_number();

Now in the get_largest_number() function I have created an array that increments by one in a FOR loop every time a number is entered then each number is added to the total each time it loops. I have so far got this far, however I’m not sure about my calculations for the:

- void get_smallest_number();
- void get_sum_of_number();
- void get_mean_of_number();

I’ve had a go, but don’t think it’s right – can anyone please advise where im wrong with these other functions (if they are wrong)?

Many Thanks

Cbo

Code:

/ values.h
// Determining the largest, smallest, sum and mean
#include <iostream.h>

class values
  {
   public:
     void get_largest_number();
     void get_smallest_number();
     void get_sum_of_number();
     void get_mean_of_number();
   protected:
     int sum = 0;
     int mean = 0;
   };

void values::get_largest_number(int a[])
{
     largest_number = a[0];
     
     for(i=1; i<20; i++)
     { 
       if(a[i] > largest_number)
       {
            largest_number = a[i];
       }
     }
} 

void values::get_smallest_number(int a[])
{
     smallest_number = a[0];
     
     for(i=1; i<20; i++)
     { 
       if(a[i] < smallest_number)
       {
            smallest_number = a[i];
       }
     }
} 


void values::get_sum_number()
{
     total=0;
     for ( int i = 0; i < 20; i++)

        { total +=[i];
        }

    sum = total;
}



void values::get_mean_number()
{

     for ( int i = 0; i < 20; i++)

        { sum +=a[i];
        }

    mean = sum / 20;
}

For starters, you want to be returning the type of the largest number, assuming they are ints change it to

Code:

int values::get_largest_number(int a[])
{
     largest_number = a[0];
     
     for(i=1; i<20; i++)
     { 
       if(a[i] > largest_number)
       {
            largest_number = a[i];
       }
     }
}

You have an array argument here so you must also have it in your class definition.

The logic seems correct by glance, just change your return types to ints and correct argument lists.

Cheers jlf029, just me being stupid declaring my functions as void() and not int().

The thing i'm not sure about are these two functions:

Code:

void values::get_sum_number()
{
     total=0;
     for ( int i = 0; i < 20; i++)

        { total +=[i];
        }

    sum = total;
}



void values::get_mean_number()
{

     for ( int i = 0; i < 20; i++)

        { sum +=a[i];
        }

    mean = sum / 20;
}

Can someone tell me if my implementation is right here to get the sum of numbers in the first function and mean number in the second function - am I going on the right line?

Many Thanks

In get_mean_number, mean is not declared (and I think you should return it, too):

Code:

int values::get_mean_number()
{
    int mean;

     for ( int i = 0; i < 20; i++)

        { sum +=a[i];
        }

    mean = sum / 20;

    return mean;
}

[edit]
Never mind; I see mean is part of the class.
[/edit]

Code:

#include <iostream.h> --> <iostream>

However, you never use <iostream> in that file anyway.
----

The thing i'm not sure about are these two functions:

Code:

void values::get_sum_number()
{
     total=0;
     for ( int i = 0; i < 20; i++)

        { total +=[i];
        }

    sum = total;
}

-----

Code:

class values
  {
   public:
     void get_largest_number();
     void get_smallest_number();
     void get_sum_of_number();
     void get_mean_of_number();
   protected:
     int sum = 0;
     int mean = 0;
   };

This ain't Java. In C++, you can can't initialize class member variables in the class declaration. You need to use a constructor to initialize those variables.
---

class values

By convention, class names are capitalized.

Since the class name is 'values' wouldn't it make more sense to make the array a member variable? And if 'sum' and 'mean' are member variables, why aren't 'smallest' and 'largest'?

Think about how your get_sum_number() function works. Are you going to calculate the sum of the array every time someone needs it? That seems like a waste since it only needs to be calculated once. Or, are you going to calculate the sum once and then store the sum in the member variable 'sum'? If you calculate it once and store the result in the member variable 'sum', how will the user be able to access 'sum' to get its value?

Also, look at the way you are calculating the sum and mean:

Code:

void values::get_sum_number()
{
     total=0;
     for ( int i = 0; i < 20; i++)

        { total +=[i];
        }

    sum = total;
}
void values::get_mean_number()
{

     for ( int i = 0; i < 20; i++)

        { sum +=a[i];
        }

    mean = sum / 20;
}

Where does a[i] come from? It's not a parameter of the function, it's not a local variable you declared in the function, and it's not a class member.

Also, if you calculate the sum of an array and store it in the member variable sum, what is the idea behind adding more numbers to sum in the function get_mean_number()?