Tic Tac Toe loop

[howeezy]

Hi, I have to write tic tac toe for a class and I have never even written a loop. Obviously I haven't put my study time in, but that's besides the point. Can someone please explain to me why this keeps repeating
"Please make a selection:" even after I enter 1 or 2? It's probably obvious.

#include <iostream>
#include <string>
using namespace std;
void printMenu();
float makeSel();
int main()
{
 do{
  printMenu();
  makeSel();
  //game goes here
  cout<<"game"<<endl;
 
 }while (makeSel()!=2);
 
 
  

 return 0;
 }
void printMenu()
{
 cout<<"Welcome to Tic-Tac-Toe!"<<endl<<"Three in a row wins!"<<endl;
 cout<<"        1).Play a game."<<endl<<"        2).Quit"<<endl;
}
float makeSel()
{
 float sel;
 do{
  cout<<"Please Make a Selection: ";
  cin>>sel;
   } while(sel!=1 ||sel!=2);

 
 
 return sel;
}

[cbastard]

int main()
{float x;
 do{
  printMenu();
  x=makeSel();
  //game goes here
  cout<<"game"<<endl;
 
 }while (x!=2);

catch the value of function and then compare it.

[Bajanine]

Why are you storing the user input into a float?

[Dae]

while(sel!=1 || sel!=2), say sel is 2, so then it becomes while(1 || 0), which becomes while(1). You're saying that if sel is not equal to 1, or 2, then it continues, but you have it in two different statements so its basicly expecting sel to be two numbers. What you want is sel != 1 && sel != 2, that way its only going to return true if both are true, and hence sel isn't equal to 1 or 2.

I'd also lose the float, it isn't necessary.. just pointless.

[howeezy]

what would happen if some clever idiot decided to put 3.3 as an answer?


thank you for the help

[Bajanine]

Or how about a letter or string!!

[howeezy]

ugh im glad im getting out of this major

[Dae]

#include <climits>

inline void ClearStream(std::istream& in)
{
  in.clear ();
  in.ignore (std::numeric_limits <std::streamsize>::max (), '\n');
}

inline bool InputCheck()
//returns true (1) if cin did not fail
{
  if (std::cin.fail()) {
    std::cerr << "Error: invalid input entry.\n";
    ClearStream (std::cin);
  } else {
    return 1;
  }

  return 0;
}

int makeSel()
{
  int sel;
  do{
    cout<<"Please Make a Selection: ";
    cin>>sel;
  } while(InputCheck() != 1);

  return sel;
}

Don't conform to idiots - prevent their cleverness.

The reason for ClearStream() is because if the wrong datatype is put into the stream, cin will keep using that as its input and keep looping through that (the solution to that clever person).

[howeezy]

dae, thanks for the help, but if i used that in my program my teacher would probably smack me and ask me how i got it.