Thread: Whats wrong with this code?

Code:

string c,e;
     float d,j,k,l,n;
     int m;
     char a[18];
     cout<<"Type the archive that you want to open:\n";
     cin.getline(a,18);
     cin.ignore();
     ifstream a_file ( a );
     getline(a_file,c);
     getline(a_file,d);
     getline(a_file,e);
     getline(a_file,j);
     getline(a_file,k);
     getline(a_file,l);
     getline(a_file,m);
     getline(a_file,n);
     cout<<"ÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍ\n";
     cout<<""<< c <<"\n";
     cout<<""<< d <<"\n";
     cout<<""<< e <<"\n";
     cout<<""<< j <<"\n";
     cout<<""<< k <<"\n";
     cout<<""<< l <<"\n";
     cout<<""<< m <<"\n";
     cout<<""<< n <<"\n";
     cout<<"ÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍ\n";

well, the problem is that the archive that i want to open has to many lines, so i tried to do 1 getline for each line, but its not working it dont compile :/ help plz, ty

If it didn't compile, what are the compiler errors?

Right away, I can see that you are using getline to read in floats and an int. The getline function only reads into a string. Use cin >> to read in floats or ints, or use getline and then convert the string to a float/int using a stringstream. If you do use cin >> to read in the numbers, remember to use ignore() to ignore the newline if you use getline to read the next line.

I wonder what you'd do if you had 1,000 lines in that file?

>> it´s not showing in the screen the cout

You don't need that cin.ignore() there. It means you have to hit enter before the stuff is output. The ignore() is only useful after cin>>.

Also, add a cin.get() at the end of the code if your console window is closing.