Working with Strings and Numbers

I'm converting a exe to a dll. I need to capture the errors
and display them at the end of the program instead of displaying the error as it happens (the way it works now).

I set up a variable named warning list:

Code:

WarningList[255];

I replaced the spots where the program would display errors
with the following code (Note - the old code would display variables of different types:

Old Code/

Code:

 cout<<"A";
scrn<<"NOTE: The bond between atoms "<<papa[q[j]]<<" and "<<q[j]<<" is not in an aromatic ring.\n";
 scrn<<"It will be interpreted as a single bond.\n";

New Code/

Code:

 if (strlen(WarningList) > 1) {
strcat(WarningList,",");	
}

strcat(WarningList,"The bond between atoms ");
strcat(WarningList,papa[q[j]]);
strcat(WarningList,"and ");
strcat(WarningList,q[j]);
strcat(WarningList," is not in an aromatic ring. It will be interpreted as a single bond.");

The problem I'm running into is including variables that are integers in my WarningList. Here's the specific error:

C:\MSDEV\Projects\cfx_SmilesParser\request.cpp(452 ) : error C2664: 'strcat' : cannot convert parameter 2 from 'int' to 'const char *' (new behavior; please see help)

I'm new to C++ and have been having a hard time figuring out how to get this to work. Any advice would be greatly appreciated.

if you were using std::string, I would say to use std::stringstream, but since you're not, do this instead of strcat:

Code:

sprintf(WarningList, "%s%d", WarningList, q[j]);

assuming that the q[j] is where your int is.

Thanks, that worked great.

Originally Posted by rockytriton

if you were using std::string, I would say to use std::stringstream, but since you're not, do this instead of strcat:

Code:

sprintf(WarningList, "%s%d", WarningList, q[j]);

assuming that the q[j] is where your int is.

I'm not sure but I think the behavior is undefined if you copy between strings that overlap. Maybe someone else knows for certain...

use stringstreams instead. Then you can use your old code with very little modifications.

I'm using Visual C++ version 4. sstreams.h is not in the include folder. I've looked on the Web for it, but there are a bunch of different versions of it. How can I get the correct
sstream.h file?

It's sstream without the .h, but if you are using VC++ 4 then it might not work anyway. Check dinkumware.com to see if they have a standard library for that version.

Originally Posted by Daved

It's sstream without the .h, but if you are using VC++ 4 then it might not work anyway. Check dinkumware.com to see if they have a standard library for that version.

If not sstream then he might have strstrea.h but I shudder at the thought of having to use that.

Originally Posted by hk_mp5kpdw

I'm not sure but I think the behavior is undefined if you copy between strings that overlap. Maybe someone else knows for certain...

Hmm, I haven't heard of that, if you are right there is probably a lot of undefined behavior in a lot of applications that I've worked on!