Thread: case switch problem

i wrote a program and it worked fine, but i added a case swich just so the user didnt have to reopen the program everytime he/she wanted to recaluclate, but it doesn't work. Can someone tell me whats wrong?

Code:

int repeat()
{
    int yesno;
    
    cout << "\nWould you like to calculate again? y/n : ";
    cin >> yesno;
    
    switch( yesno )
    {
              case 'y' :
                 start();
                 break;
              
              case 'n' :
                 return 0;
                 break;
              
              default:
                 cout << "Not an option!";
                 return repeat();
                 break;
    }
}

That's because yesno is an integer not a character. Declare that as so:

Code:

char yesno;

Then it should work.

How does it not work?

The possible problem I see is that for case 'y', repeat() does not return a value.

it would go to the default and keep showing the samething over and over really fast, i didnt relize i decalered it an int.

The over-use of recursion where a few loops would do seems to be a problem to me.

Cool-August you can use switch statements like he is doing. It is so you don't have to have all those if statements. Like below:

Code:

#include <iostream>
using namespace std;
int main()
{
    char yesno;
    cout<<"Enter y or n:";
    cin>>yesno;
    switch(yesno)
    {
                 case 'y':
                      cout<<"You entered a y\n";
                      break;
                 case 'n':
                      cout<<"You entered an n\n";
                      break;
                 default:
                         cout<<"You didn't enter a y or n\n";
                         break;
    }
    system("PAUSE");
    return 0;
}

That is just like 2 if statements and an else if statement, except shorter and better looking.

The over-use of recursion where a few loops would do seems to be a problem to me.

Well, that depends on what start() does, I suppose, though I agree the recursion in calling repeat() isnt necessary at all.

but how can that be a problem?

That depends on what the OP is using the return value for, but yeah, it probably is the int yesno that's causing the problem described.

It is so you don't have to have all those if statements.

It'll probably make more sense when used to test both uppercase and lowercase characters, but then this is only a test snippet.

Yes, it would but he didn't include them so I didn't either. <-Regarding the upper and lower case y and n.