problem in creating a tree

This is a discussion on problem in creating a tree within the C++ Programming forums, part of the General Programming Boards category; Hi, I encountered some problems in creating a tree and using preorder algorithm to travel it. Code: // Create a ...

  1. #1
    Registered User
    Join Date
    Mar 2005
    Location
    Hangzhou,China
    Posts
    7

    problem in creating a tree

    Hi, I encountered some problems in creating a tree and using preorder algorithm to travel it.


    Code:
    // Create a binary search tree
    
    #include<iostream>
    struct TreeNode;
    typedef struct TreeNode *PtrToNode;
    typedef struct TreeNode *Tree;
    using namespace std;
    
    struct TreeNode {
                    int data;
    	PtrToNode left;
    	PtrToNode right;
    };
    
    // insert a new node into a binary search tree
    // using a recursive algorithm
    void insert(Tree tree, int item) {
    	if( tree == 0 ) {
    		tree = (Tree)malloc(sizeof(struct TreeNode));
    		if( tree == 0 ) {
    			cout << "Fatal error!" << endl;
    			exit(1);
    		}
    		else {
    			tree->data = item;
    			tree->left = tree->right = 0;
    		}
    	}
    
    	else if( item < tree->data )
    		insert( tree->left, item);
    	else if( item > tree->data )
    		insert( tree->right, item );
    
    }
    
    // create a new binary search tree
    void createTree( Tree tree, int a[], int n ) {
    	for( int i = 0; i < n; i++ )
    		insert( tree, a[i] );
    }
    
    void preorder( Tree tree ) {
    	if( tree != 0 ) {
    		cout << tree ->data << ' ';
    		preorder( tree->left );
    		preorder( tree->right );
    	}
    }
    
    
    int main(void) {
    	const int maxsize = 5;
    	int a[maxsize] = {5,3,9,1,10};
    	Tree T = 0;
    	createTree(T,a,maxsize);
    	
    	preorder( T );
    
    	return 0;
    }
    so why there is no output to the screen??
    thanks for your help~~~

  2. #2
    and the hat of wrongness Salem's Avatar
    Join Date
    Aug 2001
    Location
    The edge of the known universe
    Posts
    32,659
    > tree = (Tree)malloc(sizeof(struct TreeNode));
    Use new in C++, not malloc.

    The main problem is you don't return the tree to main - remember, it's pass by value.
    To fix this, make insert pass the tree by reference
    If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
    If at first you don't succeed, try writing your phone number on the exam paper.
    I support http://www.ukip.org/ as the first necessary step to a free Europe.

  3. #3
    Registered User
    Join Date
    Jan 2005
    Posts
    7,340
    You are passing the tree pointer by value to your createTree and insert functions. You should pass the pointers by reference so that the new pointer value created by the call to malloc will be saved in the original pointer variable passed to the function.

    Note that you have to make createTree take a reference as well.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. Binary tree problem
    By moddinati in forum C++ Programming
    Replies: 8
    Last Post: 06-19-2008, 05:05 PM
  2. BST delete again, but this time I think I'm close
    By tms43 in forum C++ Programming
    Replies: 9
    Last Post: 11-05-2006, 05:24 PM
  3. binary tree token problem
    By OldSchool in forum C++ Programming
    Replies: 13
    Last Post: 05-28-2006, 10:42 PM
  4. searching and insertion in a binary search tree
    By galmca in forum C Programming
    Replies: 1
    Last Post: 03-26-2005, 04:15 PM
  5. Binary tree problem
    By carrja99 in forum C++ Programming
    Replies: 4
    Last Post: 02-27-2003, 08:36 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21