Using the string replace function

The code:

Code:

				std::string removecharacters(std::string strText)
		{
			std::string strUnwanted;
			int currLoc = 0;
			int StringLength = 0;
			char tmpChar;

			strUnwanted = "~`!@#$%^&*()_-+={}|[]\\:;'<>?,./\"";

			StringLength = strUnwanted.length();
	
			for(currLoc=1;currLoc = StringLength;currLoc++)
			{
				tmpChar = strUnwanted.substr(currLoc, 1);
				//const char chtemp = tmpChar????
				strText.replace(strText.begin(),strText.end(), tmpChar, "");
				
			}

			return strText;

		}

:\my stuff\c++\mfprocess\validation.h(62) : error C2664: 'class std::basic_string<char,struct std::char_traits<char>,
class std::allocator<char> > &__thiscall 
std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >::replace
(unsigned int,unsigned int,const char *,unsigned int)' :
 cannot convert parameter 1 from 'char *' to 'unsigned int'
        
This conversion requires a reinterpret_cast, a C-style cast or function-style cast

The replace function needs a const where I am passing a string. The string is integral as it's part of the loop looking for different symbols to replace. What should I do?

the stl find algorithm works better in this case to replace by yourself (the replace in string class wont do very good, it does other things)

Code:

std::string& removecharacters(std::string& strText)
{
    std::string strUnwanted("~`!@#$%^&*()_-+={}|[]\\:;'<>?,./\"");

    int StringLength = strUnwanted.size( );
	for (int currLoc = 0; currLoc < StringLength; currLoc++) {
        char chtemp = strUnwanted[currLoc];
       
        std::string::iterator ci = std::find(strText.begin( ), strText.end( ), chtemp);
        while (ci != strText.end( )) {
            *ci = '\0';
            ci = std::find(ci + 1, strText.end( ), chtemp);
        }		
    }

    return strText;
}

dont read strings by value, that is expensive

http://www.cppreference.com/ <---- check that for find algorith in <algorithm> and check what the string replace function does

excellent, thanks. I'm still learning.

The problem with the original code was that it didn't match any of the existing forms of replace. Which form were you trying to use, or were you just hoping that it would match?

Normally you should prefer the string::find function over the generic STL find algorithm, since the string specific one might be optimized for strings.

To accomplish this task, I would use string::find_first_of and pass strUnwanted. Save the return value and use it the next time through the loop as the second parameter to find_first_of. Inside the loop use the return value of find_first_of to erase the character (I assume you didn't mean to replace it with a null character). The string::erase function takes an index and will erase that one character.

If you really wanted to be fancy you could use for_each or some other algorithm and a function object, but the loop I described above should be fine.

I'll look at your idea as well. I had used replace in another area but was not using variables in that case.

my final result

Code:

std::string& Sremovecharacters(std::string& strText)
{
    int iPos = 0;
    std::string strUnwanted("~`!@#$%^&*()_-+={}|[]\\:;'<>?,./\"");
    int StringLength = strUnwanted.size();
	
	for (int currLoc = 0; currLoc < StringLength; currLoc++) {
		iPos = strText.find_first_of (strUnwanted, 0);
        while (iPos != -1) 
		{
            strText.erase(iPos,1);
            iPos = strText.find_first_of (strUnwanted, (iPos+1));
        }		
    }

    return strText;
}

Well done. One thing about the find_first_of function, it finds the first instance of any of the characters in the strUnwanted string. That means you only need to go through one time. Your for loop is unnecessary because the first time through all unwanted characters will be erased and the rest of the times through th efor loop will do nothing. So try getting rid of the for loop completely and just run the block of code inside it once. You should still get the same result.

speaking of strings, does anyone know a website that has a good reference of the 'string' class?