whats wrong here

i have the code

Code:

	cPlayer MyPlayer;

	cout<<"Dagger Skill: %d"<<MyPlayer.GetValue( Dagger );
                cin.ignore();

	MyPlayer.SetValue(Dagger, 50);

	cout<<"Dagger Skill: %d"<<MyPlayer.GetValue( Dagger );

and i get 3 parse errors and i think it has to do with the ( Dagger )
part of the program, this is my attempt at making this

Code:

cPlayer MyPlayer;

	printf("Dagger Skill: %d", MyPlayer.GetValue(DAGGER_SKILL));

	printf("\n"); //Prints a New Line

	MyPlayer.SetValue(DAGGER_SKILL, 50);

	printf("Dagger Skill: %d", MyPlayer.GetValue(DAGGER_SKILL));

into c++ (i have no knowlege of c)

What does your class GetValue function look like?

cPlayer.h is this

Code:

#ifndef CPLAYER_H
#define CPLAYER_H

#include "definitions.h"

class cPlayer
{
public:
	cPlayer(void);

	void SetValue(int SkillOrSpellID, int Value); //Sets the current value
	int GetValue(int SkillOrSpellID); //Returns the current value
private:
	int SkillAndSpellValues[NUMBER_OF_SKILLS_AND_SPELLS];

};

#endif

and my cPlayer.cpp looks like this

Code:

#include "cPlayer.h"

cPlayer::cPlayer(void)
{
	int X;

	for(X = 0; X < NUMBER_OF_SKILLS_AND_SPELLS; X++)
	{
		SkillAndSpellValues[X] = 0;
	}
	//Now all our values have been initialized to 0
}

void cPlayer::SetValue(int SkillOrSpellID, int Value)
{
	SkillAndSpellValues[SkillOrSpellID] = Value;
}

int cPlayer::GetValue(int SkillOrSpellID)
{
	return SkillAndSpellValues[SkillOrSpellID];
}

Get rid of the %d on the two lines:

Code:

cout<<"Dagger Skill: "<< MyPlayer.GetValue( Dagger );

ok, i did that and i still get the parse errors

What exactly are the parse errors and which lines are they on? And did you put:

Code:

using namespace std;
//or
using std::cin;
using std::cout;

At the top of the file that you use cin and cout in?

Code:

#include <iostream> 
#include "cPlayer.h"
using namespace std;

int main()
{
    cPlayer MyPlayer;

	cout<<"Dagger Skill: "<<MyPlayer.GetValue( Dagger );
                cin.ignore();

	MyPlayer.SetValue(Dagger, 50);

	cout<<"Dagger Skill: "<<MyPlayer.GetValue( Dagger );

	return 0;
}

and i get parse errors on lines 9, 12, and14

How is Dagger defined in cPlayer.h?

its in defintions.h

Code:

#define NUMBER_OF_SKILLS_AND_SPELLS 100
 //weapon skills
#define Dagger 0;
#define Club 1;
#define Thrown 2;
#define Shield 3;
#define Unarmed 4;
#define ShortSword 5;
#define Staff 6;
#define Ambidextrous 7;
#define Archery 8;
#define Axe 9;
#define LongSword 10;
#define TwoHandedWeapons 11;
#define Strong 12;
#define Sap 13;
#define Parry 14;
#define SneakAttack 15;
#define FavoredEnemy 16;
#define Riposte 17;
#define ExtraDamage 18;
#define Slay 19;
                    
//magic skills
                    
#define BardicLearning 20;
#define DruidLearning 21;
#define PaladinLearning 22;
#define RangerLearning 23;
#define SorcererLearning 24;
#define WizardLearning 25;
#define ManaPoints 26;
#define ReadMagic 27;
#define Ritual 28;
#define MassHeal 29;
#define TurnRebukeUndead 30;
#define Inspire Courage 31;
#define Wild Shape 32;
#define Empty Body 33;
#define Detect Evil/Good 34;
#define Lay on Hands 35;
//single spells
#define singleSpelllvlonetothree 36;
#define singleSpelllvlfourtosix 37;
#define singleSpelllvlseventonine 38;
#define singleSpelllvlten 39;
//full spell level
#define Spelllvlonetothree 40;
#define Spelllvlfourtosix 41;
#define Spelllvlseventonine 42;
#define Spelllvlten 43;
//special abilitys

You cant change the value of #define's. They are like const's, and this is why C++ has const's (among other reasons), so that you dont get some parse error thats not very explanatory of the problem when trying to change #defines, whereas trying to change consts does.

Declare those values as simple ints (global) or int const (if you dont plan on changing them).

look at the very last page of this its prety much the same questions

Originally Posted by sreetvert83

look at the very last page of this its prety much the same questions

So?

The reply is right, you adjust the #define to the value you want.. but you cant adjust it at run-time, only before you compile the program.

He also seems to be exampling in C, not C++, which is why he is using #define. If he was using C++ it would be like so:

Code:

int const NUMBER_OF_SKILLS_AND_SPELLS = 100
 //weapon skills
int Dagger = 0;
int const Club = 1;
int const Thrown = 2;
int const Shield = 3;
int const Unarmed = 4;
int const ShortSword = 5;
int const Staff = 6;
int const Ambidextrous = 7

Since you want to change the value of Dagger, you should not have 'const' on it, therefor it is a global variable (which can be changed).

You just demonstrated a reason why defines can be dangerous. When the compiler sees "Dagger" it replaces it with "0;":

Code:

#include <iostream> 
#include "cPlayer.h"
using namespace std;

int main()
{
    cPlayer MyPlayer;

	cout<<"Dagger Skill: "<<MyPlayer.GetValue( 0; );
                cin.ignore();

	MyPlayer.SetValue(0;, 50);

	cout<<"Dagger Skill: "<<MyPlayer.GetValue( 0; );

	return 0;
}

The correct define should not have a semicolon at the end

Originally Posted by Dae

So?

The reply is right, you adjust the #define to the value you want.. but you cant adjust it at run-time, only before you compile the program.

He also seems to be exampling in C, not C++, which is why he is using #define. If he was using C++ it would be like so:

Code:

int const NUMBER_OF_SKILLS_AND_SPELLS = 100
 //weapon skills
int Dagger = 0;
int const Club = 1;
int const Thrown = 2;
int const Shield = 3;
int const Unarmed = 4;
int const ShortSword = 5;
int const Staff = 6;
int const Ambidextrous = 7

Since you want to change the value of Dagger, you should not have 'const' on it, therefor it is a global variable (which can be changed).

if i dont want to use const, then why are all the declarations here int const?

from what I can tell your logic was fine, you never tried to change the value of a #define. You tried to set the value of an array who's index was a #define (Dagger).

With that said you need to remove the trailing semi colons from your defines, or change to int const as suggested.

Code:

if i dont want to use const, then why are all the declarations here int const?

Dae omitted the const from Dagger.
Not knowing how you use the rest of your defines he would not know whether you truely want the others to be const or not. From what I've seen of this and your other thread you do want them all to be const (including Dagger).