Wanna Optimize my code?

Hi! This is one of my first programs, and My first thread. I was wondering if anyone could tell why, after you miss the missing number twice, the rogram closes, and if there are any ways to optimize this code?

Code:

#include <cstdlib>
#include <iostream>
#include <stdlib.h>
#include "stdio.h"
#include "windows.h"

using namespace std;

int title()
{
cout << "W";
Sleep(200);
cout<< "e";
Sleep(200);
cout<<"l";
Sleep(200);
cout<< "c";
Sleep(200);
cout <<"o";
Sleep(200);
cout <<"m";
Sleep(200);
cout <<"e";
Sleep(200);
cout <<" ";
Sleep(200);
cout <<"t";
Sleep(200);
cout <<"o";
Sleep(200);
cout <<" ";
cout <<".";
Sleep(200);
cout << ".";
Sleep(200);
cout << ".";
Sleep(2000);
cout <<"T\n";
Sleep(200);
cout <<"               h\n";
Sleep(200);
cout <<"                e\n";
Sleep(200);
cout <<"                  \n";
Sleep(200);
cout <<"                  G\n";
Sleep(200);
cout <<"                   u\n";
Sleep(200);
cout <<"                    e\n";
Sleep(200);
cout <<"                     s\n";
Sleep(200);
cout <<"                      s\n";
Sleep(200);
cout <<"                       i\n";
Sleep(200);
cout <<"                        n\n";
Sleep(200);
cout <<"                         g\n";
Sleep(200);
cout <<"                          \n";
Sleep(200);
cout <<"                           G\n";
Sleep(200);
cout <<"                            a\n";
Sleep(200);
cout <<"                             m\n";
Sleep(200);
cout <<"                              e\n";
Sleep(200);
cout <<"                               !\n\n\n\n";
Sleep (2000);
system("cls");
cout<< "This is a fairly hard game, so if you can win,\n";
cout << "you're either really lucky or extrememly smart.\n\n\n\n";
system("pause");
system("cls");
}

int easy()                                                        
{ 
int wingame=0;
int answer;
    srand((unsigned)time(0));
int random = rand();  
int trys =15;
 
cout << "Here we go...\n\n\n\n\n";


do 
{ 
     
    cout << "What is your guess? -";
    cin >> answer;
    
if (answer < random)
{ 
           
           cout << "Too Small!\n\n\n";
           trys = trys - 1;
           cout << "Only " << trys <<" trys left!\n\n";
}

if (answer > random)
{
           cout << "Too Big!\n\n\n";
           trys = trys - 1;
           cout << "Only " << trys <<" trys left!\n\n";
} 

if (answer ==  random)
{
           cout << "Great!\n\n\n";
           wingame = 1;
           Sleep(200);
           title();          
}
}
while (wingame == 0, trys > 0);
if (trys == 0)
{cout <<"Sorry! You're out of trys!";
}
Sleep(3000);
system("cls");
if (wingame == 1)
{
title();
}
}

int menu()
{
    
    int level;
cout << "^^-----**Menu**-----^^\n\n\n\n";

cout << "1. Begin the Game\n";
cout << "2. Read Instructions\n\n\n";
// input level of user
cout <<"What is your choice? -";
cin >> level;
if (level == 1)
{
          easy();
      
}
if (level == 2)
{
cout << "This is a guessing game!(duh)\n";
Sleep (1000);
cout << "You have 10 trys to guess a random number,\n";
Sleep (1000);
cout << "which can be either huge or small.\n";
Sleep (1000);
cout << "When you finish, e-mail me to tell me how much you hated it!\n\n\n\n\n\n\n\n\n";
system ("PAUSE");
system("cls");
}
easy();
}  

int main()
{

title();
menu();

   
system("PAUSE");
return EXIT_SUCCESS;

}

Going straight for your looping condition:-

Originally Posted by Echo

Code:

while (wingame == 0, trys > 0);

What do you think the comma does here?
Perhaps you can check your reference material (like a book) to ensure that you have what you want and that's all.

Indent!!

Thanks, I'll check it out. And I'll try harder to indent.

And uh, those Sleep's...that's really ugly. Also, you do not need to optimize, just a hell of a lot of cleanup. Try these simple functions out for size, just to start cleaning.

Code:

#include <windows.h>
#include <iostream>
#include <string>

void slowType(std::string s)
{
	for(int i = 0; i < s.length(); i++)
	{
		std::cout << s[i];
		Sleep(200);
	}
	std::cout << "\n";
}
void cascade(std::string s, int start = 0)
{
	for(int i = 0; i < s.length(); i++)
	{
		for(int k = 0; k < start + 1; k++)
		{
			std::cout << " ";
		}
		std::cout<< s[i] << std::endl;
		start++;
	}
}



int main()
{
	std::string a("Hello");
	slowType(a);
	cascade("Roflcopter", a.length());
	return 0;

}

Uhh...I'm sorry, but I can't fins anything that tells me what to do, or any remote articles close to it. That comma was something I added, hoping it would work, and i was REALLY happy when the compiler didn't shoot me down. What did I do wrong?

Oh, and Tonto, I'm sorry, but I'm really teaching myself, nd I'm not quite as far as your example yet. As soon as I am, I'll try to implement it.

putting a ';' after a conditional statment, kind stops it dead,
you need to get rid of it, and use brackets around
the code you want effected by your conditional statment.

ILV, if you're referring to the "while" bit, there's a "do" towards the top of that block that starts it off, so the semicolon's supposed to be there. Hard to see it when all the brackets appear to be on the same level, but...

Echo, the comma doesn't denote a conditional (bitwise) AND. Try searching around for what does.

Thank a lot Smurf! I forgot all about boolean operators! And I'll work on cleaning the code.

I got the boolean operator &&, but the problem still persists. Any idea why?

It's normally a good idea to post your latest effort, especially after making a number of changes. We can only guess as to the actual changes you've made.