Help Please

i need help with this program , all it does is stream one file to an output file but it doesnt sound right when it is finish. can someone review this code and help me.

Code:

#include <iostream>
#include <fstream>
using namespace std;
int main()
{
    int s=0;
    char buffer[10240];
    char name[1024];
   ofstream out ("out.mp3", ios::trunc);
  out.close();
  out.open("out.mp3", ios::app);
   ifstream in ("Bad_...........mp3");
   in.seekg(s, ios::beg);
   in >> buffer;
   out<< buffer;
   out<<" ";
   s = s+strlen(buffer)+1;
   out.close();
   while (s != 0)
   {
          ofstream out ("out.mp3", ios::app);
   ifstream in ("Bad_...........mp3");
   in.seekg(s, ios::beg);
  in >> buffer;
  if (buffer != NULL and buffer != "");
  {
   out<< buffer;
   out<<" ";
   s = s+strlen(buffer)+1;
   out.close();
}
         if (buffer == NULL)
         {
   out<< buffer;
   out<<"/n";
   s = s+strlen(buffer)+1;
   out.close();
}
        if (buffer == "")
         {
   out<< buffer;
   out<< " ";
   s = s+strlen(buffer)+1;
   out.close();
}
       if (buffer == " ")
         {
   out<< buffer;
   out<< " ";
   s = s+strlen(buffer)+1;
   out.close();
}

}         
  
}

maybe you should open it as a binary file.

i tryed that already

what exactly are you trying to do? if you're just trying to copy a file from one spot to another, try this:

Code:

#include<fstream>

int main()
{
	char ch;
	std::fstream in("test.in",std::ios::binary|std::ios::in);
	std::fstream out("test.out",std::ios::binary|std::ios::out|std::ios::trunc);
	while(!in.eof())
	{
		in.read(reinterpret_cast<char*>(&ch),sizeof(ch));
		out.write(reinterpret_cast<char*>(&ch),sizeof(ch));
	}
	in.close();
	out.close();
	return 0;
}

this block makes me think you need more practice with file I/O:

Code:

   ofstream out ("out.mp3", ios::trunc);
  out.close();
  out.open("out.mp3", ios::app);

that and the fact that you're using binary methods on a non-binary stream. this is a great reference.

Easiest way (and fairly quick too) would perhaps be:

Code:

#include <fstream>

int main()
{
    ifstream in("in.mp3",ios::in|ios::binary);
    ofstream out("out.mp3",ios::out|ios::binary);

    if( in.is_open() && out.is_open() )
        out << in.rdbuf();

    return 0;
}

thanks guys and you are right i need more practice with file i/o

to think of it if you know some good file i/o website post them thanks