Why doesnt this work

Hey, im back again. I got a little time to program and so i decided to write a rock paper scissors program.

I am not sure what is wrong with it but it closes after the user inputs somthing. I think i needs it to return a value

Code:

#include <cstdlib>
#include <iostream>

using namespace std;

int rock();
int paper();
int scissors();

int main()
{
    int select;
    
    cout<< "Welcome to Rock, Paper, Scissiors Version 1.0";
    cout<< "\nInstructions:\n";
    cout<< "\nType ( 1 ) to cast rock\n";
    cout<< "Type ( 2 ) to cast paper\n";
    cout<< "Type ( 3 ) to cast paper\n";
    cout<< "\nYour choice :  ";
    cin>> select;
    switch (select)
    {
          case 1:
               rock();
               break;
          case 2:
               cout<<"asdf";//paper();
               break;
          case 3:
               cout<<"ahrt";//scissors();
               break;
          default:
                  cout<< "\nThat was not a selection!\n";
                  break;
                  }
    cin.get();
  }
  
int rock()
{
      int compchoicerock;
      
      compchoicerock = rand() % 3 + 1;
      
      if ( compchoicerock == 1 ){
           cout<< "\nThe computer also chooses rock.\n";
           cout<< "The round ends in a draw.";
           }
     
      else if( compchoicerock == 2 ){
           cout<< "\nThe computer chooses paper, and paper covers rock so you lose!\n";
           }
     
      else if( compchoicerock == 3 ){
           cout<< "\nThe computer chooses scissors, rock smashes scissors so you win!";
           }

}

Two possible problems. First, you are using cin.get() to keep the window open, but since you've added user input with operator>> the cin.get() is getting the leftover newline from the user input. The simple answer is to add a cin.ignore(); before the cin.get(). The better answer is to search the forums, FAQs, or internet for the better answer.

The second problem might be that you don't flush the output. This may or may not be causing a problem, but to be safe, consider changing cout << "\n"; to cout << endl; which adds the '\n' to the output and flushes the output to the console.

rather than use cin.get() or even cin << to keep your program open, you could implement system("PAUSE");.

Originally Posted by Jaken Veina

rather than use cin.get() or even cin << to keep your program open, you could implement system("PAUSE");.

... bad...
system calls a command line interpreter - big overhead
pause can be a malicious program
tons of better alternatives...

Frequently Unread Answers - http://faq.cprogramming.com/cgi-bin/...&id=1043284385

Originally Posted by Salem

Frequently Unread Answers - http://faq.cprogramming.com/cgi-bin/...&id=1043284385

That particular FUA and the one I (barely) saw it link to don't actually help fix the problem. If there is one that tells how to ignore the newline in the stream that would be better.

Code:

switch (select)
    {
          case 1:
               rock();
               break;
          case 2:
               cout<<"asdf";//paper();
               break;
          case 3:
               cout<<"ahrt";//scissors();
               break;
          default:
                  cout<< "\nThat was not a selection!\n";
                  break;
                  }
    cin.ignore();
    cin.get();
  }
  
int rock()

You need to insert a cin.ignore(); before your cin.get(); like I have shown. Then when the user inputs their guess, the window stays open.

Originally Posted by xErath

... bad...
system calls a command line interpreter - big overhead
pause can be a malicious program
tons of better alternatives...

Ahh.....I apologize. I'll keep that in mind. Thank you for pointing it out.

ok that sloved the problem of the window closing, but now i am having trouble with the rand part

Code:

void rock()
{
      int compchoicerock;
      
      compchoicerock = rand() % 3+1 ;
      
      if ( compchoicerock == 1 ){
           cout<< "\nThe computer also chooses rock.\n";
           cout<< "The round ends in a draw.";
           }
     
      else if( compchoicerock == 2 ){
           cout<< "\nThe computer chooses paper, and paper covers rock so you lose!\n";
           }
     
      else if( compchoicerock == 3 ){
           cout<< "\nThe computer chooses scissors, rock smashes scissors so you win!\a\a\a";
           }

}

if i leave the rand as it is i always win, but if i take away the +1 I always lose.
i havent looked at the FAQ yet, but i read rod's tutorial on rand but i didnt understand it

can someone explain please and thank you

Seed the random number generator with a call to srand(). The easiest way is to include <ctime> and call srand(time(0)); once at the very beginning of your main function. This will give it a different seed each time, otherwise the random numbers generated will always be the same.

wait explain a little bit more. I changed rand so srand and add #include <ctime> but now it gives me errors and the compiler opens up stdlib.h every time i run the debugger

try out this code

Code:

int rock()
{
      int compchoicerock;
      
      srand(time(0));
      compchoicerock = rand() % 3;
      if ( compchoicerock == 0 ){
           cout<< "\nThe computer also chooses rock.\n";
           cout<< "The round ends in a draw.";
           }
     
      else if( compchoicerock == 1 ){
           cout<< "\nThe computer chooses paper, and paper covers rock so you lose!\n";
           }
     
      else if( compchoicerock == 2 ){
           cout<< "\nThe computer chooses scissors, rock smashes scissors so you win!";
           }

}

i hope this will work fine for you

Code:

rand() % 3

when u you this rand number starts from 0 to 2 - not more than 3 -. so when 'if conditions' are between these number the program works fine.

s.s.harish

thank you all very much

Originally Posted by xErath

... bad...
system calls a command line interpreter - big overhead
pause can be a malicious program
tons of better alternatives...

Guidelines for safely using system(). Not super convenient, but it works.