Thread: Damned bool function

Im trying to make a function to determine whether an attack succeeds in a little game im making. The function is shown below

Code:

bool attack(Character human, Character orc, int turn)
{
     int temp;
     bool outcome;

     switch (turn)
     {
            case 0:
                 temp = ((rand() % 30) + 1);

                 if (human.GetAgility() >= temp)
                    outcome = true;
                 else
                    outcome = false;
                 break;
            case 1:
                 outcome = false;
                 break;
     }

return outcome;
}

There is no fancy code where the function is used at the minute, so there's no point posting that too.

Turn is set to 0, hence why there is only one case at the moment as i tested it and it keeps returning true, and i have no idea why! There are no compile errors, just the incorrect return!

human.GetAgility() simply returns the agility of the human character class

Any ideas as to why this keeps happening would be greatly appreciated, as i've been looking at it and pulling my hair out for a couple of evenings over this.

Swoopy: yeah i did seed the number generator

Dave: i have no idea what that code you just wrote does, lol , i've only been doing C++ a couple of months

Looks like it's a bit pointless having the orc parameter since it's not used

Use a debugger to find out the values of temp and human.GetAgility(). Use that information to continue your debugging.

Originally Posted by TheColonial

Looks like it's a bit pointless having the orc parameter since it's not used

I'm planning on using it in the 'case 2' statement, i was just intending on getting case 1 working first :P

Thanks for the ideas guys, ill continue to play with it and see what i come up with