damage dealt algorithm

All the variables associated with the bottom code.

Code:

    char combat;
    int mhp1=20;
    int fight;
    int fcom=((strength*3)+agility/fight);
    int finalcom=(mhp1-fcom);

The evil stuff giving me trouble.

Code:

	case 'f':
	cout<<"You encounter one dumb sunava..........";
	do{
	fight=rand()%5;
	cin>>combat;
	if(combat=='a'){
	cout<<finalcom;
	cout<<fcom;
	}
	}while(finalcom>0);
	break;

It works fine except I get some insane numbers like -130593985794. My mud is just over 100 lines so I don't want to post the entire thing.

What's getting you insane numbers where?

How can you divide agility by fight when you haven't even initialized fight yet?

Heck, how can you print finalcom and fcom before you've put values in them?

Code:

fight=rand()%5;
cin>>combat;

if(combat=='a'){
  //You need to put your calculations of finalcom and fcom here.
  cout<<finalcom;
  cout<<fcom;

C++ is not a symbolic language (or whatever that's called), so even if you say "x = 3a + 2", if you change 'a' later in the program, x won't change.

If I were you, I wouldn't use the rand() as you might find it a little predictable. Try using srand(). If you don't know how to use that then read the tutorial at the cprogramming website.

he should use rand. srand only seeds the randomizer and should only be called once each program.

I am using srand I just didn't post it. Since I'm way off how should I do it?

>>Since I'm way off how should I do it?

Originally Posted by Hunter2

//You need to put your calculations of finalcom and fcom here.

I changed it to this, but it just terminates when it gets to calculating these values.

Code:

	do{
	fight=rand()%5;
	cin>>combat;
	if(combat=='a'){
	return ((strength*3)+agility/fight)==finalcom;
	cout<<finalcom;
	}
	}while(finalcom>0);

What do I change now?

>>return ((strength*3)+agility/fight)==finalcom;
You really ought to go over your basics of C++ syntax again.

'return' quits the function, returning the value specified.
== is the equality comparison operator, i.e. it gives you true if the left-hand side is equal to the right-hand side and false otherwise.

What you want is the = (assignment) operator, which takes the value on the right-hand side and stores it in the variable specified on the left-hand side.

See if you can figure out what to do. Hint: Study my previous comment very carefully, then go back to your first post and read over the first code sample very carefully.

Code:

finalcom=((strength*3)+agility/fight);

Gosh so easy to figure out. Before now I've never done something like that in code. I plugged my numbers in though I entered 7 for strength and 7 for agility and my random number is 1-5, but my program returned 24. Any idea why?

>>and my random number is 1-5
Just to make sure you realize this, rand() % 5 will give you from 0 to 4.

(strength*3) + agility/fight
= 7*3 + 7/(random from 1 to 5)

If fight is 1, agility/fight is 7/1, which is 7.
If fight is 5, agility/fight is 7/5, which is truncated to 1.

Therefore, (strength*3) + agility/fight
is
21 + (some number from 1 to 7)

I need another set of parentheses I want it to go from left to right.

Code:

finalcom=(((strength*3)+agility)/fight);

Doesn't using srand like this stop it from generating 0?

Code:

srand( (unsigned int) time (0));

No, it just makes sure that the random numbers you generate will be different each time you run the program. Otherwise, you'll get the same sequence of numbers every time.

This works fine if I take out the cout at the end, but while its in it has an error. Should I put a for loop in the while loop so when the monsters hp goes down it stays down?

Code:

	case 'f':
	cout<<"You encounter one dumb sunava..........";
	while(finalcom>0){              //fight
	fight=rand()%6;
	cin>>combat;
	if(combat=='a'){                //attack
	fcom=(((strength*3)+agility)/fight);
	finalcom=mhp1-fcom;                   //calculations
	}
	if(finalcom>0){
	cout<<finalcom;
	}
	}
	cout<<"He is dead";

No, it just makes sure that the random numbers you generate will be different each time you run the program.

Then how can I stop it from generating 0.