Hey everyone,
So I came across this piece of code that I found very very interesting:
do people still do this type of thing? You could easily just create a function that has the same effect, but curiously does anyone still use macros in this way? Just wondering - ChapCode:#define oldmax(x, y) ((x)>(y)?(x):(y))
Have you seen the code submitted in an obfuscated code contest?
I do see stuff like that every once in awhile in people programs but it makes me cringe every time.
lol Yelton...I went to the link you put up and all I have to say is damn....that is some of the most ridiculous stuff I have ever seen haha.
you should actually give jessycat's program a run - it really is great work...Originally Posted by Chaplin27
I would avoid macros as much as possible. yes, you can do that in a function, and yes, you should do that in a function.
Join is in our Unofficial Cprog IRC channel
Server: irc.phoenixradio.org
Channel: #Tech
Team Cprog Folding@Home: Team #43476
Download it Here
Detailed Stats Here
More Detailed Stats
52 Members so far, are YOU a member?
Current team score: 1223226 (ranked 374 of 45152)
The CBoard team is doing better than 99.16% of the other teams
Top 5 Members: Xterria(518175), pianorain(118517), Bennet(64957), JaWiB(55610), alphaoide(44374)
Last Updated on: Wed, 30 Aug, 2006 @ 2:30 PM EDT
> do people still do this type of thing?
It's pointless in C++, since an inline function is just as quick, and is way safer than a macro.
In C, macros are sometimes used to replace functions on the pretence that it saves "a function call". Mostly this seems to be premature optimisation.
However, C99 introduces the inline keyword as well, so hopefully such things will diminish in use.
As written, that macro + this code probably compiles, though what answer you get is a matter of luck
Code:char *foo = oldmax( "hello", "world" );
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
How about defining integers?
In a big program, would you do this:
Or would you avoid that, since its a macro, and do like this:Code:#define ID_EXIT 100012 //...a LOT of codes, functions, integers... goes here //and finaly: case ID_EXIT:
Or would you go for a other solution?Code:case 100012:
http://livebad.com/nuka
Da-Nuka
const unsigned ID_EXIT = 100012;How about defining integers?
In a big program, would you do this:
Or would you avoid that, since its a macro, and do like this:Code:#define ID_EXIT 100012 //...a LOT of codes, functions, integers... goes here //and finaly: case ID_EXIT:
Or would you go for a other solution?Code:case 100012:
"...the results are undefined, and we all know what "undefined" means: it means it works during development, it works during testing, and it blows up in your most important customers' faces." --Scott Meyers
Hmm..what is best if you only care about app-size and memory-usage?
#define,
or const int ?
Last edited by Da-Nuka; 03-02-2005 at 01:14 PM.
http://livebad.com/nuka
Da-Nuka
