Thread: I always seem to be one step off (Loop question)

I can't seem to get this code to work 100%, the smaller number keeps coming up as a -8******* number, everything else seems to be in order.

Code:

//This program will display the largest and smallest numbers entered.

#include <iostream>
using namespace std;

int main()

{
	int num;
	int LargeNum;
	int SmallNum;


	cout << "Enter an integer: "; 
		cin >> num;

while (num != -99)
	{
		cout << "Enter another integer or enter -99 to stop." << endl;
			cin >> num;
				if (num > LargeNum)
					LargeNum = num;
				if (num < SmallNum && num !=-99)
					SmallNum=num;
	}

	cout << "The largest number entered was: " << LargeNum << endl;
	cout << "The smallest number entered was: " << SmallNum << endl;



return 0;
}

You must initialize the SmallNum and LargeNum, otherwise, it will be trash values. For example, SmallNum start as -5689596. A doubt that you will enter a number smaller than this.

SmallNum = MAX_VALUE; // you choose the maximum value
LargeValue = -99; // the user will alwas enter a value greater than this


EDIT: 7stud, sorry we reply at same time.

In any case, I would not recommend your implementation. There is no reason to hard code max and min values

I don't agree with alot of what the book says, but i'm a beginner and these are simple homework assignments, so I can't do it any other way at this point.

As you wish 7stud :

Code:

#include <iostream>
using namespace std;

int main()

{
    int num;
    int LargeNum;
    int SmallNum;


    cout << "Enter an integer: "; 
        cin >> num;
       LargeNum = SmallNum = num;
while (num != -99)
    {
        cout << "Enter another integer or enter -99 to stop." << endl;
            cin >> num;
                if (num > LargeNum)
                    LargeNum = num;
                if (num < SmallNum && num !=-99)
                    SmallNum=num;
    }

    cout << "The largest number entered was: " << LargeNum << endl;
    cout << "The smallest number entered was: " << SmallNum << endl;



return 0;
}

Thanks alot Mortissus, explain to me in Lehman's terms how that computes?

EDIT- When I assigned the variables values, the output was giving me the smallest number only, not the largest, that's why I ask.

Originally Posted by Mortissus

EDIT - I saw you edit now, are you telling that the code does not worK?

no no, it works now, I also see what you are saying as far as LargeNum technically being the same as SmallNum.

Once I read these codes a few times it sinks in.


Thank again

Hey Mortissus,

Even without the poster saying, it was pretty obvious this was homework. Maybe you should consider not just posting solutions, which provide very little real help to a beginner.

Homework or not, he posted a great piece of code. He was not asking for us to do it. And, it is his responsability to learn. If he don´t do this now it is his problem later. I´ve made little to help, one line of code... do you think this is such a problem? I don´t...

Homework or not, he posted a great piece of code.

Ok, if you say so.

He was not asking for us to do it.

Then why did you?

I´ve made little to help, one line of code... do you think this is such a problem?

Which robbed him of the learning experience. Part of programming has to do with struggling through certain concepts. The struggle often teaches a new programmer many different things as different solutions are attempted. And, the lessons learned during the struggle tend to make a bigger impression in our minds than just reading the correct answer.

Well I obviously appreciate his help, but I had everything right except the output of the smallest integer, so I don't see it as that big of a deal, but I suppose I can see your point, 7stud.

Originally Posted by 7stud

Ok, if you say so.

The code solves the problem.

Originally Posted by 7stud

Then why did you?

It costs me nothing, I like to help.

Originally Posted by 7stud

Which robbed him of the learning experience. Part of programming has to do with struggling through certain concepts. The struggle often teaches a new programer many different things as different solutions are attempted. And, the lessons learned during the struggle tend to make a bigger impression in our minds than just reading the correct answer.

It seems that he is going to learn something:

Originally Posted by SquirrelRJ

Once I read these codes a few times it sinks in.

And also:

Originally Posted by 7stud

In any case, I would not recommend your implementation. There is no reason to hard code max and min values.

Really? And why is that? He learned two good ways of solving this problem. If you hadn´t talk this way, I wouldn´t post the solution.