Yes, but if you look at his code...
He's reassigning average by dividing each individual grade by the counter. He should be summing the grades, then dividing that by the counter.Code:do{ i++; MyData >> hope.id >> hope.numgrade; hope.average = hope.numgrade/i;
The point here is that it will not work for all possible cases and thus is sloppy code.Code:Code: 0 1 0 0 1 --> total = 2 1 2 3 4 5 --> i = 5 average = 2/5 = 0
i don't think most standard compilers support programmers with more than 4 red boxes - Misplaced
It is my sacred duity to stand in the path of the flood of ignorance and blatant stupidity... - quzah
Such pointless tricks ceased to be interesting or useful when we came down from the trees and started using higher level languages. - Salem
Well, this was my first thought as well, which is why I pointed out the uninitialized variable. In my experience, uninitialized variables tend to take on astronomically huge values, and therefore the result of the division:I don't see how that's possible since the scores are going to be 30, 50, 70, 90, etc., so a running total of scores should always be greater than the number of students.
100 (or even 200, assuming you're a maniac brainiac) / (astronomically huge) -> 0.00
is not entirely unexpected.
Besides, AH_Tze (not the original poster I'll admit) has already noticed and mostly corrected (aside from redundancy problems) the problematic average-calculating formula.
Last edited by Hunter2; 02-10-2005 at 06:34 PM.
Just Google It. √
(\ /)
( . .)
c(")(") This is bunny. Copy and paste bunny into your signature to help him gain world domination.
Yes, you are right. I was thinking about how it should be, and not how the poster actually did it. They actually started off with this:He's reassigning average by dividing each individual grade by the counter. He should be summing the grades, then dividing that by the counter.
hope.average = hope.average/hope.total;
which will result in 0 everytime when you initialize hope.average with 0--regardless of the integer division problem. That formula for an average is a little disconcerting coming from a teacher.
Last edited by 7stud; 02-10-2005 at 09:14 PM.
Well, back when I was in school, teachers also tought indentationThat formula for an average is a little disconcerting coming from a teacher.
-Edit-
In fact, I'm fairly certain one of the first things we learned was how to make legible code - indenation and commenting.
Last edited by Kaelin; 02-11-2005 at 08:28 AM.
