hi all
i want to be able scan text moving from word to word with an iterator and which ever that word the iterator is on push it into a vector
this is what i have but i get an error
Code:string format_paragraph(vector<string> words, int text_width) vector<string>::iterator pos; for(pos=words.end();pos != words.begin(); pos++) words.push_back(pos);
push_back takes a value_type. Try dereferencing the iterator.
Code:words.push_back(*pos);
Kampai!
nice thanx a lot it works but the only problem is it segfaults.
any other ideas?
What is wrong with that code?Originally Posted by twigboy
well i should proly decrement pos so it should be pos-- but other than that i dont know
Good start.
Look into reverse iterators if you really want to iterate in reverse.
Also, always remember that you shouldn't use the iterator at foo.end() - it is bad to use it by dereferencing, you might just get a seg fault - the only reason it is there is for comparison to see if you are done.
Ah, tunnel vision sucks.
However, notice that the first item in the vector is ignored by the loop since it's a stopping condition. That's why I added another push_back after the loop. A better solution is what Daved suggested.Code:for (pos = words.end() - 1; pos != words.begin(); --pos) words.push_back(*pos); words.push_back(*pos);
Code:vector<string>::reverse_iterator pos; for (pos = words.rbegin(); pos != words.rend(); ++pos) words.push_back(*pos);
Kampai!
thanx guys thats awsome
Isn't the push_back operation going to invalidate the iterator? Once you start pushing the strings back onto the very same vector you are iterating over it is going to invalidate those iterators you are using in the loop. Am I the only one that sees this? You shouldn't iterate over the same container that you are simultaneously modifying. You probably need to use a second vector to push onto.
"Owners of dogs will have noticed that, if you provide them with food and water and shelter and affection, they will think you are god. Whereas owners of cats are compelled to realize that, if you provide them with food and water and shelter and affection, they draw the conclusion that they are gods."
-Christopher Hitchens
>Am I the only one that sees this?
I was thinking the same thing, but thought maybe I was missing something.It seems you would need a second vector.
