Thread: Help with Black Jack Game

Yes both are global.

here is a list of all my global vars

Code:

int CStay;           //COMPUTER STAYS
int PStay;             //PLAYER STAYS
int Played;            //TOTAL GAMES PLAYED
int Player;            //PLAYER TOTAL CARDS
int Computer;         //COMPUTER TOTAL CARDS
int Won = 0;           //GAMES WON
int Lost = 0;          //GAMES LOST
int Tie = 0;            //GAMES TIED
int PAgain;           //PLAY AGAIN INPUT FROM PLAYER
int Again = 1;      //PLAY AGAIN
int Cont;             //CONTINUE?

It looks like you have a few too many calls to other functions in main(). And also, you don't need the "do" statements at all. The best thing is to have a simple WHILE loop control whether or not your program is running:

while (Exit == false)

....for example. If you can contain everything in a nice while or for loop, you can avoid writing extra lines where you make calls to the same functions again and again. Also, the use of global variables is generally frowned on because ANY function can alter them, which defeats the purpose of encapsulating data and hiding it from functions that do not need to be tampering with it.

im pretty new to functions, this was an exercise from my book, only it wasnt in as great detail as im making it, i added many features to the game.

ive pin pointed the problem to be (like i think you said) my int main function, where i call all the other functions. tomorrow, im going to write a new int main function on some paper, and then try that out.