cin.get() problem

This is a discussion on cin.get() problem within the C++ Programming forums, part of the General Programming Boards category; Ill explain first what the problem is and then show code: I recently discovered this site and read up on ...

  1. #1
    Registered User
    Join Date
    Jan 2005
    Posts
    11

    cin.get() problem

    Ill explain first what the problem is and then show code:

    I recently discovered this site and read up on the cin.get(); so that text can be displayed before the program closes. I used it for when certain text is displayed, the user can press any key and then the program will process clrscr();. As you can see in my code, I used cin.get() two times. Once after rules are displayed and twice to clear die results. the cin.get() works for the first time I use it but it seems to skip the second cin.get().

    My program randomizes die results 1 to 100 and if you roll over a number you win your bet back+bet (DOUBLE).

    Code:
    #include<iostream.h>
    #include<stdlib.h>
    #include<conio.h>
    int main()
        {
        randomize();
        int money, bet;
        cout<<"\t\t\tBETTING GAME\n\n\n";
        cout<<"RULES:\n\n";
        cout<<"1. Enter your starting money when prompted.\n";
        cout<<"2. Type in your bet when prompted.\n";
        cout<<"3. Roll Higher then 65 and you win DOUBLE your bet.\n";
        cout<<"4. Roll a 1 or a 100 and win TRIPPLE your bet.\n";
        cout<<"5. If you want to chashout, enter in '9999' when the next\n";
        cout<<"betting time comes.\n";
        cout<<"6. After you cashout you will see if you won money or lost money.\n\n\n";
        cout<<"Press any key to continue once you've understood these rules.";
        cin.get();
        clrscr();
        cout<<"How much money would you like to start with?: ";
        cin>>money;
        clrscr();
        cout<<" ____________________\n";
        cout<<"|       MONEY        |\n";
        cout<<"|--------------------|\n";
        cout<<"     "<<money<<"           \n";
        cout<<"|____________________|\n";
        for(int die=random(100)+1;3==3;die=random(100)+1) {
            cout<<"How much do you want to bet?(9999 to quit): ";
            cin>>bet;
            if(bet==9999){
                break;}
            money=money-bet;
            cout<<"You rolled a "<<die;
            if(die>65) {
                money=money+bet+bet;
                cout<<" and won DOUBLE your bet.\n";
            }
            else if(die==1||die==100) {
                money=money+bet+bet+bet;
                cout<<" and won TRIPPLE your bet.\n";
            }
            else if(die>1&&die<66) {
                cout<<" Sorry, better luck next time.\n";
            }
            cout<<"Press any key to continue...";
            cin.get();
            clrscr();
        cout<<" ____________________\n";
        cout<<"|       MONEY        |\n";
        cout<<"|--------------------|\n";
        cout<<"      "<<money<<"            \n";
        cout<<"|____________________|\n";
        }
        return(0);
        }
    Also having problems with the else if's... when win double your bet, you only get your bet back and not the extra +bet. Cashout block not added yet til I know what the solution is to my current problem.

  2. #2
    Registered User
    Join Date
    Jan 2005
    Posts
    11
    Well i geuss no one realizes what I want to fix so i'll say it simply:

    I used a cin.get(); in the beginning of the code so the program will continue what its doing and then runs into another cin.get() but it doesn't wait for me to press a key, it just skips it. How would i fix this?

  3. #3
    Registered User
    Join Date
    Aug 2003
    Posts
    1,209
    The problem is with cin, cin leaves a trailing '\n' in the inputstream. So when you call cin.get() to have the user press enter, there already is a '\n' in the stream that will be picked up by cin.get(), and thus it sort of skips that. To fix do this:
    Code:
    // bla bla bla
    cin >> somevar;
    cin.ignore();

    About your problem with the doublebet and so on, it does exactly what you tell it to. Think about it, you tell the user to input how much to bet, you then take away that amount from their money. Then if you roll higher than 65 you add 2*bet. This is basicly what you are doing:
    Code:
    int var = 50;
    var -= 10;
    var += 20;    // After this var == 60.

  4. #4
    Registered User
    Join Date
    Jan 2005
    Posts
    11
    i used the cin>>somevar; and cin.ignore(); and set somevar to 'a' and works. Next question, Is there a way to make it so that in my for loop if a certain condition is met within, the for statement will start from the beginning again rather then finish the remaining blocks of code contained in the for loop?

  5. #5
    & the hat of GPL slaying Thantos's Avatar
    Join Date
    Sep 2001
    Posts
    5,681
    Just something to note:
    Code:
        cout<<" ____________________\n";
        cout<<"|       MONEY        |\n";
        cout<<"|--------------------|\n";
        cout<<"      "<<money<<"            \n";
        cout<<"|____________________|\n";
    Could be written as:
    Code:
        cout<<" ____________________\n"
            <<"|       MONEY        |\n"
            <<"|--------------------|\n"
            <<"      "<<money<<"            \n"
            <<"|____________________|\n"
            <<flush;
    or even:
    Code:
        cout<<" ____________________\n"
              "|       MONEY        |\n"
              "|--------------------|\n"
              "      "<<money<<"            \n"
              "|____________________|\n"
            <<flush;
    I only mention because well I'm up way to early

  6. #6
    Registered User
    Join Date
    Aug 2003
    Posts
    1,209
    Use the continue keyword to have the loop start another pass.

    Code:
    #include <iostream>
    using namespace std;
    
    int main()
    {
        for(int i=1; i<=5; i++)
        {
            if(i == 3)
                continue;
            cout << i << endl;
        }
        cin.get();
    }
    This will print
    1
    2
    4
    5

    Also I forgot to point these things out in your other post. You shouldnt use iostream.h, stdlib.h. Replace those with these lines:
    Code:
    #include <iostream>
    #include <cstdlib>
    using namespace std;
    And just so you know, C++ has a standard way of getting random numbers, search for rand() and srand().

  7. #7
    Registered User
    Join Date
    Jan 2005
    Posts
    11
    Quote Originally Posted by Shakti
    And just so you know, C++ has a standard way of getting random numbers, search for rand() and srand().
    Unfortunately Im using Borland C++ ver 4.52 (Old)
    and .h has to be included or it will not open, and the stdlib will only work =/

  8. #8
    Registered User
    Join Date
    Aug 2003
    Posts
    1,209
    Get bloodshed's Dev C++. It is free and comes with a very good C++ compiler.

  9. #9
    Registered User
    Join Date
    Jan 2005
    Posts
    11

    works as intended to work.. well sorta

    works as intended tho however, I was hoping to have \n for cin.get(); can be used over and over instead of adding cin>>var; cin.ignore(); .. still works thx for the help everyone.

    Code:
    #include<iostream.h>
    #include<stdlib.h>
    #include<conio.h>
    int main()
        {
        randomize();
        int money, bet, a;
        char pass='ok', ans;
        cout<<"\t\t\tBETTING GAME\n\n\n";
        cout<<"RULES:\n\n";
        cout<<"1. Enter your starting money when prompted.\n";
        cout<<"2. Type in your bet when prompted.\n";
        cout<<"3. Roll Higher then 65 and you win DOUBLE your bet.\n";
        cout<<"4. Roll a 1 or a 100 and win TRIPPLE your bet.\n";
        cout<<"5. If you want to chashout, enter in '9999' when the next\n";
        cout<<"betting time comes.\n";
        cout<<"6. After you cashout you will see if you won money or lost money.\n\n\n";
        cout<<"Press any key to continue once you've understood these rules.";
        cin.get();
        do{
        clrscr();
        cout<<"How much money would you like to start with?: ";
        cin>>money;
        a=money;
        clrscr();
        cout<<" ____________________\n"
        <<"|       MONEY        |\n"
        <<"|--------------------|\n"
        <<"     "<<money<<"           \n"
        <<"|____________________|\n"
        <<flush;
        for(int die=random(100)+1;3==3;die=random(100)+1) {
            if(money<=0) {
                cout<<"You are out of money. ";
                break;}
            cout<<"How much do you want to bet?(9999 to quit): ";
            cin>>bet;
            if((bet>money)&&(bet!=9999)) {
                cout<<"You cannot bet over the amount of money you have!\n";
                cout<<"Enter 'ok' to continue:...";
                cin>>pass;
                cin.ignore();
                clrscr();
                cout<<" ____________________\n"
                <<"|       MONEY        |\n"
                <<"|--------------------|\n"
                <<"     "<<money<<"           \n"
                <<"|____________________|\n"
                <<flush;
                continue;
                }
            if(bet==9999){
                break;}
            money=money-bet;
            cout<<"You rolled a "<<die;
            if(die>65) {
                money=money+bet+bet;
                cout<<" and won DOUBLE your bet.\n";
            }
            else if((die==1)||(die==100)) {
                money=money+bet+bet+bet;
                cout<<" and won TRIPPLE your bet.\n";
            }
            else if((die>1)&&(die<66)) {
                cout<<" Sorry, better luck next time.\n";
            }
            cout<<"Enter in 'ok' to continue:...";
            cin>>pass;
            cin.ignore();
            clrscr();
            cout<<" ____________________\n"
            <<"|       MONEY        |\n"
            <<"|--------------------|\n"
            <<"     "<<money<<"           \n"
            <<"|____________________|\n"
            <<flush;
        }
        if(money>a) {
            cout<<"You won a profit of "<<(money-a)<<".";}
        if(money<a) {
            cout<<"You lost "<<(a-money)<<".\n";}
            cout<<"Do you want to play again?(Y/N): ";
            cin>>ans;
        }while(ans=='y'||ans=='Y');
        return(0);
        }

  10. #10
    Registered User
    Join Date
    Jan 2005
    Posts
    11
    Quote Originally Posted by Shakti
    Get bloodshed's Dev C++. It is free and comes with a very good C++ compiler.
    Thanks! Ill use that.

  11. #11
    Registered User
    Join Date
    Jan 2005
    Posts
    204
    I have noticed one thing. If you do something like this:
    Code:
    #include <iostream>
    #include <string>
    
    int main()
    {
        std::string name;
        
        std::cout << "What's your name? ";
        std::getline(std::cin, name);
    
        std::cout << "Hi " << name << '\n';
    
        std::cin.get();
    
        return 0;
    }
    cin.get() will not work because you used it as a parameter to getline(). You have to put a std::cin.sync() before std::cin.get().

  12. #12
    Registered User
    Join Date
    Aug 2003
    Posts
    1,209
    I have no problem with that, so it must be your compiler that is buggy. Are you perhaps using VC 6??

  13. #13
    Registered User
    Join Date
    Jan 2005
    Posts
    204
    Dev-C++ (lastest version)

  14. #14
    Registered User
    Join Date
    Aug 2003
    Posts
    1,209
    I tried it on dev c++ 4.9.9.1 and I had no problem with that code, cin.get() worked fine.

  15. #15
    Registered User
    Join Date
    Jul 2005
    Location
    US
    Posts
    6

    Talking Shakti, U Guru !!!

    Shakti! Your advice works!
    Using cin.ignore(); before cin.get(); pauses the console at the end! Before, everytime I used the cin >> function and cin.get(), the console doesn't stay open at the end. Now, with cin.ignore(); used right before cin.get();, it works. Thanks Shakti.

    Also, what is the difference between iostream.h, stdlib.h and

    Code:
    #include <iostream>
    #include <cstdlib>
    using namespace std;

Page 1 of 2 12 LastLast
Popular pages Recent additions subscribe to a feed

Similar Threads

  1. Someone having same problem with Code Block?
    By ofayto in forum C++ Programming
    Replies: 1
    Last Post: 07-12-2007, 09:38 AM
  2. A question related to strcmp
    By meili100 in forum C++ Programming
    Replies: 6
    Last Post: 07-07-2007, 03:51 PM
  3. WS_POPUP, continuation of old problem
    By blurrymadness in forum Windows Programming
    Replies: 1
    Last Post: 04-20-2007, 07:54 PM
  4. cin.get(); problem
    By J.P. in forum C++ Programming
    Replies: 19
    Last Post: 12-14-2006, 07:07 AM
  5. Laptop Problem
    By Boomba in forum Tech Board
    Replies: 1
    Last Post: 03-07-2006, 06:24 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21