Thread: Coin counting (logic problem)

Whoa whoa!
You forgot to ask the user how much change he/she has!

Code:

cout << "What is the change amount? ";
cin >> change;

Ok, look at this

Code:

#include <iostream>
//#include <conio.h> Not standard C++ :(

// We could do: using namespace std;
// But we'd be including more than we need/want!
using std::cout;
using std::cin;
using std::endl;

int main() {
 int change;
 int quarters=0, dimes=0, nickels=0, pennies=0;


 cout << "What is the change amount? ";
 cin >> change;

while(change > 0)
    {
     if (change >= 25)
     {
     quarters++;
     change = change - 25;
     continue;
     }
     if(change >= 10)
     {
     dimes++;
     change = change - 10;
     continue;
     }
     if(change >= 5)
     {
     nickels++;
     change = change - 5;
     continue;
     }
     if(change >=1)
     {
     pennies++;
     change = change - 1;
     continue;
     }
} // <-- You forgot to stop your while loop

 cout << "Quarters: " << quarters << endl;
 cout << "Dimes:    " << dimes  << endl;
 cout << "Nickels:  " << nickels  << endl;
 cout << "Pennies:  " << pennies  << endl;

 return 0;
}

This crashes BUT I can see just as it crashes, that the logic is correct. (I entered 35, and got 1 quarter, and 1 dime) then it crashed.

Originally Posted by xlokix

This crashes BUT I can see just as it crashes, that the logic is correct. (I entered 35, and got 1 quarter, and 1 dime) then it crashed.

Code:

#include <stdio.h>
------------------[BLAHBLAHBLAH]
cout << "Quarters: " << quarters << endl;
cout << "Dimes:    " << dimes  << endl;
cout << "Nickels:  " << nickels  << endl;
cout << "Pennies:  " << pennies  << endl;

getchar();getchar();

return 0;
}

Try adding the snippets that to the source so that the window doesn't autoclose!

Well I'm trying to keep it simple, My teacher probably wouldn't believe I wrote the code if I included stdio.h, since we've never learned that before. Or getchar (whatever the hell that is ). But yes, that did fix the crash. Is there another way around it without stdio.h ?

Here, I'll update on what I have so far.

Code:

#include <iostream.h>
#include <stdio.h>


main()
{
    int change;
    int q=0,d=0,n=0,p=0;
    cout << "What is the change?";
    cin >> change;
    
    while(change > 0)
    {
     if (change >= 25)
     {
     q++;
     change = change - 25;
     continue;
     }
     if(change >= 10)
     {
     d++;
     change = change - 10;
     continue;
     }
     if(change >= 5)
     {
     n++;
     change = change - 5;
     continue;
     }
     if(change >=1)
     {
     p++;
     change = change - 1;
     continue;
     }
  }    
        cout << "Amount of quarters " << q << '\n';
        cout << "Amount of dimes " << d << '\n';
        cout << "Amount of nickels " << n << '\n';
        cout << "Amount of pennies " << p << '\n';
    getchar();getchar();
    return 0;
}

I don't recommend telling a C++ student to use C functions, and then challenge the instructor. There's a curriculum to follow and all you'll do is throw a rock into the machine. Not to mention that is a complete garbage solution to what he's asking. There is a member function of cin which would suit perfectly, however I'd sooner let his curriculum teach the method first. Just giving the answers robs him of a valuable learning tool...studying.

In my experience, instructors don't look at the compiled/executable file. They are only interested in the sourcecode which they look over themselves to verify the student has grasped the concepts the project places before them (as well as observe their logic skills). The window closing upon program exit is a non issue.

Actually, I'm in C++ 1, and there will be no C++ 2 next year. So I will not learn more. And it's only a half a year class, so I'm finished with the class in about a week.

Before the way I'm using now, I wrote something similar to scribblers way and got weird numbers so I changed my method.

Ok. Next up, Project 2!
Oh boy this is going to be a long one. The user thinks of a number, and the program guesses. The program makes a guess of 50, then the user tells whether it's higher or lower until the program eventually gets it.
Booo! I'm gonna eat dinner before I start this. Leave some suggestions on how to start it if you want. I presume that there will be a hell of a lot of nested if statements.

I won't post any code for that project, but it's a typical learning tool.

Hint. Search your textbook for binary search method.