Thread: char string problem

Hi!

Please check out the code below.

Code:

#include<iostream>
#include<string>
#include<fstream>
using namespace std;

void main()
{
	char input[20]="\0\0";
	cout<<"English word?: ";
	cin>>input;
	ifstream fs;
	char let[2]="\0";
	char wrd[20]="\0\0";
	int i=0;
	fs.open("lib.txt", ios::in);
	while(fs.peek()!='.') //check word end
	{
		fs.read(let,1);
		wrd[i] = let[0]; //create word
		i++;
	}
	if(input==wrd)
	{
		cout<<wrd;
	}
}

The problem is that the if-statement doesn’t detect it when input and wrd
seems to contains the same string. Please show me my fault.

Thanks in advance.

-geek@02

Thanks for that.

Yet another problem cropped up. I changed the above code a bit:

Code:

#include<iostream>
#include<string>
#include<fstream>
using namespace std;

void main()
{
	char input[20]="\0";
	cout<<"English word: ";
	cin>>input;
	ifstream fs;
	char let='\0';
	char wrd[20]="\0";
	int i=0;
	fs.open("lib.txt", ios::in);
	
	while(!fs.eof())
	{
		while(fs.peek()!=':') //check word end
		{
			let = fs.get();
			wrd[i] = let; //create word
			i++;
		}
		if(!strcmp(input, wrd))
		{
			cout<<wrd;
		}
		fs.seekg(1);
		i=0;
		for(int k=0; k<=20; k++)
		{
			wrd[k]='\0';
		}
	}
}

Everything works fine during the 1st go of the outer while loop. But in the 2nd time looping, after get() is executed, the file pointer seems to jump 2 positions backwards. Why is this happening please?

You should never loop on eof(), if you want to read untill you run out of things to read you loop untill you cannot read anymore, then check eof() to see if the reason you stopped was because you ran out of things to read. My guess is that you are using seekg to skip a position, and as hk_mp5kpdw pointed out you are actually moving to the second char in the file.

fortunately if you use std::string this becomes a good bit easer, I think this is what you are trying to do

Code:

int main() {
    using namespace std;
    cout << "Enter a word to search for in file\n:";
    string input;
    if(cin >> input) {
        ifstream fs("lib.txt");
        int wordcount=0;
        string word;
        while(getline(fs,word,':')) {
            if(input == word) {
                cout << "word #" << wordcount << " == " << word << endl;
            }
            ++wordcount;
        }
    } else {
        cerr << "standard input failure, giving up" << endl;
        return 2;
    }
    return 0;
}

This version requres that there be no whitespace in lib.txt, and is case sensitive. Input ignores whitespace. Thus if lib.txt contains "pear: apple:grape" and the user enters " apple" input will be equal to "apple" and word will be " apple".

getline consumes it's terminator. The string returned does not contain the terminator. If the file ends before a terminator, but characters were read then eof() is true but so is good() If you loop on eof() you will exit before handling trailing characters. If the final character is a terminator then eof() is false and you will expect more data where none exists.

Yes I’m using seekg() to skip ‘:’. Now I replaced it with another get().
Thanks for the eof() explanation and all, guys.