compile problem

I have a problem with this code ,can someone help.Thank you

Code:

---

#include <iostream>
using namespace std;

void main()
{
    int number= get_number();
    int results=return_results();
}
int get_number()
{
        int num;
        int temp_num=0;
        int temp_num_pos=0;
        int temp_num_neg=0;
        int count=1;
        while (count<=10)
    {
        cout << "Enter a number" <<endl;
                cin >> num ;
        count++;
        temp_num+=num;
       
        if(num>0)temp_num_pos+=num;
       
        if(num<0)temp_num_neg+=num;
       
        }
}

int return_results()
{
    int temp_num=0;
    int temp_num_pos=0;
        int temp_num_neg=0;
    cout <<"The sum of positive numbers is" << temp_num_pos<< endl;
    cout <<"The sum of negative numbers is" << temp_num_neg<< endl;
    cout <<"The sum of all numbers is" << temp_num<< endl;
return 0;
}

---

1) You aren't using [code][/code] tags
2) You are using void main()

Fix those two points and I'll look at the rest.

a. Please use code tags. (See announcements at the top of the forum.)
b. Please ask a specific question and give detail. What do you want it to do? Does it compile? What compiler errors do you get? Is it a runtime issue? What is it giving you and what do you expect? Etc.

cpp(6) : error C2065: 'get_number' : undeclared identifier
cpp(7) : error C2065: 'return_results' : undeclared identifier
cpp(10) : error C2373: 'get_number' : redefinition; different type modifiers
cpp(31) : error C2373: 'return_results' : redefinition; different type modifiers
Error executing cl.exe.

you need to prototype them:

Code:

---

#include <iostream>
using namespace std;

int get_number();
int return_results();

int main()

---

first off try

Code:

---

get_number(number);

---

instead of

Code:

---

int number= get_number();

---

also
like stated above

Code:

---

int get_number();
int return_results();

---

ill let you figure out the rest on your own ;)
both of them are wrong up there in int main();
and both easy fixes :)

look a noob that uses code tags :)

Quote:

---

Originally Posted by Sphearion

first off try

Code:

---

get_number(number);

---

instead of

Code:

---

int number= get_number();

---

---

No, theres nothing wrong with that part of his code. His function get_number returns an int and takes no parameters, so what he has is correct. Is it supposed to return an int? Well, that I can't answer.

However, there are some logic problems. The function get_number() is supposed to return an int but nothing is returned. Also, you'll need to look into scoping, because I'm guessing that you are thinking your temp values you calculate in get_number() will show up in return_results(), which is not true. Since they are declared in your first function, they will be destroyed when the function ends. Since you redeclare them in the second function, it will print the values as zero every time no matter what the user enters.