Problem with a char variable set as a letter

Ok in a program I'm working on I have a variable declared as such:

Code:

char newgrade;

Now in a function I'm trying to set this variable to equal a letter based upon the comparison of variable to a number, such as this:

Code:

     if(gradevar>=1 || gradevar<=1&&gradevar>=.90)
     {
         newgrade="A";
     }

Now, I was taught that the "char" variable was used to store a letter. If so why am I getting the error: invalid conversion from `const char*' to `char'? Is there a diffrent variable I should use? Would it be better to use a string as the variable type? Or if possible explain what the error meant?


Also I have tried using an array and I get the same error.

Using the double quotes (") around something declares it as an array of chars (C-style strings are such things), but you just want a single char which should be enclosed in a single quote (') also known as an apostrophe.

Thanks Lucky that worked like a charm

Off posted question, but problem may come back to bite you later anyway, so take a look at the logic of the conditional:

if(gradevar >=1 || gradevar<=1 && gradevar>=.90)

In order to be true gradevar will need to be 1 and only 1. That's because 1 is both >= and <= 1 and also >= .9. Any other value for gradevar will be evaluated as false. Now, that may be what you wanted, but I doubt it. I suspect you would be better off like this:

if(gradevar >= 1 || (gradevar <= 1 && gradevar >= .9))

but better yet is probably something like this:

if(gradevar >= 0.9)

Eventhough boolean logic ends up as a simple true/false result sooner or later, it still trips people (myself included) up as often as anything else.

Originally Posted by elad

Off posted question, but problem may come back to bite you later anyway, so take a look at the logic of the conditional:

if(gradevar >=1 || gradevar<=1 && gradevar>=.90)

In order to be true gradevar will need to be 1 and only 1. That's because 1 is both >= and <= 1 and also >= .9. Any other value for gradevar will be evaluated as false. Now, that may be what you wanted, but I doubt it. I suspect you would be better off like this:

if(gradevar >= 1 || (gradevar <= 1 && gradevar >= .9))

but better yet is probably something like this:

if(gradevar >= 0.9)

Eventhough boolean logic ends up as a simple true/false result sooner or later, it still trips people (myself included) up as often as anything else.

Wow thanks, you just fixed another bug in my program (god I love this forum )

Actually logical AND has a higher priority than logical OR, so it worked fine the first time. Mind you, placing full parenthese is still more clear, and of course the simplification applies.

Well, how'd ya like them apples. I thought they were of equal precedence and the conditional was read from left to right. Thanks.