binary trees

This is a discussion on binary trees within the C++ Programming forums, part of the General Programming Boards category; Hi there all. We are doing binary search trees. I'm having a little bit of trouble here though. Okay I ...

  1. #1
    Registered User
    Join Date
    Apr 2003
    Posts
    78

    binary trees

    Hi there all. We are doing binary search trees. I'm having a little bit of trouble here though. Okay I need to as a few questions though.
    here is the code observe
    Code:
    #include <iostream>
    
    using namespace std;
    
    
    struct node
    {
    	int info;
    	node *left;
    	node *right;
    };
    node *root=new(node); //why declare root as a new node?
    inorder(node); //is this the correct syntax for declaring the function?
    insert(node *p, int x); //for user defined functions using pointers?
    
    void insert(node *&p, int x)
    { 
    	if(p==NULL)
    	{
    		p=new(node); //if root has been declared why make  a
    		p->info=x;      //a new node in the insert function
    		p->left=NULL;
    		p->right=NULL;
    	}
    else if(x < p->info) 
    {
    	insert(p->left,  x);
    }
    else   insert(p->right, x);
    
    void inorder(node *p)
    {
    	if(p!=NULL)
    	{
    		inorder(p->left);
    		cout<<p->info;
    		inorder(p->right);
    	}
    }
    
    void main()
    {
    	insert(root);
    }
    
    
    }
    with all of that being said what do you think I can do with this to make these functions run correctly

  2. #2
    Registered User hk_mp5kpdw's Avatar
    Join Date
    Jan 2002
    Location
    Northern Virginia/Washington DC Metropolitan Area
    Posts
    3,788
    Got a few problems at least you should take care of:

    Code:
    #include <iostream>
    
    using namespace std;
    
    
    struct node
    {
        int info;
        node *left;
        node *right;
    };
    
    //The line below should be in main and you should probably
    //not be allocating memory for a new node at this point,
    //that will be done in the insert function, you
    //should just set it to NULL in main
    node *root=new(node); //why declare root as a new node?
    
    // Forgot to add the return types for the two functions below
    void inorder(node *p); //is this the correct syntax for declaring the function?
    void insert(node *p, int x); //for user defined functions using pointers?
    
    void insert(node *&p, int x)  // This differs from the function prototype you provided above
    { 
        if(p==NULL)
        {
            p=new(node); //if root has been declared why make  a
            p->info=x;      //a new node in the insert function
            p->left=NULL;
            p->right=NULL;
        }
        else if(x < p->info) 
        {
            insert(p->left,  x);
        }
        else   insert(p->right, x);
    }  // You were missing an ending bracket, add this
    
    void inorder(node *p)
    {
        if(p!=NULL)
        {
            inorder(p->left);
            cout<<p->info;
            inorder(p->right);
        }
    }
    
    void main() // main should always return an int
    {
        insert(root);  // Your insert function takes two parameters but you only provide one
    }
    
    
    } // Delete this
    [edit]Found a small error I missed the first time around, change is in blue above[/edit]
    Last edited by hk_mp5kpdw; 11-29-2004 at 01:42 PM.
    "Owners of dogs will have noticed that, if you provide them with food and water and shelter and affection, they will think you are god. Whereas owners of cats are compelled to realize that, if you provide them with food and water and shelter and affection, they draw the conclusion that they are gods."
    -Christopher Hitchens

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. A Binary Search Tree of... Binary Search Trees...
    By SlyMaelstrom in forum C++ Programming
    Replies: 5
    Last Post: 12-10-2005, 01:12 PM
  2. Binary Trees
    By wvu2005 in forum C Programming
    Replies: 7
    Last Post: 10-15-2005, 04:59 PM
  3. Binary Search Trees Part III
    By Prelude in forum A Brief History of Cprogramming.com
    Replies: 16
    Last Post: 10-02-2004, 03:00 PM
  4. Tutorial review
    By Prelude in forum A Brief History of Cprogramming.com
    Replies: 11
    Last Post: 03-22-2004, 08:40 PM
  5. Request for comments
    By Prelude in forum A Brief History of Cprogramming.com
    Replies: 15
    Last Post: 01-02-2004, 09:33 AM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21